Browse Source

Update test for undefined setting to expect null

pull/24512/head
maliming 1 month ago
parent
commit
f5a3526d7b
No known key found for this signature in database GPG Key ID: A646B9CB645ECEA4
  1. 13
      modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

13
modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

@ -18,11 +18,10 @@ public class SettingManager_Basic_Tests : SettingsTestBase
} }
[Fact] [Fact]
public async Task Should_Throw_Exception_When_Try_To_Get_An_Undefined_Setting() public async Task Should_Return_Null_When_Try_To_Get_An_Undefined_Setting()
{ {
await Assert.ThrowsAsync<AbpException>( var value = await _settingProvider.GetOrNullAsync("UndefinedSetting");
async () => await _settingProvider.GetOrNullAsync("UndefinedSetting") value.ShouldBeNull();
);
} }
[Fact] [Fact]
@ -64,7 +63,7 @@ public class SettingManager_Basic_Tests : SettingsTestBase
(await _settingManager.GetOrNullGlobalAsync("MySetting1")).ShouldBe("43"); (await _settingManager.GetOrNullGlobalAsync("MySetting1")).ShouldBe("43");
(await _settingProvider.GetOrNullAsync("MySetting1")).ShouldBe("43"); (await _settingProvider.GetOrNullAsync("MySetting1")).ShouldBe("43");
} }
[Fact] [Fact]
public async Task Set_Should_Throw_Exception_If_Provider_Not_Found() public async Task Set_Should_Throw_Exception_If_Provider_Not_Found()
{ {
@ -72,7 +71,7 @@ public class SettingManager_Basic_Tests : SettingsTestBase
{ {
await _settingManager.SetAsync("MySetting1", "43", "UndefinedProvider", "Test"); await _settingManager.SetAsync("MySetting1", "43", "UndefinedProvider", "Test");
}); });
exception.Message.ShouldBe("Unknown setting value provider: UndefinedProvider"); exception.Message.ShouldBe("Unknown setting value provider: UndefinedProvider");
} }
} }

Loading…
Cancel
Save