Browse Source

abp nav tag helper improvements

pull/670/head
Yunus Emre Kalkan 8 years ago
parent
commit
fa8aa1fe06
  1. 2
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelper.cs
  2. 9
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelperService.cs
  3. 2
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelper.cs
  4. 5
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelperService.cs

2
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelper.cs

@ -2,8 +2,6 @@
{ {
public class AbpNavItemTagHelper : AbpTagHelper<AbpNavItemTagHelper, AbpNavItemTagHelperService> public class AbpNavItemTagHelper : AbpTagHelper<AbpNavItemTagHelper, AbpNavItemTagHelperService>
{ {
public bool? Active { get; set; }
public bool? Dropdown { get; set; } public bool? Dropdown { get; set; }
public AbpNavItemTagHelper(AbpNavItemTagHelperService tagHelperService) public AbpNavItemTagHelper(AbpNavItemTagHelperService tagHelperService)

9
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelperService.cs

@ -11,7 +11,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
output.Attributes.AddClass("nav-item"); output.Attributes.AddClass("nav-item");
SetDropdownClass(context, output); SetDropdownClass(context, output);
SetActiveClass(context, output);
} }
protected virtual void SetDropdownClass(TagHelperContext context, TagHelperOutput output) protected virtual void SetDropdownClass(TagHelperContext context, TagHelperOutput output)
@ -21,13 +20,5 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
output.Attributes.AddClass("dropdown"); output.Attributes.AddClass("dropdown");
} }
} }
protected virtual void SetActiveClass(TagHelperContext context, TagHelperOutput output)
{
if (TagHelper.Active ?? false)
{
output.Attributes.AddClass("active");
}
}
} }
} }

2
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelper.cs

@ -8,8 +8,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
public bool? Active { get; set; } public bool? Active { get; set; }
public bool? Disabled { get; set; } public bool? Disabled { get; set; }
public string Href { get; set; }
public AbpNavLinkTagHelper(AbpNavLinkTagHelperService tagHelperService) public AbpNavLinkTagHelper(AbpNavLinkTagHelperService tagHelperService)
: base(tagHelperService) : base(tagHelperService)

5
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelperService.cs

@ -13,11 +13,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
output.TagName = "a"; output.TagName = "a";
output.TagMode = TagMode.StartTagAndEndTag; output.TagMode = TagMode.StartTagAndEndTag;
SetClasses(context, output); SetClasses(context, output);
if (!string.IsNullOrWhiteSpace(TagHelper.Href))
{
output.Attributes.Add("href", TagHelper.Href);
}
} }
protected virtual void SetClasses(TagHelperContext context, TagHelperOutput output) protected virtual void SetClasses(TagHelperContext context, TagHelperOutput output)

Loading…
Cancel
Save