Browse Source

Enable nullable annotations for Volo.Abp.RemoteServices

pull/17020/head
liangshiwei 3 years ago
parent
commit
fbb606a206
  1. 2
      framework/src/Volo.Abp.RemoteServices/Volo.Abp.RemoteServices.csproj
  2. 3
      framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/IRemoteServiceConfigurationProvider.cs
  3. 8
      framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfiguration.cs
  4. 7
      framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationDictionary.cs
  5. 2
      framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationProvider.cs
  6. 3
      framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationProviderExtensions.cs

2
framework/src/Volo.Abp.RemoteServices/Volo.Abp.RemoteServices.csproj

@ -5,6 +5,8 @@
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>netstandard2.0;netstandard2.1;net7.0</TargetFrameworks> <TargetFrameworks>netstandard2.0;netstandard2.1;net7.0</TargetFrameworks>
<Nullable>enable</Nullable>
<WarningsAsErrors>Nullable</WarningsAsErrors>
<AssemblyName>Volo.Abp.RemoteServices</AssemblyName> <AssemblyName>Volo.Abp.RemoteServices</AssemblyName>
<PackageId>Volo.Abp.RemoteServices</PackageId> <PackageId>Volo.Abp.RemoteServices</PackageId>
<AssetTargetFallback>$(AssetTargetFallback);portable-net45+win8+wp8+wpa81;</AssetTargetFallback> <AssetTargetFallback>$(AssetTargetFallback);portable-net45+win8+wp8+wpa81;</AssetTargetFallback>

3
framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/IRemoteServiceConfigurationProvider.cs

@ -8,6 +8,5 @@ public interface IRemoteServiceConfigurationProvider
[ItemNotNull] [ItemNotNull]
Task<RemoteServiceConfiguration> GetConfigurationOrDefaultAsync(string name); Task<RemoteServiceConfiguration> GetConfigurationOrDefaultAsync(string name);
[ItemCanBeNull] Task<RemoteServiceConfiguration?> GetConfigurationOrDefaultOrNullAsync(string name);
Task<RemoteServiceConfiguration> GetConfigurationOrDefaultOrNullAsync(string name);
} }

8
framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfiguration.cs

@ -2,12 +2,12 @@
namespace Volo.Abp.Http.Client; namespace Volo.Abp.Http.Client;
public class RemoteServiceConfiguration : Dictionary<string, string> public class RemoteServiceConfiguration : Dictionary<string, string?>
{ {
/// <summary> /// <summary>
/// Base Url. /// Base Url.
/// </summary> /// </summary>
public string BaseUrl { public string? BaseUrl {
get => this.GetOrDefault(nameof(BaseUrl)); get => this.GetOrDefault(nameof(BaseUrl));
set => this[nameof(BaseUrl)] = value; set => this[nameof(BaseUrl)] = value;
} }
@ -15,7 +15,7 @@ public class RemoteServiceConfiguration : Dictionary<string, string>
/// <summary> /// <summary>
/// Version. /// Version.
/// </summary> /// </summary>
public string Version { public string? Version {
get => this.GetOrDefault(nameof(Version)); get => this.GetOrDefault(nameof(Version));
set => this[nameof(Version)] = value; set => this[nameof(Version)] = value;
} }
@ -25,7 +25,7 @@ public class RemoteServiceConfiguration : Dictionary<string, string>
} }
public RemoteServiceConfiguration(string baseUrl, string version = null) public RemoteServiceConfiguration(string baseUrl, string? version = null)
{ {
this[nameof(BaseUrl)] = baseUrl; this[nameof(BaseUrl)] = baseUrl;
this[nameof(Version)] = version; this[nameof(Version)] = version;

7
framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationDictionary.cs

@ -3,11 +3,11 @@ using JetBrains.Annotations;
namespace Volo.Abp.Http.Client; namespace Volo.Abp.Http.Client;
public class RemoteServiceConfigurationDictionary : Dictionary<string, RemoteServiceConfiguration> public class RemoteServiceConfigurationDictionary : Dictionary<string, RemoteServiceConfiguration?>
{ {
public const string DefaultName = "Default"; public const string DefaultName = "Default";
public RemoteServiceConfiguration Default { public RemoteServiceConfiguration? Default {
get => this.GetOrDefault(DefaultName); get => this.GetOrDefault(DefaultName);
set => this[DefaultName] = value; set => this[DefaultName] = value;
} }
@ -20,8 +20,7 @@ public class RemoteServiceConfigurationDictionary : Dictionary<string, RemoteSer
?? throw new AbpException($"Remote service '{name}' was not found and there is no default configuration."); ?? throw new AbpException($"Remote service '{name}' was not found and there is no default configuration.");
} }
[CanBeNull] public RemoteServiceConfiguration? GetConfigurationOrDefaultOrNull(string name)
public RemoteServiceConfiguration GetConfigurationOrDefaultOrNull(string name)
{ {
return this.GetOrDefault(name) return this.GetOrDefault(name)
?? Default; ?? Default;

2
framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationProvider.cs

@ -18,7 +18,7 @@ public class RemoteServiceConfigurationProvider : IRemoteServiceConfigurationPro
return Task.FromResult(Options.RemoteServices.GetConfigurationOrDefault(name)); return Task.FromResult(Options.RemoteServices.GetConfigurationOrDefault(name));
} }
public Task<RemoteServiceConfiguration> GetConfigurationOrDefaultOrNullAsync(string name) public Task<RemoteServiceConfiguration?> GetConfigurationOrDefaultOrNullAsync(string name)
{ {
return Task.FromResult(Options.RemoteServices.GetConfigurationOrDefaultOrNull(name)); return Task.FromResult(Options.RemoteServices.GetConfigurationOrDefaultOrNull(name));
} }

3
framework/src/Volo.Abp.RemoteServices/Volo/Abp/Http/Client/RemoteServiceConfigurationProviderExtensions.cs

@ -10,8 +10,7 @@ public static class RemoteServiceConfigurationProviderExtensions
this IRemoteServiceConfigurationProvider provider) this IRemoteServiceConfigurationProvider provider)
=> provider.GetConfigurationOrDefaultAsync(RemoteServiceConfigurationDictionary.DefaultName); => provider.GetConfigurationOrDefaultAsync(RemoteServiceConfigurationDictionary.DefaultName);
[ItemNotNull] public static Task<RemoteServiceConfiguration?> GetConfigurationOrDefaultOrNullAsync(
public static Task<RemoteServiceConfiguration> GetConfigurationOrDefaultOrNullAsync(
this IRemoteServiceConfigurationProvider provider) this IRemoteServiceConfigurationProvider provider)
=> provider.GetConfigurationOrDefaultOrNullAsync(RemoteServiceConfigurationDictionary.DefaultName); => provider.GetConfigurationOrDefaultOrNullAsync(RemoteServiceConfigurationDictionary.DefaultName);
} }
Loading…
Cancel
Save