Browse Source

Revise some TODOs.

pull/81/head
Halil İbrahim Kalkan 10 years ago
parent
commit
fbd822204b
  1. 1
      src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EntityFrameworkCore/IdentityDbContext.cs
  2. 2
      src/Volo.Abp.Identity/Volo/Abp/Identity/IdentityUser.cs
  3. 2
      src/Volo.Abp.Identity/Volo/Abp/Identity/UserStore.cs
  4. 5
      test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/Initialize_Tests.cs

1
src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EntityFrameworkCore/IdentityDbContext.cs

@ -65,7 +65,6 @@ namespace Volo.Abp.Identity.EntityFrameworkCore
//Split configuration to dedicated classes //Split configuration to dedicated classes
//TODO: Set Default Values for properties
builder.Entity<IdentityUser>(b => builder.Entity<IdentityUser>(b =>
{ {
b.ToTable("IdentityUsers"); b.ToTable("IdentityUsers");

2
src/Volo.Abp.Identity/Volo/Abp/Identity/IdentityUser.cs

@ -11,7 +11,7 @@ using Volo.ExtensionMethods.Collections.Generic;
namespace Volo.Abp.Identity namespace Volo.Abp.Identity
{ {
//TODO: Add Name/Surname/FullName? //Add Name and Surname properties?
public class IdentityUser : AggregateRoot, IHasConcurrencyStamp public class IdentityUser : AggregateRoot, IHasConcurrencyStamp
{ {

2
src/Volo.Abp.Identity/Volo/Abp/Identity/UserStore.cs

@ -329,7 +329,7 @@ namespace Volo.Abp.Identity
if (role == null) if (role == null)
{ {
throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, "Role {0} does not exist.", normalizedRoleName)); //TODO: Localize throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, "Role {0} does not exist!", normalizedRoleName));
} }
user.AddRole(_guidGenerator, role.Id); user.AddRole(_guidGenerator, role.Id);

5
test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/Initialize_Tests.cs

@ -20,9 +20,8 @@ namespace Volo.Abp.Identity
{ {
ServiceProvider.GetRequiredService<IdentityRoleManager>(); ServiceProvider.GetRequiredService<IdentityRoleManager>();
} }
//TODO: Move this service to Volo.Abp.EntityFrameworkCore.Tests since it's actually testing the EF Core repository registration! [Fact] //Move this test to Volo.Abp.EntityFrameworkCore.Tests since it's actually testing the EF Core repository registration!
[Fact]
public void Should_Resolve_Repositories() public void Should_Resolve_Repositories()
{ {
(ServiceProvider.GetRequiredService<IIdentityUserRepository>() is EfCoreIdentityUserRepository).ShouldBeTrue(); (ServiceProvider.GetRequiredService<IIdentityUserRepository>() is EfCoreIdentityUserRepository).ShouldBeTrue();

Loading…
Cancel
Save