From 8c7bc2e55896d405c155c605cb8160438ae433b9 Mon Sep 17 00:00:00 2001
From: maliming <malimings@gmail.com>
Date: Tue, 11 Oct 2022 09:34:11 +0800
Subject: [PATCH] Disable autocomplete for password inputs.

Resolve #14241
---
 .../Volo.Abp.Account.Web/Pages/Account/ResetPassword.cshtml   | 4 ++--
 .../Pages/Identity/Users/CreateModal.cshtml                   | 2 +-
 .../Pages/Identity/Users/EditModal.cshtml                     | 2 +-
 .../Components/EmailSettingGroup/Default.cshtml               | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/modules/account/src/Volo.Abp.Account.Web/Pages/Account/ResetPassword.cshtml b/modules/account/src/Volo.Abp.Account.Web/Pages/Account/ResetPassword.cshtml
index 4fad4f91cc..40b8d87048 100644
--- a/modules/account/src/Volo.Abp.Account.Web/Pages/Account/ResetPassword.cshtml
+++ b/modules/account/src/Volo.Abp.Account.Web/Pages/Account/ResetPassword.cshtml
@@ -11,8 +11,8 @@
             <p>@L["ResetPassword_Information"]</p>
             <abp-input asp-for="UserId"/>
             <abp-input asp-for="ResetToken"/>
-            <abp-input asp-for="Password"/>
-            <abp-input asp-for="ConfirmPassword"/>
+            <abp-input asp-for="Password" autocomplete="new-password" />
+            <abp-input asp-for="ConfirmPassword" autocomplete="new-password" />
             <a abp-button="Secondary" asp-page="./Login">@L["Cancel"]</a>
             <abp-button type="submit" button-type="Primary" text="@L["Submit"].Value"/>
         </form>
diff --git a/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/CreateModal.cshtml b/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/CreateModal.cshtml
index b192a5323b..2a4216d5d7 100644
--- a/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/CreateModal.cshtml
+++ b/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/CreateModal.cshtml
@@ -29,7 +29,7 @@
                         <div class="mb-3">
                             <label asp-for="UserInfo.Password" class="form-label">@L["Password"] *</label>
                             <div class="input-group">
-                                <input type="password" class="form-control" maxlength="@IdentityUserConsts.MaxPasswordLength" asp-for="UserInfo.Password" />
+                                <input type="password" class="form-control" autocomplete="new-password" maxlength="@IdentityUserConsts.MaxPasswordLength" asp-for="UserInfo.Password" />
                                 <button class="btn btn-secondary" type="button" id="PasswordVisibilityButton"><i class="fa fa-eye-slash" aria-hidden="true"></i></button>
                             </div>
                             <span asp-validation-for="UserInfo.Password"></span>
diff --git a/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/EditModal.cshtml b/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/EditModal.cshtml
index db0dd8422e..28d0fd6da6 100644
--- a/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/EditModal.cshtml
+++ b/modules/identity/src/Volo.Abp.Identity.Web/Pages/Identity/Users/EditModal.cshtml
@@ -29,7 +29,7 @@
                         <div class="mb-3">
                             <label asp-for="UserInfo.Password" class="form-label">@L["Password"]</label>
                             <div class="input-group">
-                                <input type="password" class="form-control" maxlength="@IdentityUserConsts.MaxPasswordLength" asp-for="UserInfo.Password"/>
+                                <input type="password" class="form-control" autocomplete="new-password" maxlength="@IdentityUserConsts.MaxPasswordLength" asp-for="UserInfo.Password"/>
                                 <button class="btn btn-secondary" type="button" id="PasswordVisibilityButton">
                                     <i class="fa fa-eye-slash" aria-hidden="true"></i>
                                 </button>
diff --git a/modules/setting-management/src/Volo.Abp.SettingManagement.Web/Pages/SettingManagement/Components/EmailSettingGroup/Default.cshtml b/modules/setting-management/src/Volo.Abp.SettingManagement.Web/Pages/SettingManagement/Components/EmailSettingGroup/Default.cshtml
index a5e0275535..f653ec54a0 100644
--- a/modules/setting-management/src/Volo.Abp.SettingManagement.Web/Pages/SettingManagement/Components/EmailSettingGroup/Default.cshtml
+++ b/modules/setting-management/src/Volo.Abp.SettingManagement.Web/Pages/SettingManagement/Components/EmailSettingGroup/Default.cshtml
@@ -21,7 +21,7 @@
                 <div id="HideSectionWhenUseDefaultCredentialsIsChecked" @Html.Raw(Model.SmtpUseDefaultCredentials ? "style=\"display: none;\"" : "")>
                     <abp-input asp-for="SmtpDomain"/>
                     <abp-input asp-for="SmtpUserName"/>
-                    <abp-input type="password" asp-for="SmtpPassword"/>
+                    <abp-input type="password" autocomplete="new-password" asp-for="SmtpPassword"/>
                 </div>
             </div>
             <hr class="my-4"/>