Browse Source

Use order as key when registering block components rather than ID

pull/7427/head
Andrew Kingston 4 years ago
parent
commit
2f2c28cf4d
  1. 2
      packages/client/src/components/Block.svelte
  2. 2
      packages/client/src/components/BlockComponent.svelte

2
packages/client/src/components/Block.svelte

@ -14,7 +14,7 @@
} }
// Remove existing instance of this component in case props changed // Remove existing instance of this component in case props changed
structureLookupMap[parentId] = structureLookupMap[parentId].filter( structureLookupMap[parentId] = structureLookupMap[parentId].filter(
blockComponent => blockComponent.instance._id !== id blockComponent => blockComponent.order !== order
) )
// Add new instance of this component // Add new instance of this component
structureLookupMap[parentId].push({ order, instance }) structureLookupMap[parentId].push({ order, instance })

2
packages/client/src/components/BlockComponent.svelte

@ -39,7 +39,7 @@
// ejected later // ejected later
$: { $: {
if ($builderStore.inBuilder) { if ($builderStore.inBuilder) {
block.registerComponent(id, order, $component?.id, instance) block.registerComponent(id, order ?? 0, $component?.id, instance)
} }
} }
</script> </script>

Loading…
Cancel
Save