Browse Source

fix e2e

pull/4023/head
Martin McKeaveney 6 years ago
parent
commit
417002beaa
  1. 12
      packages/builder/cypress/integration/screens.spec.js
  2. 2
      packages/builder/cypress/support/commands.js
  3. 2
      packages/builder/src/components/userInterface/ComponentNavigationTree/PathTree.svelte
  4. 1
      packages/builder/src/components/userInterface/NewScreenModal.svelte
  5. 4
      packages/client/src/render/screenRouter.js

12
packages/builder/cypress/integration/screens.spec.js

@ -7,17 +7,7 @@ context('Screen Tests', () => {
cy.navigateToFrontend()
})
it('Should successful create a screen', () => {
it('Should successfully create a screen', () => {
cy.createScreen("test Screen", "/test")
})
it('Should rename a screen', () => {
cy.get(".components-pane").within(() => {
cy.contains("Settings").click()
cy.get("input[name=_instanceName]").clear().type("About Us").blur()
})
cy.get('.nav-items-container').within(() => {
cy.contains("About Us").should('exist')
})
})
})

2
packages/builder/cypress/support/commands.js

@ -166,6 +166,6 @@ Cypress.Commands.add("createScreen", (screenName, route) => {
cy.contains("Create Screen").click()
})
cy.get(".nav-items-container").within(() => {
cy.contains(screenName).should("exist")
cy.contains(route).should("exist")
})
})

2
packages/builder/src/components/userInterface/ComponentNavigationTree/PathTree.svelte

@ -36,7 +36,7 @@
indentLevel={indent || 1}
selected={$store.currentPreviewItem._id === screenId}
opened={$store.currentPreviewItem._id === screenId}
text={url === "/" ? "Home" : url}
text={url === '/' ? 'Home' : url}
withArrow={route.subpaths}
on:click={() => changeScreen(screenId)}>
<ScreenDropdownMenu screen={screenId} />

1
packages/builder/src/components/userInterface/NewScreenModal.svelte

@ -76,6 +76,7 @@
if (createLink) {
await store.actions.components.links.save(route, name)
}
await store.actions.routing.fetch()
if (templateIndex !== undefined) {
const template = templates[templateIndex]

4
packages/client/src/render/screenRouter.js

@ -43,7 +43,9 @@ export const screenRouter = ({ screens, onScreenSelected, window }) => {
return sanitize(url)
}
const routes = screens.map(screen => makeRootedPath(screen?.routing.route))
const routes = screens.map(screen =>
makeRootedPath(screen.routing ? screen.routing.route : null)
)
let fallback = routes.findIndex(([p]) => p === makeRootedPath("*"))
if (fallback < 0) fallback = 0

Loading…
Cancel
Save