From acc71cb0e9879f3f5cd82a3b9faa74be2e7b346e Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Mon, 22 Aug 2022 11:08:52 +0100
Subject: [PATCH] Allow configuring whether notification is automatically
 dismissed or not

---
 .../actions/ShowNotification.svelte                  | 11 ++++++++---
 packages/client/src/stores/notification.js           | 12 ++++++++----
 packages/client/src/utils/buttonActions.js           |  4 ++--
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/ShowNotification.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/ShowNotification.svelte
index ed4ecc273..ca8e82ea7 100644
--- a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/ShowNotification.svelte
+++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/ShowNotification.svelte
@@ -1,5 +1,5 @@
 <script>
-  import { Select, Label } from "@budibase/bbui"
+  import { Select, Label, Checkbox } from "@budibase/bbui"
   import { onMount } from "svelte"
   import DrawerBindableInput from "components/common/bindings/DrawerBindableInput.svelte"
 
@@ -28,17 +28,22 @@
     if (!parameters.type) {
       parameters.type = "success"
     }
+    if (parameters.autoDismiss == null) {
+      parameters.autoDismiss = true
+    }
   })
 </script>
 
 <div class="root">
-  <Label small>Type</Label>
+  <Label>Type</Label>
   <Select bind:value={parameters.type} options={types} placeholder={null} />
-  <Label small>Message</Label>
+  <Label>Message</Label>
   <DrawerBindableInput
     value={parameters.message}
     on:change={e => (parameters.message = e.detail)}
   />
+  <Label />
+  <Checkbox text="Auto dismiss" bind:value={parameters.autoDismiss} />
 </div>
 
 <style>
diff --git a/packages/client/src/stores/notification.js b/packages/client/src/stores/notification.js
index 9c3dfd152..bbde660fd 100644
--- a/packages/client/src/stores/notification.js
+++ b/packages/client/src/stores/notification.js
@@ -62,10 +62,14 @@ const createNotificationStore = () => {
     subscribe: store.subscribe,
     actions: {
       send,
-      info: msg => send(msg, "info", "Info"),
-      success: msg => send(msg, "success", "CheckmarkCircle"),
-      warning: msg => send(msg, "warning", "Alert"),
-      error: msg => send(msg, "error", "Alert", false),
+      info: (msg, autoDismiss) =>
+        send(msg, "info", "Info", autoDismiss ?? true),
+      success: (msg, autoDismiss) =>
+        send(msg, "success", "CheckmarkCircle", autoDismiss ?? true),
+      warning: (msg, autoDismiss) =>
+        send(msg, "warning", "Alert", autoDismiss ?? true),
+      error: (msg, autoDismiss) =>
+        send(msg, "error", "Alert", autoDismiss ?? false),
       blockNotifications,
       dismiss,
     },
diff --git a/packages/client/src/utils/buttonActions.js b/packages/client/src/utils/buttonActions.js
index 7cc0679a2..a534ee832 100644
--- a/packages/client/src/utils/buttonActions.js
+++ b/packages/client/src/utils/buttonActions.js
@@ -301,11 +301,11 @@ const continueIfHandler = action => {
 }
 
 const showNotificationHandler = action => {
-  const { message, type } = action.parameters
+  const { message, type, autoDismiss } = action.parameters
   if (!message || !type) {
     return
   }
-  notificationStore.actions[type]?.(message)
+  notificationStore.actions[type]?.(message, autoDismiss)
 }
 
 const handlerMap = {