fixing CI

6 years ago · e244e099a6
8 changed files with 14 additions and 26 deletions
--- a/.eslintrc.json
+++ b/.eslintrc.json
@ -21,6 +21,7 @@
    }
  ],
  "rules": {
-    "prettier/prettier": "error"
+    "prettier/prettier": "error",
+    "no-self-assign": "off"
  }
 }
--- a/packages/builder/src/builderStore/store/index.js
+++ b/packages/builder/src/builderStore/store/index.js
@ -251,12 +251,12 @@ const renameScreen = store => (oldname, newname) => {

 const savePage = store => async page => {
  store.update(state => {
-    if (s.currentFrontEndType !== "page" || !s.currentPageName) {
+    if (state.currentFrontEndType !== "page" || !state.currentPageName) {
      return state
    }

-    s.pages[s.currentPageName] = page
-    _savePage(s)
+    state.pages[state.currentPageName] = page
+    _savePage(state)
    return state
  })
 }
@ -271,7 +271,9 @@ const addStylesheet = store => stylesheet => {

 const removeStylesheet = store => stylesheet => {
  store.update(state => {
-    state.pages.stylesheets = s.pages.stylesheets.filter(s => s !== stylesheet)
+    state.pages.stylesheets = state.pages.stylesheets.filter(
+      s => s !== stylesheet
+    )
    _savePage(state)
    return state
  })
@ -446,7 +448,7 @@ const setComponentCode = store => code => {
    // save without messing with the store
    _saveScreenApi(state.currentPreviewItem, state)

-    return s
+    return state
  })
 }

--- a/packages/builder/src/components/userInterface/AppPreview/iframeTemplate.js
+++ b/packages/builder/src/components/userInterface/AppPreview/iframeTemplate.js
@ -32,8 +32,8 @@ export default ({
          text-transform: uppercase;
          font-weight: bold;
        }
-    <\/style>
-    <\script>
+    </style>
+    <script>
        window["##BUDIBASE_FRONTEND_DEFINITION##"] = ${frontendDefinition};
        window["##BUDIBASE_FRONTEND_FUNCTIONS##"] = ${currentPageFunctions};

@ -41,7 +41,7 @@ export default ({
        .then(module => {
            module.loadBudibase({ window, localStorage });
        })
-    <\/script>
+    </script>
  </head>
  <body>
  </body>
--- a/packages/builder/tests/createProps.spec.js
+++ b/packages/builder/tests/createProps.spec.js
@ -29,15 +29,6 @@ describe("createDefaultProps", () => {
    expect(props._component).toBe("some_component")
  })

-  it("should return error when component name not supplied", () => {
-    const comp = getcomponent()
-    comp.name = ""
-
-    const { errors } = createProps(comp)
-
-    expect(errors.length).toEqual(1)
-  })
-
  it("should create a object with single blank string value, when prop definition is 'string' ", () => {
    const comp = getcomponent()
    comp.props.fieldName = "string"
--- a/packages/cli/package.json
+++ b/packages/cli/package.json
@ -11,9 +11,6 @@
  "publishConfig": {
    "access": "public"
  },
-  "scripts": {
-    "test": "test"
-  },
  "keywords": [
    "budibase"
  ],
--- a/packages/cli/src/commands/new/appDirectoryTemplate/package.json
+++ b/packages/cli/src/commands/new/appDirectoryTemplate/package.json
@ -2,9 +2,6 @@
  "name": "name",
  "version": "1.0.0",
  "description": "",
-  "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
-  },
  "author": "",
  "license": "ISC",
  "dependencies": {
--- a/packages/server/src/api/controllers/model.js
+++ b/packages/server/src/api/controllers/model.js
@ -39,7 +39,7 @@ exports.create = async function(ctx) {
  ctx.body = newModel
 }

-exports.update = async function(ctx) {}
+exports.update = async function() {}

 exports.destroy = async function(ctx) {
  const db = new CouchDB(ctx.params.instanceId)
--- a/packages/server/src/api/controllers/view.js
+++ b/packages/server/src/api/controllers/view.js
@ -1,7 +1,7 @@
 const CouchDB = require("../../db")

 const controller = {
-  query: async ctx => {},
+  query: async () => {},
  fetch: async ctx => {
    const db = new CouchDB(ctx.params.instanceId)
    const designDoc = await db.get("_design/database")