Browse Source

Add helpers into BBUI rather than frontend core and fix A11y issue

pull/4434/head
Andrew Kingston 4 years ago
parent
commit
e3258a0caf
  1. 2
      packages/bbui/src/ColorPicker/ColorPicker.svelte
  2. 4
      packages/bbui/src/Form/Core/DatePicker.svelte
  3. 4
      packages/bbui/src/Form/Core/Dropzone.svelte
  4. 1
      packages/bbui/src/Label/Label.svelte
  5. 2
      packages/bbui/src/Table/Table.svelte
  6. 0
      packages/bbui/src/helpers.js
  7. 3
      packages/bbui/src/index.js

2
packages/bbui/src/ColorPicker/ColorPicker.svelte

@ -5,7 +5,7 @@
import { fly } from "svelte/transition"
import Icon from "../Icon/Icon.svelte"
import Input from "../Form/Input.svelte"
import { capitalise } from "../utils/helpers"
import { capitalise } from "../helpers"
export let value
export let size = "M"

4
packages/bbui/src/Form/Core/DatePicker.svelte

@ -5,7 +5,7 @@
import "@spectrum-css/textfield/dist/index-vars.css"
import "@spectrum-css/picker/dist/index-vars.css"
import { createEventDispatcher } from "svelte"
import { generateID } from "../../utils/helpers"
import { uuid } from "../../helpers"
export let id = null
export let disabled = false
@ -16,7 +16,7 @@
export let appendTo = undefined
const dispatch = createEventDispatcher()
const flatpickrId = `${generateID()}-wrapper`
const flatpickrId = `${uuid()}-wrapper`
let open = false
let flatpickr
$: flatpickrOptions = {

4
packages/bbui/src/Form/Core/Dropzone.svelte

@ -3,7 +3,7 @@
import "@spectrum-css/typography/dist/index-vars.css"
import "@spectrum-css/illustratedmessage/dist/index-vars.css"
import { createEventDispatcher } from "svelte"
import { generateID } from "../../utils/helpers"
import { uuid } from "../../helpers"
import Icon from "../../Icon/Icon.svelte"
import Link from "../../Link/Link.svelte"
import Tag from "../../Tags/Tag.svelte"
@ -37,7 +37,7 @@
"jfif",
]
const fieldId = id || generateID()
const fieldId = id || uuid()
let selectedImageIdx = 0
let fileDragged = false
let selectedUrl

1
packages/bbui/src/Label/Label.svelte

@ -21,6 +21,7 @@
class="icon"
class:icon-small={size === "M" || size === "S"}
on:mouseover={() => (showTooltip = true)}
on:focus={() => (showTooltip = true)}
on:mouseleave={() => (showTooltip = false)}
>
<Icon name="InfoOutline" size="S" disabled={true} />

2
packages/bbui/src/Table/Table.svelte

@ -4,7 +4,7 @@
import CellRenderer from "./CellRenderer.svelte"
import SelectEditRenderer from "./SelectEditRenderer.svelte"
import { cloneDeep } from "lodash"
import { deepGet } from "../utils/helpers"
import { deepGet } from "../helpers"
/**
* The expected schema is our normal couch schemas for our tables.

0
packages/frontend-core/src/utils/helpers.js → packages/bbui/src/helpers.js

3
packages/bbui/src/index.js

@ -81,3 +81,6 @@ export { default as clickOutside } from "./Actions/click_outside"
// Stores
export { notifications, createNotificationStore } from "./Stores/notifications"
// Helpers
export * as Helpers from "./helpers"

Loading…
Cancel
Save