Browse Source

fix sql server error: main_test.go dtmsvr.PopulateDB(false) invokes GetPlaceHoldSQL(sql)

pull/467/head
徐云金YunjinXu 2 years ago
parent
commit
e233895e1c
  1. 21
      client/dtmcli/dtmimp/db_special.go
  2. 4
      client/dtmcli/dtmimp/utils.go

21
client/dtmcli/dtmimp/db_special.go

@ -78,27 +78,6 @@ func init() {
dbSpecials[DBTypePostgres] = &postgresDBSpecial{}
}
// TODO sqlserver implement (for go client only, not for dtm server)
type sqlserverDBSpecial struct{}
func (*sqlserverDBSpecial) GetPlaceHoldSQL(sql string) string {
// TODO sqlserver implement
return sql
}
func (*sqlserverDBSpecial) GetInsertIgnoreTemplate(tableAndValues string, pgConstraint string) string {
// TODO sqlserver implement
return ""
}
func (*sqlserverDBSpecial) GetXaSQL(command string, xid string) string {
// TODO sqlserver implement
return ""
}
func init() {
dbSpecials[DBTypeSQLServer] = &sqlserverDBSpecial{}
}
// GetDBSpecial get DBSpecial for currentDBType
func GetDBSpecial(dbType string) DBSpecial {
if dbType == "" {

4
client/dtmcli/dtmimp/utils.go

@ -207,7 +207,9 @@ func DBExec(dbType string, db DB, sql string, values ...interface{}) (affected i
return 0, nil
}
began := time.Now()
sql = GetDBSpecial(dbType).GetPlaceHoldSQL(sql)
if len(values) > 0 {
sql = GetDBSpecial(dbType).GetPlaceHoldSQL(sql)
}
r, rerr := db.Exec(sql, values...)
used := time.Since(began) / time.Millisecond
if rerr == nil {

Loading…
Cancel
Save