Browse Source

Explicit naming for aggregation services

pull/235/head
Galip Tolga Erdem 3 years ago
parent
commit
7ee60cad72
  1. 13
      gateways/web/src/EShopOnAbp.WebGateway/Aggregations/ApplicationConfiguration/AppConfigurationAggregation.cs
  2. 6
      gateways/web/src/EShopOnAbp.WebGateway/Aggregations/ApplicationConfiguration/IAppConfigurationAggregation.cs
  3. 6
      gateways/web/src/EShopOnAbp.WebGateway/Aggregations/Localization/ILocalizationAggregation.cs
  4. 6
      gateways/web/src/EShopOnAbp.WebGateway/Aggregations/Localization/LocalizationAggregation.cs
  5. 12
      gateways/web/src/EShopOnAbp.WebGateway/ReverseProxyBuilderExtensions.cs

13
gateways/web/src/EShopOnAbp.WebGateway/Aggregations/ApplicationConfiguration/AppConfigurationAggregation.cs

@ -8,11 +8,10 @@ using Volo.Abp.DependencyInjection;
namespace EShopOnAbp.WebGateway.Aggregations.ApplicationConfiguration;
public class AppConfigurationAggregation : AggregateServiceBase<ApplicationConfigurationDto>,
IAppConfigurationAggregation,
ITransientDependency
IAppConfigurationAggregation, ITransientDependency
{
public string RouteName => "EshopOnAbpApplicationConfiguration";
public string Endpoint => "api/abp/application-configuration";
public string AppConfigRouteName => "EshopOnAbpApplicationConfiguration";
public string AppConfigEndpoint => "api/abp/application-configuration";
protected AppConfigurationCachedService AppConfigurationCachedService { get; }
@ -25,7 +24,7 @@ public class AppConfigurationAggregation : AggregateServiceBase<ApplicationConfi
AppConfigurationCachedService = appConfigurationCachedService;
}
public async Task<ApplicationConfigurationDto> GetAsync(AppConfigurationRequest input)
public async Task<ApplicationConfigurationDto> GetAppConfigurationAsync(AppConfigurationRequest input)
{
// Check the cache service
var cachedAppConfiguration = AppConfigurationCachedService
@ -90,8 +89,8 @@ public class AppConfigurationAggregation : AggregateServiceBase<ApplicationConfi
var exist = appConfigurations.ContainsKey("Administration_AppConfig");
var dodo = appConfigurations["Administration_AppConfig"];
if(appConfigurations.TryGetValue("Administration_AppConfig", out var administrationServiceData))
if (appConfigurations.TryGetValue("Administration_AppConfig", out var administrationServiceData))
{
return MapServiceData(administrationServiceData);
}

6
gateways/web/src/EShopOnAbp.WebGateway/Aggregations/ApplicationConfiguration/IAppConfigurationAggregation.cs

@ -5,7 +5,7 @@ namespace EShopOnAbp.WebGateway.Aggregations.ApplicationConfiguration;
public interface IAppConfigurationAggregation
{
string RouteName { get; }
string Endpoint { get; }
Task<ApplicationConfigurationDto> GetAsync(AppConfigurationRequest input);
string AppConfigRouteName { get; }
string AppConfigEndpoint { get; }
Task<ApplicationConfigurationDto> GetAppConfigurationAsync(AppConfigurationRequest input);
}

6
gateways/web/src/EShopOnAbp.WebGateway/Aggregations/Localization/ILocalizationAggregation.cs

@ -5,7 +5,7 @@ namespace EShopOnAbp.WebGateway.Aggregations.Localization;
public interface ILocalizationAggregation
{
string RouteName { get; }
string Endpoint { get; }
Task<ApplicationLocalizationDto> GetAsync(LocalizationRequest input);
string LocalizationRouteName { get; }
string LocalizationEndpoint { get; }
Task<ApplicationLocalizationDto> GetLocalizationAsync(LocalizationRequest input);
}

6
gateways/web/src/EShopOnAbp.WebGateway/Aggregations/Localization/LocalizationAggregation.cs

@ -10,8 +10,8 @@ namespace EShopOnAbp.WebGateway.Aggregations.Localization;
public class LocalizationAggregation : AggregateServiceBase<ApplicationLocalizationDto>, ILocalizationAggregation,
ITransientDependency
{
public string RouteName => "EshopOnAbpLocalization";
public string Endpoint => "api/abp/application-localization";
public string LocalizationRouteName => "EshopOnAbpLocalization";
public string LocalizationEndpoint => "api/abp/application-localization";
protected LocalizationCachedService LocalizationCachedService { get; }
public LocalizationAggregation(
@ -22,7 +22,7 @@ public class LocalizationAggregation : AggregateServiceBase<ApplicationLocalizat
LocalizationCachedService = localizationCachedService;
}
public async Task<ApplicationLocalizationDto> GetAsync(LocalizationRequest input)
public async Task<ApplicationLocalizationDto> GetLocalizationAsync(LocalizationRequest input)
{
// Check the cache service
var cachedLocalization = LocalizationCachedService

12
gateways/web/src/EShopOnAbp.WebGateway/ReverseProxyBuilderExtensions.cs

@ -32,12 +32,12 @@ public static class ReverseProxyBuilderExtensions
.GetRequiredService<ILocalizationAggregation>();
// The "/api/abp/application-localization" endpoint
if (localizationAggregation.RouteName == endpoint?.DisplayName)
if (localizationAggregation.LocalizationRouteName == endpoint?.DisplayName)
{
var localizationRequestInput =
CreateLocalizationRequestInput(context, localizationAggregation.Endpoint);
CreateLocalizationRequestInput(context, localizationAggregation.LocalizationEndpoint);
var result = await localizationAggregation.GetAsync(localizationRequestInput);
var result = await localizationAggregation.GetLocalizationAsync(localizationRequestInput);
await context.Response.WriteAsync(JsonSerializer.Serialize(result, JsonSerializerOptions));
return;
}
@ -46,12 +46,12 @@ public static class ReverseProxyBuilderExtensions
.GetRequiredService<IAppConfigurationAggregation>();
// The "/api/abp/application-configuration" endpoint
if (appConfigurationAggregation.RouteName == endpoint?.DisplayName)
if (appConfigurationAggregation.AppConfigRouteName == endpoint?.DisplayName)
{
var appConfigurationRequestInput =
CreateAppConfigurationRequestInput(context, appConfigurationAggregation.Endpoint);
CreateAppConfigurationRequestInput(context, appConfigurationAggregation.AppConfigEndpoint);
var result = await appConfigurationAggregation.GetAsync(appConfigurationRequestInput);
var result = await appConfigurationAggregation.GetAppConfigurationAsync(appConfigurationRequestInput);
await context.Response.WriteAsync(JsonSerializer.Serialize(result, JsonSerializerOptions));
return;
}

Loading…
Cancel
Save