From f2234ab1f4aa9760f0430a9e8359632043fe5edf Mon Sep 17 00:00:00 2001 From: Rottohawkins Date: Thu, 28 Feb 2019 06:08:06 +0100 Subject: [PATCH 1/2] Fixed typo in selector manager documentation --- docs/api/selector_manager.md | 3 +-- src/selector_manager/index.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/api/selector_manager.md b/docs/api/selector_manager.md index aa7eff08d..2f0996f46 100644 --- a/docs/api/selector_manager.md +++ b/docs/api/selector_manager.md @@ -105,8 +105,7 @@ Get the selector by its name ### Parameters - `name` **([String][8] \| [Array][9])** Selector name -- `type` -- `tyoe` **[String][8]** Selector type +- `type` **[String][8]** Selector type ### Examples diff --git a/src/selector_manager/index.js b/src/selector_manager/index.js index 0385e4352..fdc29ec08 100644 --- a/src/selector_manager/index.js +++ b/src/selector_manager/index.js @@ -210,7 +210,7 @@ module.exports = config => { /** * Get the selector by its name * @param {String|Array} name Selector name - * @param {String} tyoe Selector type + * @param {String} type Selector type * @return {Model|Array} * @example * const selector = selectorManager.get('selectorName'); From de48a29e3911a19b9f75f2b61f20e03b649363fe Mon Sep 17 00:00:00 2001 From: Web&Solutions Date: Tue, 5 Mar 2019 10:30:00 +0100 Subject: [PATCH 2/2] Check protected attribute before remove a tag --- src/selector_manager/view/ClassTagView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/selector_manager/view/ClassTagView.js b/src/selector_manager/view/ClassTagView.js index 589af2c91..c29b10658 100644 --- a/src/selector_manager/view/ClassTagView.js +++ b/src/selector_manager/view/ClassTagView.js @@ -96,7 +96,8 @@ module.exports = require('backbone').View.extend({ const { em, model } = this; const sel = em && em.getSelected(); // Prevent weird erros on remove - sel && setTimeout(() => sel.getSelectors().remove(model)); + if (!model.get('protected')) + sel && setTimeout(() => sel.getSelectors().remove(model)); }, /**