From e5ae5e660757a08fd40dbdf2830ecc0d23239a24 Mon Sep 17 00:00:00 2001 From: janczer Date: Sat, 22 Sep 2018 13:27:26 +0200 Subject: [PATCH 1/2] Fix typos --- src/canvas/view/CanvasView.js | 2 +- src/commands/view/CreateComponent.js | 2 +- src/dom_components/model/Component.js | 2 +- src/selector_manager/view/ClassTagsView.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/canvas/view/CanvasView.js b/src/canvas/view/CanvasView.js index 96c6e88dd..7ade2b587 100644 --- a/src/canvas/view/CanvasView.js +++ b/src/canvas/view/CanvasView.js @@ -312,7 +312,7 @@ module.exports = Backbone.View.extend({ view.el.id = id; view.scriptContainer.html(''); // In editor, I make use of setTimeout as during the append process of elements - // those will not be available immediatly, therefore 'item' variable + // those will not be available immediately, therefore 'item' variable const script = document.createElement('script'); script.innerHTML = ` setTimeout(function() { diff --git a/src/commands/view/CreateComponent.js b/src/commands/view/CreateComponent.js index 9778369d3..09b3267ed 100644 --- a/src/commands/view/CreateComponent.js +++ b/src/commands/view/CreateComponent.js @@ -12,7 +12,7 @@ module.exports = _.extend({}, SelectPosition, { }, /** - * Start with enabling to select position and listening to start drawning + * Start with enabling to select position and listening to start drawing * @private * */ enable(...args) { diff --git a/src/dom_components/model/Component.js b/src/dom_components/model/Component.js index a0eb91cee..79c82cfe3 100644 --- a/src/dom_components/model/Component.js +++ b/src/dom_components/model/Component.js @@ -31,7 +31,7 @@ const avoidInline = em => em && em.getConfig('avoidInlineStyle'); /** * The Component object represents a single node of our template structure, so when you update its properties the changes are - * immediatly reflected on the canvas and in the code to export (indeed, when you ask to export the code we just go through all + * immediately reflected on the canvas and in the code to export (indeed, when you ask to export the code we just go through all * the tree of nodes). * An example on how to update properties: * ```js diff --git a/src/selector_manager/view/ClassTagsView.js b/src/selector_manager/view/ClassTagsView.js index 0f014fcfd..41cd89ed7 100644 --- a/src/selector_manager/view/ClassTagsView.js +++ b/src/selector_manager/view/ClassTagsView.js @@ -163,7 +163,7 @@ module.exports = Backbone.View.extend({ }, /** - * Udpate selector helper + * Update selector helper * @return {this} * @private */ From bb3e371a2dd544d2504bb39c21f95f33521d0c42 Mon Sep 17 00:00:00 2001 From: Daniel Ruf Date: Sat, 22 Sep 2018 20:11:10 +0200 Subject: [PATCH 2/2] tests: test Node.js 8 and 10 --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 0d2819ba5..437ee5d93 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,3 +1,4 @@ language: node_js node_js: - - "7.6" + - "8" + - "10"