Browse Source

Fix regressions in ClassTagView

pull/663/head
Artur Arseniev 8 years ago
parent
commit
1fc13c6498
  1. 4
      src/selector_manager/view/ClassTagView.js
  2. 10
      test/specs/selector_manager/view/ClassTagView.js
  3. 2
      test/specs/selector_manager/view/ClassTagsView.js

4
src/selector_manager/view/ClassTagView.js

@ -16,6 +16,7 @@ module.exports = require('backbone').View.extend({
`;
},
events: {
'click [data-tag-remove]': 'removeTag',
'click [data-tag-status]': 'changeStatus',
@ -23,6 +24,7 @@ module.exports = require('backbone').View.extend({
'focusout [data-tag-name]': 'endEditTag',
},
initialize(o) {
this.config = o.config || {};
this.coll = o.coll || null;
@ -80,6 +82,7 @@ module.exports = require('backbone').View.extend({
}
},
/**
* Update status of the tag
* @private
@ -107,6 +110,7 @@ module.exports = require('backbone').View.extend({
em && em.trigger('targetClassRemoved');
},
/**
* Update status of the checkbox
* @private

10
test/specs/selector_manager/view/ClassTagView.js

@ -95,22 +95,18 @@ module.exports = {
});
it('Label input is disabled', () => {
var inputProp = obj.inputProp;
var label = obj.$labelInput.get(0);
expect(obj.$labelInput.prop(inputProp)).toEqual(true);
expect(obj.getInputEl().contentEditable).toNotEqual(true);
});
it('On double click label input is enable', () => {
var inputProp = obj.inputProp;
obj.$el.find('#tag-label').trigger('dblclick');
expect(obj.$labelInput.prop(inputProp)).toEqual(false);
expect(obj.getInputEl().contentEditable).toEqual(true);
});
it('On blur label input turns back disabled', () => {
var inputProp = obj.inputProp;
obj.$el.find('#tag-label').trigger('dblclick');
obj.endEditTag();
expect(obj.$labelInput.prop(inputProp)).toEqual(true);
expect(obj.getInputEl().contentEditable).toEqual(false);
});
});

2
test/specs/selector_manager/view/ClassTagsView.js

@ -132,7 +132,7 @@ module.exports = {
it("New tag correctly added", function() {
coll.add({ label: 'test' });
expect(this.$tags.children().first().find('#tag-label input').val()).toEqual('test');
expect(this.$tags.children().first().find('[data-tag-name]').text()).toEqual('test');
});
it("States are hidden in case no tags", function() {

Loading…
Cancel
Save