From 2fcb4f403763f78c2981379b49840540f042b283 Mon Sep 17 00:00:00 2001 From: Artur Arseniev Date: Tue, 11 Jul 2017 21:58:17 +0200 Subject: [PATCH] Update script rendering in canvas and in export --- src/canvas/view/CanvasView.js | 9 +++------ src/code_manager/model/JsGenerator.js | 5 +++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/canvas/view/CanvasView.js b/src/canvas/view/CanvasView.js index 119c72025..3f4739976 100644 --- a/src/canvas/view/CanvasView.js +++ b/src/canvas/view/CanvasView.js @@ -244,11 +244,8 @@ module.exports = Backbone.View.extend({ this.getJsContainer().append(view.scriptContainer.get(0)); } - var id = view.model.cid; - var script = view.model.get('script'); - var scrStr = 'function(){' + script + '}'; - scrStr = typeof script == 'function' ? script.toString() : scrStr; - + var model = view.model; + var id = model.cid; view.el.id = id; view.scriptContainer.html(''); @@ -258,7 +255,7 @@ module.exports = Backbone.View.extend({ setTimeout(function() { var item = document.getElementById('${id}'); if (!item) return; - (${scrStr}.bind(item))() + (function(){${model.getScriptString()}}.bind(item))() }, 1); `); }, diff --git a/src/code_manager/model/JsGenerator.js b/src/code_manager/model/JsGenerator.js index e6dc20440..465396f69 100644 --- a/src/code_manager/model/JsGenerator.js +++ b/src/code_manager/model/JsGenerator.js @@ -15,8 +15,9 @@ module.exports = Backbone.Model.extend({ attr = _.extend({}, attr, {id}); model.set('attributes', attr); - var scrStr = 'function(){' + script + '}'; - scrStr = typeof script == 'function' ? script.toString() : scrStr; + //var scrStr = 'function(){' + script + '}'; + //scrStr = typeof script == 'function' ? script.toString() : scrStr; + var scrStr = model.getScriptString(); // If the script was updated, I'll put its code in a separate container if (model.get('scriptUpdated')) {