From 32547184b83724c207ebf929c542a2e0e85b0836 Mon Sep 17 00:00:00 2001 From: Artur Arseniev Date: Fri, 11 Feb 2022 10:30:21 +0100 Subject: [PATCH] Trigger `component:mount` once the DOM is appended to the parent. Closes #4136 --- src/dom_components/view/ComponentView.js | 5 +---- src/dom_components/view/ComponentsView.js | 11 +++++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/dom_components/view/ComponentView.js b/src/dom_components/view/ComponentView.js index 3dc5aeb56..340d449a4 100644 --- a/src/dom_components/view/ComponentView.js +++ b/src/dom_components/view/ComponentView.js @@ -503,11 +503,8 @@ export default Backbone.View.extend({ }, postRender() { - const { em, model, modelOpt } = this; - - if (!modelOpt.temporary) { + if (!this.modelOpt.temporary) { this.onRender(this._clbObj()); - em && em.trigger('component:mount', model); } }, diff --git a/src/dom_components/view/ComponentsView.js b/src/dom_components/view/ComponentsView.js index 8890340e2..8611b0fa5 100644 --- a/src/dom_components/view/ComponentsView.js +++ b/src/dom_components/view/ComponentsView.js @@ -61,8 +61,7 @@ export default Backbone.View.extend({ const fragment = fragmentEl || null; const { frameView = {} } = config; const sameFrameView = frameView.model && model.getView(frameView.model); - const dt = - opts.componentTypes || (em && em.get('DomComponents').getTypes()); + const dt = opts.componentTypes || (em && em.get('DomComponents').getTypes()); const type = model.get('type') || 'default'; let viewObject = this.compView; @@ -77,7 +76,7 @@ export default Backbone.View.extend({ new viewObject({ model, config, - componentTypes: dt + componentTypes: dt, }); let rendered; @@ -115,6 +114,10 @@ export default Backbone.View.extend({ } } + if (!model.opt.temporary) { + em?.trigger('component:mount', model); + } + return rendered; }, @@ -132,5 +135,5 @@ export default Backbone.View.extend({ el.innerHTML = ''; el.appendChild(frag); return this; - } + }, });