Fix how the keymap handler is resolved

src/editor/index.js

@@ -172,6 +172,12 @@ module.exports = config => {
      */
     Commands: em.get('Commands'),
 
+    /**
+     * @property {Keymaps}
+     * @private
+     */
+    Keymaps: em.get('Keymaps'),
+
     /**
      * @property {Modal}
      * @private

src/editor/model/Editor.js

@@ -2,6 +2,7 @@ import { isUndefined, defaults } from 'underscore';
 
 const deps = [
   require('utils'),
+  require('keymaps'),
   require('storage_manager'),
   require('device_manager'),
   require('parser'),

src/keymap/index.js → src/keymaps/index.js

@@ -5,9 +5,12 @@ module.exports = () => {
   let config;
   const configDef = {};
   const keymaps = {};
+  console.log('called');
 
   return {
 
+    keymaster,
+
     name: 'Keymaps',
 
 
@@ -48,20 +51,20 @@ module.exports = () => {
     add(id, keys, handler) {
       const em = this.em;
       const cmd = em.get('Commands');
-      const keymap = { keys, handler };
+      const editor = em.getEditor();
+      const keymap = { id, keys, handler };
       const pk = keymaps[id];
       pk && this.remove(id);
       keymaps[id] = keymap;
-      keymaster(keys, id, () => {
+      keymaster(keys, (e, h) => {
+        // It's safer putting handlers resolution inside the callback
         handler = isString(handler) ? cmd.get(handler) : handler;
-        handler(em.getEditor());
+        typeof handler == 'object' ? handler.run(editor) : handler(editor);
-        em.trigger(`keymap:emit`, id, keymap);
+        const args = [id, h.shortcut, e];
-        em.trigger(`keymap:emit:${id}`, keymap);
+        em.trigger('keymap:emit', ...args);
-        console.log('executed', id);
+        em.trigger(`keymap:emit:${id}`, ...args);
       });
-      em.trigger('keymap:add', id, keymap);
+      em.trigger('keymap:add', keymap);
-      // emit
-      //keymaster.unbind(keys, id);
     },
 
 
@@ -101,8 +104,8 @@ module.exports = () => {
 
       if (keymap) {
         delete keymaps[id];
-        keymaster.unbind(keymap.keys, id);
+        keymaster.unbind(keymap.keys);
-        em && em.trigger('keymap:remove', id, keymap);
+        em && em.trigger('keymap:remove', keymap);
         return keymap;
       }
     },