From 44d4d9ee980fb233ab07822a0f676cdbd2099660 Mon Sep 17 00:00:00 2001
From: Carlos <info@itscarlosrufo.com>
Date: Wed, 19 Mar 2025 20:53:38 -0700
Subject: [PATCH] feat: add default options for command execution and simplify
 ComponentDrag styles handling

---
 packages/core/src/commands/config/config.ts   | 40 ++++++++++++++++-
 packages/core/src/commands/index.ts           |  4 ++
 .../core/src/commands/view/ComponentDrag.ts   | 45 ++++---------------
 3 files changed, 51 insertions(+), 38 deletions(-)

diff --git a/packages/core/src/commands/config/config.ts b/packages/core/src/commands/config/config.ts
index 9712308cd..6da455b6c 100644
--- a/packages/core/src/commands/config/config.ts
+++ b/packages/core/src/commands/config/config.ts
@@ -1,4 +1,9 @@
-import { CommandObject } from '../view/CommandAbstract';
+import type { CommandObject, CommandOptions } from '../view/CommandAbstract';
+
+interface CommandConfigDefaultOptions {
+  run: (options: CommandOptions) => CommandOptions;
+  stop: (options: CommandOptions) => CommandOptions;
+}
 
 export interface CommandsConfig {
   /**
@@ -19,12 +24,45 @@ export interface CommandsConfig {
    * @default true
    */
   strict?: boolean;
+
+  /**
+   * Default options for commands
+   * These options will be merged with the options passed when the command is run.
+   * This allows you to define common behavior for commands in one place.
+   * @default {}
+   * @example
+   * defaultOptions: {
+   *  'core:component-drag': {
+   *    run: (options: Record<string, unknown>) => ({
+   *      ...options,
+   *      addStyle: () => {},
+   *     }),
+   *    stop: (options: Record<string, unknown>) => ({
+   *      ...options,
+   *      addStyle: () => {},
+   *    }),
+   *  }
+   * }
+   */
+  defaultOptions?: Record<string, CommandConfigDefaultOptions>;
 }
 
 const config: () => CommandsConfig = () => ({
   stylePrefix: 'com-',
   defaults: {},
   strict: true,
+  defaultOptions: {
+    'core:component-drag': {
+      run: (options: CommandOptions) => ({
+        ...options,
+        addStyle: () => {},
+      }),
+      stop: (options: CommandOptions) => ({
+        ...options,
+        addStyle: () => {},
+      }),
+    },
+  },
 });
 
 export default config;
diff --git a/packages/core/src/commands/index.ts b/packages/core/src/commands/index.ts
index c1cf426c9..a43f88b4f 100644
--- a/packages/core/src/commands/index.ts
+++ b/packages/core/src/commands/index.ts
@@ -389,6 +389,8 @@ export default class CommandsModule extends Module<CommandsConfig & { pStylePref
       const editor = em.Editor;
 
       if (!this.isActive(id) || options.force || !config.strict) {
+        const defaultOptionsRunFn = config.defaultOptions?.[id]?.run;
+        isFunction(defaultOptionsRunFn) && (options = defaultOptionsRunFn(options));
         result = editor && (command as any).callRun(editor, options);
       }
     }
@@ -412,6 +414,8 @@ export default class CommandsModule extends Module<CommandsConfig & { pStylePref
       const editor = em.Editor;
 
       if (this.isActive(id) || options.force || !config.strict) {
+        const defaultOptionsStopFn = config.defaultOptions?.[id]?.stop;
+        isFunction(defaultOptionsStopFn) && (options = defaultOptionsStopFn(options));
         result = (command as any).callStop(editor, options);
       }
     }
diff --git a/packages/core/src/commands/view/ComponentDrag.ts b/packages/core/src/commands/view/ComponentDrag.ts
index 68e7dac31..690b8dcff 100644
--- a/packages/core/src/commands/view/ComponentDrag.ts
+++ b/packages/core/src/commands/view/ComponentDrag.ts
@@ -32,16 +32,7 @@ type Opts = {
   onStart?: (data: any) => Editor;
   onDrag?: (data: any) => Editor;
   onEnd?: (ev: Event, opt: any, data: any) => void;
-  styles?: {
-    guides?: {
-      active?: { color?: string };
-      inactive?: { color?: string };
-    };
-    guidesContainer?: {
-      line?: HTMLElement['style'];
-      content?: HTMLElement['style'];
-    };
-  };
+  addStyle?: () => void;
 };
 
 const evName = 'dmode';
@@ -74,22 +65,7 @@ export default {
       ...dragger,
     };
     this.setupGuides();
-    this.opts = {
-      ...opts,
-      // debug: true
-      styles: {
-        guides: {
-          active: { color: 'green' },
-          inactive: { color: 'red' },
-        },
-        guidesContainer: {
-          line: { 'background-color': 'blue' },
-          content: { color: 'blue' },
-        },
-        ...opts.styles,
-      },
-    };
-    // this.opts = opts;
+    this.opts = opts;
     this.editor = editor;
     this.em = editor.getModel();
     this.target = target;
@@ -142,11 +118,9 @@ export default {
       const pfx = editor.getConfig().stylePrefix;
       const elInfoX = document.createElement('div');
       const elInfoY = document.createElement('div');
-      const guideInfoLineStyles = this.opts?.styles?.guidesContainer?.line;
-      const guideInfoContentStyles = this.opts?.styles?.guidesContainer?.content;
 
-      const guideContent = `<div class="${pfx}guide-info__line ${pfx}danger-bg" ${guideInfoLineStyles ? `style="${styleObjectToString(guideInfoLineStyles)}"` : ''}>
-        <div class="${pfx}guide-info__content ${pfx}danger-color" ${guideInfoContentStyles ? `style="${styleObjectToString(guideInfoContentStyles)}"` : ''}></div>
+      const guideContent = `<div class="${pfx}guide-info__line ${pfx}danger-bg">
+        <div class="${pfx}guide-info__content ${pfx}danger-color"></div>
       </div>`;
       guidesEl = document.createElement('div');
       guidesEl.className = `${pfx}guides`;
@@ -235,14 +209,11 @@ export default {
     const guideSize = item.active ? 2 : 1;
     let numEl = el.children[0];
 
-    const colorActive = this.opts?.styles?.guides?.active?.color ?? 'green';
-    const colorInactive = this.opts?.styles?.guides?.inactive?.color ?? 'red';
-
-    el.style = `position: absolute; background-color: ${item.active ? colorActive : colorInactive};`;
+    el.style = `position: absolute; background-color: ${item.active ? 'green' : 'red'};`;
 
     if (!el.children.length) {
       numEl = document.createElement('div');
-      numEl.style = `position: absolute; color: ${colorInactive}; padding: 5px; top: 0; left: 0;`;
+      numEl.style = `position: absolute; color: red}; padding: 5px; top: 0; left: 0;`;
       el.appendChild(numEl);
     }
 
@@ -345,7 +316,6 @@ export default {
       transform = this.setTranslate(transform, 'x', left);
       transform = this.setTranslate(transform, 'y', top);
       styleUp = { transform, __p };
-      target.addStyle(styleUp, { avoidStore: !end });
     } else {
       const adds: any = { position, width, height };
       const style: any = { left, top, __p };
@@ -354,9 +324,10 @@ export default {
         if (prop) style[add] = prop;
       });
       styleUp = style;
-      target.addStyle(styleUp, { avoidStore: !end });
     }
 
+    // TODO: check this
+    this.opts?.addStyle?.() ?? target.addStyle(styleUp, { avoidStore: !end });
     em?.Styles.__emitCmpStyleUpdate(styleUp, { components: em.getSelected() });
   },