From 4a4d224197c27f2c8ea9798375a29cfe574c4bad Mon Sep 17 00:00:00 2001
From: Artur Arseniev <artur.catch@hotmail.it>
Date: Fri, 20 Sep 2019 08:37:36 +0200
Subject: [PATCH] Improve tools in component selection

---
 src/commands/view/SelectComponent.js | 71 +++++++++++++---------------
 src/commands/view/ShowOffset.js      |  8 ++--
 2 files changed, 38 insertions(+), 41 deletions(-)

diff --git a/src/commands/view/SelectComponent.js b/src/commands/view/SelectComponent.js
index ab90d9f13..5cd0a63e2 100644
--- a/src/commands/view/SelectComponent.js
+++ b/src/commands/view/SelectComponent.js
@@ -108,7 +108,7 @@ export default {
     if (el) {
       const pos = this.getElementPos(el);
       result = { el, pos, component, view: getViewEl(el) };
-      this.updateToolsLocal(el, pos);
+      this.updateToolsLocal();
     }
 
     this.elHovered = result;
@@ -166,9 +166,13 @@ export default {
    */
   onOut(ev) {
     ev && ev.stopPropagation();
-    this.hideBadge();
-    this.hideHighlighter();
-    this.hideElementOffset();
+    this.toggleToolsEl(0, this.getElHovered().view);
+  },
+
+  toggleToolsEl(on, view) {
+    const el = this.canvas.getToolsEl(view);
+    el.style.opacity = on ? 1 : 0;
+    return el;
   },
 
   /**
@@ -177,12 +181,7 @@ export default {
    * @param {Object} pos
    */
   showElementOffset(el, pos, opts = {}) {
-    var $el = $(el);
-    var model = $el.data('model');
-
-    if ((model && model.get('status') == 'selected') || !showOffsets) {
-      return;
-    }
+    if (!showOffsets) return;
 
     this.editor.runCommand('show-offset', {
       el,
@@ -199,9 +198,10 @@ export default {
    * @param {HTMLElement}  el
    * @param {Object} pos
    */
-  hideElementOffset(el, pos) {
-    const { editor } = this;
-    editor && editor.stopCommand('show-offset');
+  hideElementOffset(view) {
+    this.editor.stopCommand('show-offset', {
+      view
+    });
   },
 
   /**
@@ -229,8 +229,8 @@ export default {
   /**
    * Hide Highlighter element
    */
-  hideHighlighter() {
-    this.canvas.getHighlighter().style.display = 'none';
+  hideHighlighter(view) {
+    this.canvas.getHighlighter(view).style.opacity = 0;
   },
 
   /**
@@ -375,23 +375,11 @@ export default {
    * @private
    */
   updateHighlighter(el, pos, opts = {}) {
-    var $el = $(el);
-    var model = $el.data('model');
-
-    if (
-      !model ||
-      !model.get('hoverable') ||
-      model.get('status') == 'selected'
-    ) {
-      return;
-    }
-
-    var hlEl = this.canvas.getHighlighter(opts.view);
-    var hlStyle = hlEl.style;
-    var unit = 'px';
-    hlStyle.height = pos.height + unit;
-    hlStyle.width = pos.width + unit;
-    hlStyle.display = 'block';
+    const { style } = this.canvas.getHighlighter(opts.view);
+    const unit = 'px';
+    style.height = pos.height + unit;
+    style.width = pos.width + unit;
+    style.opacity = '';
   },
 
   /**
@@ -649,30 +637,40 @@ export default {
     this.updateToolsGlobal();
   },
 
+  isCompSelected(comp) {
+    return comp && comp.get('status') === 'selected';
+  },
+
   /**
    * Update tools visible on hover
    * @param {HTMLElement} el
    * @param {Object} pos
    */
   updateToolsLocal() {
-    const { el, pos, view } = this.getElHovered();
+    const { el, pos, view, component } = this.getElHovered();
 
     if (!el) {
       this.lastHovered = 0;
       return;
     }
 
+    const isHoverEn = component.get('hoverable');
     const isNewEl = this.lastHovered !== el;
     const badgeOpts = isNewEl ? {} : { posOnly: 1 };
 
-    if (isNewEl) {
+    if (isNewEl && isHoverEn) {
       this.lastHovered = el;
       this.updateHighlighter(el, pos, { view });
       this.showElementOffset(el, pos, { view });
     }
 
+    if (this.isCompSelected(component)) {
+      this.hideHighlighter(view);
+      this.hideElementOffset(view);
+    }
+
     const unit = 'px';
-    const { style } = this.canvas.getToolsEl(view);
+    const { style } = this.toggleToolsEl(1, view);
     const topOff = this.frameRect(el, 1, pos);
     const leftOff = this.frameRect(el, 0, pos);
 
@@ -696,9 +694,8 @@ export default {
     }
 
     const isNewEl = this.lastSelected !== el;
-    console.log('updateToolsGlobal', el);
+
     if (isNewEl) {
-      console.log('updateToolsGlobal UPDATE toolbar position');
       this.lastSelected = el;
       this.updateToolbar(component);
       this.updateToolbarPos(el, pos);
diff --git a/src/commands/view/ShowOffset.js b/src/commands/view/ShowOffset.js
index 24ae0cc9f..44c01c847 100644
--- a/src/commands/view/ShowOffset.js
+++ b/src/commands/view/ShowOffset.js
@@ -40,7 +40,7 @@ export default {
     var stateVar = state + 'State';
     var method = this.getOffsetMethod(state);
     var offsetViewer = canvas[method](opts.view);
-    offsetViewer.style.display = 'block';
+    offsetViewer.style.opacity = '';
 
     var marginT = this['marginT' + state];
     var marginB = this['marginB' + state];
@@ -157,12 +157,12 @@ export default {
     prStyle.left = pos.left + pos.width - padRight + unit;
   },
 
-  stop(editor, sender, opts) {
+  stop(editor, sender, opts = {}) {
     var opt = opts || {};
     var state = opt.state || '';
     var method = this.getOffsetMethod(state);
     var canvas = editor.Canvas;
-    var offsetViewer = canvas[method]();
-    offsetViewer.style.display = 'none';
+    var offsetViewer = canvas[method](opts.view);
+    offsetViewer.style.opacity = 0;
   }
 };