From c5df3786914f8f7207358f7d51f8b14a3bcbf924 Mon Sep 17 00:00:00 2001 From: Andy Bulka Date: Tue, 2 Mar 2021 10:42:37 +1100 Subject: [PATCH 1/2] fix to script saving to be resilient if scripts contain comments --- src/canvas/view/CanvasView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/canvas/view/CanvasView.js b/src/canvas/view/CanvasView.js index 95c5742da..6aa75ec18 100644 --- a/src/canvas/view/CanvasView.js +++ b/src/canvas/view/CanvasView.js @@ -299,7 +299,7 @@ export default Backbone.View.extend({ const scriptFn = model.getScriptString(); const scriptFnStr = model.get('script-props') ? scriptFn - : `function(){${scriptFn};}`; + : `function(){\n${scriptFn}\n;}`; const scriptProps = JSON.stringify(model.__getScriptProps()); script.innerHTML = ` setTimeout(function() { From 0e94c08bbc28a92fd8e488018486c0e83069eb21 Mon Sep 17 00:00:00 2001 From: Andy Bulka Date: Wed, 3 Mar 2021 18:06:22 +1100 Subject: [PATCH 2/2] newline fix for build() needed too --- src/code_manager/model/JsGenerator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/code_manager/model/JsGenerator.js b/src/code_manager/model/JsGenerator.js index 1790becda..07e1fea89 100644 --- a/src/code_manager/model/JsGenerator.js +++ b/src/code_manager/model/JsGenerator.js @@ -69,7 +69,7 @@ export default Backbone.Model.extend({ code += ` var items = document.querySelectorAll('${ids}'); for (var i = 0, len = items.length; i < len; i++) { - (function(){${mapType.code}}.bind(items[i]))(); + (function(){\n${mapType.code}\n}.bind(items[i]))(); }`; } }