From 5b2b60de1dae64fbcd75bc512439d6d24fe669cd Mon Sep 17 00:00:00 2001
From: Artur Arseniev <artur.catch@hotmail.it>
Date: Sat, 2 Mar 2024 09:49:20 +0400
Subject: [PATCH] Up

---
 src/dataSources/index.ts        | 39 ++++++++++++++++++++++++++++-----
 test/specs/dataSources/index.ts | 18 ++++++++++++---
 2 files changed, 48 insertions(+), 9 deletions(-)

diff --git a/src/dataSources/index.ts b/src/dataSources/index.ts
index bd33e73cb..e248c46ea 100644
--- a/src/dataSources/index.ts
+++ b/src/dataSources/index.ts
@@ -16,24 +16,40 @@ export default class DataSourceManager extends ItemManagerModule<ModuleConfig, D
     super(em, 'DataSources', new DataSources([], em), DataSourcesEvents);
   }
 
-  getValue(key: string | string[], defValue: any) {
-    return get(this.getContext(), key, defValue);
-  }
-
+  /**
+   * Add new data source.
+   * @param {Object} props Data source properties.
+   * @returns {[DataSource]} Added data source.
+   * @example
+   * const ds = dsm.add({
+   *  id: 'my_data_source_id',
+   *  records: [
+   *    { id: 'id1', name: 'value1' },
+   *    { id: 'id2', name: 'value2' }
+   *  ]
+   * });
+   */
   add(props: DataSourceProps, opts: AddOptions = {}) {
     const { all } = this;
     props.id = props.id || this._createId();
     return all.add(props, opts);
   }
 
+  /**
+   * Get data source.
+   * @param {String} id Data source id.
+   * @returns {[DataSource]} Data source.
+   * @example
+   * const ds = dsm.get('my_data_source_id');
+   */
   get(id: string) {
     return this.all.get(id);
   }
 
   /**
    * Remove data source.
-   * @param {String|[DataSource]} id Id of the data source
-   * @returns {[DataSource]} Removed data source
+   * @param {String|[DataSource]} id Id of the data source.
+   * @returns {[DataSource]} Removed data source.
    * @example
    * const removed = dsm.remove('DS_ID');
    */
@@ -41,6 +57,17 @@ export default class DataSourceManager extends ItemManagerModule<ModuleConfig, D
     return this.__remove(id, opts);
   }
 
+  /**
+   * Get value from data sources by key
+   * @param {String} key Path to value.
+   * @param {any} defValue
+   * @returns {any}
+   * const value = dsm.getValue('ds_id.record_id.propName', 'defaultValue');
+   */
+  getValue(key: string | string[], defValue: any) {
+    return get(this.getContext(), key, defValue);
+  }
+
   getContext() {
     return this.all.reduce((acc, ds) => {
       acc[ds.id] = ds.records.reduce((accR, dr, i) => {
diff --git a/test/specs/dataSources/index.ts b/test/specs/dataSources/index.ts
index f0f1a6a53..eebe96dbb 100644
--- a/test/specs/dataSources/index.ts
+++ b/test/specs/dataSources/index.ts
@@ -48,9 +48,15 @@ describe('DataSourceManager', () => {
     expect(dsm.get(dsTest.id)).toBe(ds);
   });
 
-  test.todo('remove DataSource');
-  test.todo('update DataSource');
-  test.todo('update DataSource record');
+  test('remove DataSource', () => {
+    const event = jest.fn();
+    em.on(dsm.events.remove, event);
+    const ds = addDataSource();
+    dsm.remove('ds1');
+    expect(dsm.getAll().length).toBe(0);
+    expect(event).toBeCalledTimes(1);
+    expect(event).toBeCalledWith(ds, expect.any(Object));
+  });
 
   describe('DataSource with DataVariable component', () => {
     let fixtures: HTMLElement;
@@ -89,6 +95,12 @@ describe('DataSourceManager', () => {
         const cmpVar = addDataVariable();
         expect(cmpVar.toHTML()).toBe('<div>Name1</div>');
       });
+
+      test('component exports properly with variable', () => {
+        addDataSource();
+        const cmpVar = addDataVariable();
+        expect(cmpVar.getInnerHTML({ keepVariables: true })).toBe('ds1.id1.name');
+      });
     });
 
     test('component is properly initiliazed with default value', () => {