tsai
/
grapesjs
mirror of https://github.com/artf/grapesjs.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Remove useless tests from stack property view

no-jquery
Artur Arseniev 9 years ago
parent
4ef148d4da
commit
6f3302e259
3 changed files with 9 additions and 228 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      test/specs/style_manager/view/PropertyColorView.js
  2. 2
      test/specs/style_manager/view/PropertyIntegerView.js
  3. 231
      test/specs/style_manager/view/PropertyStackView.js

4
test/specs/style_manager/view/PropertyColorView.js
View File

@ -154,8 +154,8 @@ module.exports = {
expect(view.model.get('value')).toEqual(propValue);
});
it('Input value is empty', () => {
expect(view.getInputValue()).toEqual('');
it('Input value is the default', () => {
expect(view.getInputValue()).toEqual(propValue);
});
});

2
test/specs/style_manager/view/PropertyIntegerView.js
View File

@ -184,7 +184,7 @@ module.exports = {
});
it('Input value is as default', () => {
expect(view.getInputValue()).toEqual('');
expect(view.getInputValue()).toEqual(intValue);
expect(view.$unit.val()).toEqual(units[1]);
});

231
test/specs/style_manager/view/PropertyStackView.js
View File

@ -58,10 +58,6 @@ module.exports = {
fixtures.appendChild(view.el);
});
afterEach(() => {
//view.remove(); // strange errors ???
});
after(() => {
component = null;
view = null;
@ -80,20 +76,17 @@ module.exports = {
expect(view.el.querySelector('.layers')).toExist();
});
it('Layers should exist', () => {
expect(view.$props).toExist();
it('Layers wrapper should exist', () => {
expect(view.el.querySelector('[data-layers-wrapper]')).toExist();
});
it('Layers rendered correctly', () => {
var children = view.$props.get(0).children;
expect(children.length).toEqual(properties.length);
expect(children[0].id).toEqual(properties[0].property);
expect(children[1].id).toEqual(properties[1].property);
expect(children[2].id).toEqual(properties[2].property);
var children = view.el.querySelector('[data-layers-wrapper]').children;
expect(children.length).toEqual(1);
});
it('Input value is empty', () => {
expect(view.model.get('value')).toNotExist();
it('Input value is on default', () => {
expect(view.model.get('value')).toEqual('0 val2');
});
it('Layers container is empty', () => {
@ -123,15 +116,6 @@ module.exports = {
expect(view.getLayers().length).toEqual(layers.length);
});
it('Get value on index', () => {
view.model.set('stackIndex', 1);
expect(view.valueOnIndex(1)).toEqual('lval22');
});
it('createValue merges layers', () => {
expect(view.createValue()).toEqual('lval1, lval2 lval22, lval3 lval32 lval33');
});
it('Add layer', () => {
view.addLayer();
expect(view.getLayers().length).toEqual(layers.length + 1);
@ -139,209 +123,6 @@ module.exports = {
});
describe('With target setted', () => {
var prop2Val;
var prop3Val;
var prop2Unit;
var finalResult;
var $prop1;
var $prop2;
var $prop3;
beforeEach(() => {
model = new Property({
type: 'stack',
property: propName,
properties
});
view = new PropertyStackView({
model,
propTarget: target
});
fixtures.innerHTML = '';
view.render();
fixtures.appendChild(view.el);
prop3Val = properties[2].list[2].value;
prop2Val = properties[1].defaults;
prop2Unit = properties[1].units[0];
finalResult = propValue + ' ' + prop2Val + prop2Unit +' ' + prop3Val;
view.addLayer();
$prop1 = view.$props.find('#' + properties[0].property + ' input');
$prop2 = view.$props.find('#' + properties[1].property + ' input');
$prop3 = view.$props.find('#' + properties[2].property + ' select');
});
it('Update model on input change', () => {
$prop1.val(propValue).trigger('change');
$prop3.val(prop3Val).trigger('change');
expect(model.getFullValue()).toEqual(finalResult);
});
it('Update value on models change', () => {
view.model.get('properties').at(0).set('value', propValue);
view.model.get('properties').at(2).set('value', prop3Val);
expect(view.model.get('value')).toEqual(finalResult);
});
it('Update target on value change', () => {
$prop1.val(propValue).trigger('change');
var compStyle = view.getTarget().get('style');
var assertStyle = {};
assertStyle[propName] = propValue + ' 0% val2';
expect(compStyle).toEqual(assertStyle);
});
it('Update value and input on target swap', () => {
var style = {};
var finalResult2 = 'A B C';
style[propName] = finalResult + ', ' + finalResult2;
component.set('style', style);
view.propTarget.trigger('update');
var layers = view.getLayers();
expect(layers.at(0).get('value')).toEqual(finalResult);
expect(layers.at(1).get('value')).toEqual(finalResult2);
});
it('Update value after multiple swaps', () => {
var style = {};
var finalResult2 = 'A2 B2 C2';
style[propName] = finalResult;
component.set('style', style);
view.propTarget.trigger('update');
style[propName] = finalResult + ', ' + finalResult2;
component.set('style', style);
view.propTarget.trigger('update');
var layers = view.getLayers();
expect(layers.at(0).get('value')).toEqual(finalResult);
expect(layers.at(1).get('value')).toEqual(finalResult2);
});
it('The value is correctly extracted from the composite string', () => {
var style = {};
style[propName] = 'value1 value2, value3 value4';
component.set('style', style);
view.propTarget.trigger('update');
view.model.set('stackIndex', 1);
expect(view.valueOnIndex(0)).toEqual('value3');
expect(view.valueOnIndex(1)).toEqual('value4');
expect(view.valueOnIndex(2)).toEqual(null);
});
it('The value is correctly extracted from the string with functions', () => {
var style = {};
style[propName] = 'func(a1a, s2a,d3a) value1 value2, func(4ddb, aAS5b, sS.6b) value3';
component.set('style', style);
view.propTarget.trigger('update');
view.model.set('stackIndex', 1);
expect(view.valueOnIndex(0)).toEqual('func(4ddb,aAS5b,sS.6b)');
expect(view.valueOnIndex(1)).toEqual('value3');
expect(view.valueOnIndex(2)).toEqual(null);
});
it('Build value from properties', () => {
view.model.get('properties').at(0).set('value', propValue);
view.model.get('properties').at(2).set('value', prop3Val);
expect(view.model.getFullValue()).toEqual(finalResult);
});
});
describe('Detached with target setted', () => {
var prop2Val;
var prop3Val;
var prop2Unit;
var finalResult;
var $prop1;
var $prop2;
var $prop3;
var compStyle = {
subprop1: '1px, 20px, 30px',
subprop2: 'A, B, C',
subprop3: 'W, X, Y',
subprop555: 'T, T, T',
};
beforeEach(() => {
model = new Property({
type: 'stack',
property: propName,
properties,
detached: true,
});
view = new PropertyStackView({
model,
propTarget: target
});
fixtures.innerHTML = '';
view.render();
fixtures.appendChild(view.el);
prop3Val = properties[2].list[2].value;
prop2Val = properties[1].defaults;
prop2Unit = properties[1].units[0];
finalResult = propValue + ' ' + prop2Val + prop2Unit +' ' + prop3Val;
view.addLayer();
$prop1 = view.$props.find('#' + properties[0].property + ' input');
$prop2 = view.$props.find('#' + properties[1].property + ' input');
$prop3 = view.$props.find('#' + properties[2].property + ' select');
});
it('Returns correctly layers array from target', () => {
component.set('style', compStyle);
var result = [{
subprop1: '1px',
subprop2: 'A',
subprop3: 'W',
},{
subprop1: '20px',
subprop2: 'B',
subprop3: 'X',
},{
subprop1: '30px',
subprop2: 'C',
subprop3: 'Y',
}];
// replaced with Layers.getLayersFromStyle
expect(view.getLayersFromTarget()).toEqual(result);
});
it('Update target on detached value change', () => {
$prop1.val(propValue).trigger('change');
var compStyle = view.getTarget().get('style');
var assertStyle = {};
assertStyle[properties[0].property] = $prop1.val();
assertStyle[properties[1].property] = '0%';
assertStyle[properties[2].property] = properties[2].defaults;
expect(compStyle).toEqual(assertStyle);
});
it('Update value and input on target swap', () => {
var style = {};
component.set('style', compStyle);
view.propTarget.trigger('update');
var layers = view.getLayers();
expect(layers.length).toEqual(3);
expect(layers.at(0).get('values')).toEqual({
subprop1: '1px',
subprop2: 'A',
subprop3: 'W',
});
expect(layers.at(1).get('values')).toEqual({
subprop1: '20px',
subprop2: 'B',
subprop3: 'X',
});
expect(layers.at(2).get('values')).toEqual({
subprop1: '30px',
subprop2: 'C',
subprop3: 'Y',
});
});
});
});
}
};

Write Preview
Loading…
Cancel
Save