From fb8fd8ce49b60fb5b0bd6ad4637649efa396eb01 Mon Sep 17 00:00:00 2001 From: zhaoxin Date: Sun, 29 Sep 2019 15:36:57 +0800 Subject: [PATCH 1/5] fix poster unchange --- src/trait_manager/model/Trait.js | 5 +++++ src/trait_manager/view/TraitView.js | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/src/trait_manager/model/Trait.js b/src/trait_manager/model/Trait.js index 85368d003..d8a9640a0 100644 --- a/src/trait_manager/model/Trait.js +++ b/src/trait_manager/model/Trait.js @@ -67,6 +67,11 @@ export default Backbone.Model.extend({ if (this.get('changeProp')) { target.set(name, value, opts); + if (name === 'poster') { + const attrs = { ...target.get('attributes') }; + attrs[name] = value; + target.set('attributes', attrs, opts); + } } else { const attrs = { ...target.get('attributes') }; attrs[name] = value; diff --git a/src/trait_manager/view/TraitView.js b/src/trait_manager/view/TraitView.js index 4534a4a1c..62eefd7f7 100644 --- a/src/trait_manager/view/TraitView.js +++ b/src/trait_manager/view/TraitView.js @@ -194,6 +194,10 @@ export default Backbone.View.extend({ if (model.get('changeProp')) { value = target.get(name); + if (name === 'poster') { + const attrs = target.get('attributes'); + value = model.get('value') || attrs[name]; + } } else { const attrs = target.get('attributes'); value = model.get('value') || attrs[name]; From 7a2b465581e6b20876e4767ee2b2ec7868bac7f3 Mon Sep 17 00:00:00 2001 From: zhaoxin Date: Thu, 10 Oct 2019 17:59:39 +0800 Subject: [PATCH 2/5] fix echo poster --- index.html | 6 ++++++ src/dom_components/model/ComponentVideo.js | 4 ++-- src/trait_manager/model/Trait.js | 5 ----- src/trait_manager/view/TraitView.js | 4 ---- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/index.html b/index.html index ff5544915..ceaf84665 100755 --- a/index.html +++ b/index.html @@ -16,6 +16,7 @@
+

Welcome to

@@ -121,6 +122,11 @@ attributes: { class:'gjs-fonts gjs-f-b1' }, content: `
Test block
` }) + editor.BlockManager.add('Video', { + label: 'Video', + attributes: { class:'gjs-fonts gjs-f-b1' }, + content: `