From 7a2b465581e6b20876e4767ee2b2ec7868bac7f3 Mon Sep 17 00:00:00 2001
From: zhaoxin <zhaoxin@9fbank.cc>
Date: Thu, 10 Oct 2019 17:59:39 +0800
Subject: [PATCH] fix echo poster

---
 index.html                                 | 6 ++++++
 src/dom_components/model/ComponentVideo.js | 4 ++--
 src/trait_manager/model/Trait.js           | 5 -----
 src/trait_manager/view/TraitView.js        | 4 ----
 4 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/index.html b/index.html
index ff5544915..ceaf84665 100755
--- a/index.html
+++ b/index.html
@@ -16,6 +16,7 @@
 
   <body>
     <div id="gjs" style="height:0px; overflow:hidden;">
+      <video  src="" poster="https://camo.githubusercontent.com/cf1a042fe34ab268410fdf6050699f20cf0aaef2/68747470733a2f2f796d6d2d6d616c69616e672e6f73732d636e2d68616e677a686f752e616c6979756e63732e636f6d2f796d6d2d6d616c69616e672f6163636573732f796d6d5f313533393538383635353835302e706e67"></video>
       <div class="panel">
         <h1 class="welcome">Welcome to</h1>
         <div class="big-title">
@@ -121,6 +122,11 @@
         attributes: { class:'gjs-fonts gjs-f-b1' },
         content: `<div style="padding-top:50px; padding-bottom:50px; text-align:center">Test block</div>`
       })
+      editor.BlockManager.add('Video', {
+        label: 'Video',
+        attributes: { class:'gjs-fonts gjs-f-b1' },
+        content: `<video  />`
+      })
     </script>
   </body>
 </html>
diff --git a/src/dom_components/model/ComponentVideo.js b/src/dom_components/model/ComponentVideo.js
index 955c2de64..e1c6e42b8 100644
--- a/src/dom_components/model/ComponentVideo.js
+++ b/src/dom_components/model/ComponentVideo.js
@@ -182,8 +182,8 @@ export default Component.extend(
         {
           label: 'Poster',
           name: 'poster',
-          placeholder: 'eg. ./media/image.jpg',
-          changeProp: 1
+          placeholder: 'eg. ./media/image.jpg'
+          // changeProp: 1
         },
         this.getAutoplayTrait(),
         this.getLoopTrait(),
diff --git a/src/trait_manager/model/Trait.js b/src/trait_manager/model/Trait.js
index d8a9640a0..85368d003 100644
--- a/src/trait_manager/model/Trait.js
+++ b/src/trait_manager/model/Trait.js
@@ -67,11 +67,6 @@ export default Backbone.Model.extend({
 
     if (this.get('changeProp')) {
       target.set(name, value, opts);
-      if (name === 'poster') {
-        const attrs = { ...target.get('attributes') };
-        attrs[name] = value;
-        target.set('attributes', attrs, opts);
-      }
     } else {
       const attrs = { ...target.get('attributes') };
       attrs[name] = value;
diff --git a/src/trait_manager/view/TraitView.js b/src/trait_manager/view/TraitView.js
index 62eefd7f7..4534a4a1c 100644
--- a/src/trait_manager/view/TraitView.js
+++ b/src/trait_manager/view/TraitView.js
@@ -194,10 +194,6 @@ export default Backbone.View.extend({
 
     if (model.get('changeProp')) {
       value = target.get(name);
-      if (name === 'poster') {
-        const attrs = target.get('attributes');
-        value = model.get('value') || attrs[name];
-      }
     } else {
       const attrs = target.get('attributes');
       value = model.get('value') || attrs[name];
