Browse Source

Improve remove in StyleManager properties

pull/3147/head
Artur Arseniev 6 years ago
parent
commit
7f7a58a9ac
  1. 11
      src/style_manager/model/Sectors.js
  2. 5
      src/style_manager/view/PropertyColorView.js
  3. 6
      src/style_manager/view/PropertyCompositeView.js
  4. 3
      src/style_manager/view/PropertyView.js

11
src/style_manager/model/Sectors.js

@ -2,5 +2,14 @@ import Backbone from 'backbone';
import Sector from './Sector'; import Sector from './Sector';
export default Backbone.Collection.extend({ export default Backbone.Collection.extend({
model: Sector model: Sector,
initialize() {
this.listenTo(this, 'reset', this.onReset);
},
onReset(models, opts = {}) {
const prev = opts.previousModels || [];
prev.forEach(sect => sect.get('properties').reset());
}
}); });

5
src/style_manager/view/PropertyColorView.js

@ -7,6 +7,11 @@ export default PropertyIntegerView.extend({
this.inputInst.setValue(value, opts); this.inputInst.setValue(value, opts);
}, },
remove() {
PropertyIntegerView.prototype.remove.apply(this, arguments);
['inputInst', '$color'].forEach(i => (this[i] = {}));
},
onRender() { onRender() {
if (!this.input) { if (!this.input) {
const ppfx = this.ppfx; const ppfx = this.ppfx;

6
src/style_manager/view/PropertyCompositeView.js

@ -27,6 +27,12 @@ export default PropertyView.extend({
PropertyView.prototype.clear.apply(this, arguments); PropertyView.prototype.clear.apply(this, arguments);
}, },
remove() {
this.model.get('properties').reset();
PropertyView.prototype.remove.apply(this, arguments);
['properties', 'props', '$props'].forEach(i => (this[i] = {}));
},
/** /**
* Renders input * Renders input
* */ * */

3
src/style_manager/view/PropertyView.js

@ -95,6 +95,9 @@ export default Backbone.View.extend({
remove() { remove() {
Backbone.View.prototype.remove.apply(this, arguments); Backbone.View.prototype.remove.apply(this, arguments);
['em', 'target', 'input', '$input', 'propTarget', 'sector'].forEach(
i => (this[i] = {})
);
this.__destroyFn(this._getClbOpts()); this.__destroyFn(this._getClbOpts());
}, },

Loading…
Cancel
Save