From f006e503d220c1ca4cde11d4474630923fd08813 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 7 Aug 2020 23:30:16 +0000 Subject: [PATCH 1/3] Bump prismjs from 1.20.0 to 1.21.0 Bumps [prismjs](https://github.com/PrismJS/prism) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](https://github.com/PrismJS/prism/compare/v1.20.0...v1.21.0) Signed-off-by: dependabot[bot] --- package-lock.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9757cd51e..7ab07ce32 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14052,9 +14052,9 @@ "dev": true }, "prismjs": { - "version": "1.20.0", - "resolved": "https://registry.npmjs.org/prismjs/-/prismjs-1.20.0.tgz", - "integrity": "sha512-AEDjSrVNkynnw6A+B1DsFkd6AVdTnp+/WoUixFRULlCLZVRZlVQMVWio/16jv7G1FscUxQxOQhWwApgbnxr6kQ==", + "version": "1.21.0", + "resolved": "https://registry.npmjs.org/prismjs/-/prismjs-1.21.0.tgz", + "integrity": "sha512-uGdSIu1nk3kej2iZsLyDoJ7e9bnPzIgY0naW/HdknGj61zScaprVEVGHrPoXqI+M9sP0NDnTK2jpkvmldpuqDw==", "dev": true, "requires": { "clipboard": "^2.0.0" From 07345c50c1c31e66c462052259feaffae4f3b524 Mon Sep 17 00:00:00 2001 From: Nikesh-hub <69974202+Nikesh-hub@users.noreply.github.com> Date: Mon, 24 Aug 2020 10:43:18 +0530 Subject: [PATCH 2/3] Update Traits.md --- docs/modules/Traits.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/modules/Traits.md b/docs/modules/Traits.md index 4ff92cbbb..9d9c475e4 100644 --- a/docs/modules/Traits.md +++ b/docs/modules/Traits.md @@ -299,7 +299,7 @@ editor.TraitManager.addType('href-next', { createInput({ trait }) { // Here we can decide to use properties from the trait const traitOpts = trait.get('options') || []; - const options = traitOpts.lenght ? traitOpts : [ + const options = traitOpts.length ? traitOpts : [ { id: 'url', name: 'URL' }, { id: 'email', name: 'Email' }, ]; From 2cb13fa8fa1787480ec1d743e8c2aa24b20e036e Mon Sep 17 00:00:00 2001 From: meyerc Date: Wed, 26 Aug 2020 13:45:29 +0300 Subject: [PATCH 3/3] handle case when url is not a base64 format . add quotes arround url() method parameter . --- src/style_manager/model/Property.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/style_manager/model/Property.js b/src/style_manager/model/Property.js index ccbd84fa2..5f89a7828 100644 --- a/src/style_manager/model/Property.js +++ b/src/style_manager/model/Property.js @@ -201,7 +201,8 @@ const Property = Backbone.Model.extend( } if (fn && hasValue) { - value = `${fn}(${value})`; + const fnParameter = fn === 'url' ? `'${value}'` : value; + value = `${fn}(${fnParameter})`; } if (hasValue && this.get('important')) {