From e6efd63ceecc98a4e08a772321ca191ad297ec18 Mon Sep 17 00:00:00 2001 From: Ryan Deba Date: Fri, 24 Nov 2017 11:40:26 -0600 Subject: [PATCH 1/2] render text view after disabling editing this is to fix a bug where text content can appear to be duplicated after adding text content to a component that originally had no content --- src/dom_components/view/ComponentTextView.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dom_components/view/ComponentTextView.js b/src/dom_components/view/ComponentTextView.js index cd88a26e0..ccfb35a45 100644 --- a/src/dom_components/view/ComponentTextView.js +++ b/src/dom_components/view/ComponentTextView.js @@ -91,6 +91,7 @@ module.exports = ComponentView.extend({ this.rteEnabled = 0; this.toggleEvents(); + this.render(); }, /** From 88b992ed6fa40d3c88002f0ce122aea0ce5c60fc Mon Sep 17 00:00:00 2001 From: Ryan Deba Date: Tue, 28 Nov 2017 18:42:12 -0600 Subject: [PATCH 2/2] trigger change event instead of calling render() --- src/dom_components/view/ComponentTextView.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dom_components/view/ComponentTextView.js b/src/dom_components/view/ComponentTextView.js index ccfb35a45..d1118b1f1 100644 --- a/src/dom_components/view/ComponentTextView.js +++ b/src/dom_components/view/ComponentTextView.js @@ -82,7 +82,7 @@ module.exports = ComponentView.extend({ } // Avoid re-render on reset with silent option - model.set('content', ''); + model.set('content', '').trigger('change:content', model); comps.add(content); comps.each(model => clean(model)); comps.trigger('resetNavigator'); @@ -91,7 +91,6 @@ module.exports = ComponentView.extend({ this.rteEnabled = 0; this.toggleEvents(); - this.render(); }, /**