From 9a05a4b9a08919bee58d23a71c65b7d457c26bb7 Mon Sep 17 00:00:00 2001 From: mohamedsalem401 Date: Thu, 20 Feb 2025 18:37:11 +0200 Subject: [PATCH] Remove expecting errors for conditions tests --- .../ComponentConditionalVariable.ts | 20 +---------------- .../ConditionalStyles.ts | 22 +------------------ 2 files changed, 2 insertions(+), 40 deletions(-) diff --git a/packages/core/test/specs/data_sources/model/conditional_variables/ComponentConditionalVariable.ts b/packages/core/test/specs/data_sources/model/conditional_variables/ComponentConditionalVariable.ts index 95710a7ac..0909eaf7d 100644 --- a/packages/core/test/specs/data_sources/model/conditional_variables/ComponentConditionalVariable.ts +++ b/packages/core/test/specs/data_sources/model/conditional_variables/ComponentConditionalVariable.ts @@ -1,9 +1,6 @@ import { Component, DataSourceManager, Editor } from '../../../../../src'; import { DataVariableType } from '../../../../../src/data_sources/model/DataVariable'; -import { - MissingConditionError, - DataConditionType, -} from '../../../../../src/data_sources/model/conditional_variables/DataCondition'; +import { DataConditionType } from '../../../../../src/data_sources/model/conditional_variables/DataCondition'; import { GenericOperation } from '../../../../../src/data_sources/model/conditional_variables/operators/GenericOperator'; import { NumberOperation } from '../../../../../src/data_sources/model/conditional_variables/operators/NumberOperator'; import ComponentDataConditionView from '../../../../../src/data_sources/view/ComponentDataConditionView'; @@ -213,21 +210,6 @@ describe('ComponentConditionalVariable', () => { const storageCmptDef = frame.component.components[0]; expect(storageCmptDef).toEqual(conditionalCmptDef); }); - - it('should throw an error if no condition is passed', () => { - const conditionalCmptDef = { - type: DataConditionType, - ifTrue: { - tagName: 'h1', - type: 'text', - content: 'some text', - }, - }; - - expect(() => { - cmpRoot.append(conditionalCmptDef); - }).toThrow(MissingConditionError); - }); }); function updatedsmLeftValue(dsm: DataSourceManager, newValue: string) { diff --git a/packages/core/test/specs/data_sources/model/conditional_variables/ConditionalStyles.ts b/packages/core/test/specs/data_sources/model/conditional_variables/ConditionalStyles.ts index 5f7d4af0f..781514659 100644 --- a/packages/core/test/specs/data_sources/model/conditional_variables/ConditionalStyles.ts +++ b/packages/core/test/specs/data_sources/model/conditional_variables/ConditionalStyles.ts @@ -1,9 +1,6 @@ import { DataSourceManager, Editor } from '../../../../../src'; import { DataVariableType } from '../../../../../src/data_sources/model/DataVariable'; -import { - DataConditionType, - MissingConditionError, -} from '../../../../../src/data_sources/model/conditional_variables/DataCondition'; +import { DataConditionType } from '../../../../../src/data_sources/model/conditional_variables/DataCondition'; import { GenericOperation } from '../../../../../src/data_sources/model/conditional_variables/operators/GenericOperator'; import { NumberOperation } from '../../../../../src/data_sources/model/conditional_variables/operators/NumberOperator'; import ComponentWrapper from '../../../../../src/dom_components/model/ComponentWrapper'; @@ -87,23 +84,6 @@ describe('StyleConditionalVariable', () => { expect(component.getStyle().color).toBe('green'); }); - it('should throw an error if no condition is passed in style', () => { - expect(() => { - cmpRoot.append({ - tagName: 'h1', - type: 'text', - content: 'some text', - style: { - color: { - type: DataConditionType, - ifTrue: 'grey', - ifFalse: 'red', - }, - }, - }); - }).toThrow(MissingConditionError); - }); - it.skip('should store components with conditional styles correctly', () => { const conditionalStyleDef = { tagName: 'h1',