From 9d018ab61553c3182d2a796b59484528922f2ad5 Mon Sep 17 00:00:00 2001
From: Carlos <info@itscarlosrufo.com>
Date: Sun, 23 Mar 2025 21:27:11 -0700
Subject: [PATCH] feat: add run and stop command tests

---
 packages/core/src/commands/config/config.ts   |  3 --
 packages/core/src/commands/index.ts           |  1 -
 .../core/src/commands/view/ComponentDrag.ts   |  4 +-
 packages/core/test/specs/commands/index.ts    | 47 +++++++++++++++++++
 4 files changed, 48 insertions(+), 7 deletions(-)

diff --git a/packages/core/src/commands/config/config.ts b/packages/core/src/commands/config/config.ts
index 4daab89b0..321588c0a 100644
--- a/packages/core/src/commands/config/config.ts
+++ b/packages/core/src/commands/config/config.ts
@@ -61,9 +61,6 @@ const config: () => CommandsConfig = () => ({
     'core:component-drag': {
       run: (options: CommandOptions) => ({
         ...options,
-        customElements: {
-          guideIndicator: false,
-        },
         // addStyle: ({ componentView, matchedEl }) => {
         //   // TODO: test if you can conver to percentage
         //   // componentView.setStyle({ opacity: 0.5 });
diff --git a/packages/core/src/commands/index.ts b/packages/core/src/commands/index.ts
index eba5f1740..a43f88b4f 100644
--- a/packages/core/src/commands/index.ts
+++ b/packages/core/src/commands/index.ts
@@ -388,7 +388,6 @@ export default class CommandsModule extends Module<CommandsConfig & { pStylePref
       const id = command.id as string;
       const editor = em.Editor;
 
-      // TODO: add test
       if (!this.isActive(id) || options.force || !config.strict) {
         const defaultOptionsRunFn = config.defaultOptions?.[id]?.run;
         isFunction(defaultOptionsRunFn) && (options = defaultOptionsRunFn(options));
diff --git a/packages/core/src/commands/view/ComponentDrag.ts b/packages/core/src/commands/view/ComponentDrag.ts
index 4b1414e57..1546818e1 100644
--- a/packages/core/src/commands/view/ComponentDrag.ts
+++ b/packages/core/src/commands/view/ComponentDrag.ts
@@ -502,9 +502,7 @@ export default {
         guideInfoStyle[isY ? 'top' : 'left'] = pos2;
         guideInfoStyle[isY ? 'left' : 'top'] = `${posSecond}px`;
         guideInfoStyle[isY ? 'width' : 'height'] = `${size}px`;
-        // TODO: this is the way to display the percentage?
-        const showPercentages = this.opts?.addStyle?.()?.showPercentages;
-        elGuideInfoCnt.innerHTML = showPercentages ? `${Math.round(sizePercent)}%` : `${Math.round(sizeRaw)}px`;
+        elGuideInfoCnt.innerHTML = `${Math.round(sizeRaw)}px`;
 
         guideNearElement = {
           guide: item,
diff --git a/packages/core/test/specs/commands/index.ts b/packages/core/test/specs/commands/index.ts
index 310369afa..54d595dc2 100644
--- a/packages/core/test/specs/commands/index.ts
+++ b/packages/core/test/specs/commands/index.ts
@@ -94,5 +94,52 @@ describe('Commands', () => {
       expect(obj.isActive(commName)).toBe(false);
       expect(Object.keys(obj.getActive()).length).toBe(0);
     });
+
+    test('Run command with and without default options', () => {
+      const defaultOptions = { test: 'default' };
+      const options = { test: 'custom' };
+      const command = { run: jest.fn(), stop: jest.fn() };
+      obj.add(commName, command);
+      em.config.commands = {
+        defaultOptions: {
+          [commName]: {
+            run: (opts) => ({ ...opts, ...defaultOptions }),
+          },
+        },
+      };
+
+      // Test run command with default options
+      obj.run(commName, options);
+      expect(command.run).toHaveBeenCalledWith(em, { ...options, ...defaultOptions });
+
+      // Test run command without default options
+      em.config.commands.defaultOptions![commName].run = undefined;
+      obj.run(commName, options);
+      expect(command.run).toHaveBeenCalledWith(em, options);
+    });
+
+    test('Stop command with and without default options', () => {
+      const defaultOptions = { test: 'default' };
+      const options = { test: 'custom' };
+      const command = { run: jest.fn(), stop: jest.fn() };
+      obj.add(commName, command);
+      em.config.commands = {
+        defaultOptions: {
+          [commName]: {
+            stop: (opts) => ({ ...opts, ...defaultOptions }),
+          },
+        },
+      };
+
+      // Test stop command with default options
+      obj.run(commName, options);
+      obj.stop(commName, options);
+      expect(command.stop).toHaveBeenCalledWith(em, { ...options, ...defaultOptions });
+
+      // Test stop command without default options
+      em.config.commands.defaultOptions![commName].stop = undefined;
+      obj.stop(commName, options);
+      expect(command.stop).toHaveBeenCalledWith(em, options);
+    });
   });
 });