fix(video): remove deprecated modestbranding option from YouTube videos

- Remove modestbranding property from default component traits
- Remove modestbranding parameter parsing from YouTube URL query string handling
- Remove modestbranding checkbox trait from component configuration
- Remove modestbranding URL parameter generation from getYoutubeSrc method
- Update ComponentVideoView to stop listening for modestbranding change events
- The modestbranding option was deprecated by YouTube and is no longer functional

packages/core/src/dom_components/model/ComponentVideo.ts

@@ -35,7 +35,6 @@ export default class ComponentVideo extends ComponentImage {
       list: '',
       src: '',
       rel: 1, // YT related videos
-      modestbranding: 0, // YT modest branding
       sources: [],
       attributes: { allowfullscreen: 'allowfullscreen' },
     };
@@ -132,7 +131,6 @@ export default class ComponentVideo extends ComponentImage {
         parseInt(qr.controls) === 0 && this.set('controls', false);
         hasParam(qr.color) && this.set('color', qr.color);
         qr.rel === '0' && this.set('rel', 0);
-        qr.modestbranding === '1' && this.set('modestbranding', 1);
         qr.muted === '1' && this.set('muted', true);
         break;
       default:
@@ -256,12 +254,6 @@ export default class ComponentVideo extends ComponentImage {
         name: 'rel',
         changeProp: true,
       },
-      {
-        type: 'checkbox',
-        label: 'Modest',
-        name: 'modestbranding',
-        changeProp: true,
-      },
       this.getMutedTrait(),
     ];
   }
@@ -364,7 +356,6 @@ export default class ComponentVideo extends ComponentImage {
     url += !this.get('controls') ? '&controls=0&showinfo=0' : '';
     url += this.get('loop') ? `&loop=1&playlist=${id}` : '';
     url += this.get('rel') ? '' : '&rel=0';
-    url += this.get('modestbranding') ? '&modestbranding=1' : '';
     return url;
   }
 

packages/core/src/dom_components/view/ComponentVideoView.ts

@@ -18,7 +18,7 @@ export default class ComponentVideoView extends ComponentImageView<ComponentVide
     // @ts-ignore
     ComponentView.prototype.initialize.apply(this, arguments);
     const { model } = this;
-    const props = ['loop', 'autoplay', 'controls', 'color', 'rel', 'modestbranding', 'poster', 'muted'];
+    const props = ['loop', 'autoplay', 'controls', 'color', 'rel', 'poster', 'muted'];
     const events = props.map((p) => `change:${p}`).join(' ');
     this.listenTo(model, 'change:provider', this.updateProvider);
     this.listenTo(model, 'change:src', this.updateSrc);