From a5e899400800ae0d8729d44fec984c7d7860f7aa Mon Sep 17 00:00:00 2001 From: mohamedsalem401 Date: Thu, 20 Feb 2025 18:17:18 +0200 Subject: [PATCH] Avoid throwing errors if no condition is passed to a DataCondition --- .../model/conditional_variables/DataCondition.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/core/src/data_sources/model/conditional_variables/DataCondition.ts b/packages/core/src/data_sources/model/conditional_variables/DataCondition.ts index 0d46e8dda..0c87e3c41 100644 --- a/packages/core/src/data_sources/model/conditional_variables/DataCondition.ts +++ b/packages/core/src/data_sources/model/conditional_variables/DataCondition.ts @@ -8,6 +8,7 @@ import { GenericOperation } from './operators/GenericOperator'; import { LogicalOperation } from './operators/LogicalOperator'; import { NumberOperation } from './operators/NumberOperator'; import { StringOperation } from './operators/StringOperations'; +import { isUndefined } from 'underscore'; export const DataConditionType = 'data-condition'; @@ -45,8 +46,8 @@ export class DataCondition extends Model { public ifFalse: any, opts: { em: EditorModel; onValueChange?: () => void }, ) { - if (typeof condition === 'undefined') { - throw new MissingConditionError(); + if (isUndefined(condition)) { + opts.em.logError('No condition was provided to a conditional component.'); } const conditionInstance = new Condition(condition, { em: opts.em }); @@ -128,8 +129,3 @@ export class DataCondition extends Model { }; } } -export class MissingConditionError extends Error { - constructor() { - super('No condition was provided to a conditional component.'); - } -}