cleanup and refactor

packages/core/src/common/index.ts

@@ -9,7 +9,6 @@ export const collectionEvents = 'add remove reset change';
 export type Debounced = Function & { cancel(): void };
 
 export type SetOptions = Backbone.ModelSetOptions & {
-  unset?: boolean;
   avoidStore?: boolean;
   avoidTransformers?: boolean;
   partial?: boolean;

packages/core/src/dom_components/model/Component.ts

@@ -337,33 +337,34 @@ export default class Component extends StyleableModel<ComponentProperties> {
     }
   }
 
-  set<A extends string>(attributeName: A, value?: ComponentProperties[A], options?: ComponentSetOptions): this;
-  set(attributeName: Partial<ComponentProperties>, options?: ComponentSetOptions): this;
   set<A extends string>(
-    attributeName: Partial<ComponentProperties> | A,
+    keyOrAttributes: A | Partial<ComponentProperties>,
-    value?: SetOptions | ComponentProperties[A],
+    valueOrOptions?: ComponentProperties[A] | SetOptions,
     options?: ComponentSetOptions,
   ): this;
+
   set<A extends string>(
-    attributeName: Partial<ComponentProperties> | A,
+    keyOrAttributes: A | Partial<ComponentProperties>,
-    value?: SetOptions | ComponentProperties[A],
+    valueOrOptions?: ComponentProperties[A] | SetOptions,
     options: ComponentSetOptions = { skipWatcherUpdates: false },
   ): this {
-    const props =
+    const attributes =
-      typeof attributeName === 'object'
+      typeof keyOrAttributes === 'object'
-        ? attributeName
+        ? keyOrAttributes
-        : typeof attributeName === 'string'
+        : typeof keyOrAttributes === 'string'
-          ? { [attributeName as string]: value }
+          ? { [keyOrAttributes as string]: valueOrOptions }
           : {};
-    const areStaticAttributes = DynamicValueWatcher.areStaticValues(props);
+
-    const evaluatedProps = areStaticAttributes
+    const areStaticAttributes = DynamicValueWatcher.areStaticValues(attributes);
-      ? props
+    const evaluatedAttributes = areStaticAttributes
-      : ComponentDynamicValueListener.evaluateComponentDef(props, this.em);
+      ? attributes
+      : ComponentDynamicValueListener.evaluateComponentDef(attributes, this.em);
+
     if (!options.skipWatcherUpdates) {
-      this.componentDVListener?.watchProps(props);
+      this.componentDVListener?.watchProps(attributes);
     }
 
-    return super.set(evaluatedProps, options);
+    return super.set(evaluatedAttributes, options);
   }
 
   __postAdd(opts: { recursive?: boolean } = {}) {