From b7d27936f907b91ee8b5627fcd5dd6afafb5651a Mon Sep 17 00:00:00 2001 From: mohamedsalem401 Date: Fri, 10 Jan 2025 13:25:18 +0200 Subject: [PATCH] Fix falsy value being treated as undefined --- .../model/collection_component/CollectionComponent.ts | 1 - packages/core/src/dom_components/model/Component.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/core/src/data_sources/model/collection_component/CollectionComponent.ts b/packages/core/src/data_sources/model/collection_component/CollectionComponent.ts index a51bed916..e3257dfc0 100644 --- a/packages/core/src/data_sources/model/collection_component/CollectionComponent.ts +++ b/packages/core/src/data_sources/model/collection_component/CollectionComponent.ts @@ -67,7 +67,6 @@ export default class CollectionComponent extends Component { private getBlockDefinition() { const firstChild = this.components().at(0)?.toJSON() || {}; - console.log('🚀 ~ CollectionComponent ~ getBlockDefinition ~ firstChild:', firstChild); return firstChild; } diff --git a/packages/core/src/dom_components/model/Component.ts b/packages/core/src/dom_components/model/Component.ts index 8a2f02da4..a627f8813 100644 --- a/packages/core/src/dom_components/model/Component.ts +++ b/packages/core/src/dom_components/model/Component.ts @@ -978,7 +978,7 @@ export default class Component extends StyleableModel { const value = trait.getInitValue(); if (trait.changeProp) { - !this.get(name) && this.set(name, value); + isUndefined(this.get(name)) && this.set(name, value); } else { if (name && value) attrs[name] = value; }