From c2add4a0925629fb02382530d3bbb894f3b6e64f Mon Sep 17 00:00:00 2001 From: Artur Arseniev Date: Thu, 16 Nov 2017 13:00:42 +0100 Subject: [PATCH] Avoid `component:add` with temporary adds --- src/dom_components/view/ComponentsView.js | 9 ++++----- src/keymaps/index.js | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/dom_components/view/ComponentsView.js b/src/dom_components/view/ComponentsView.js index 8becdc5bf..7408104fb 100644 --- a/src/dom_components/view/ComponentsView.js +++ b/src/dom_components/view/ComponentsView.js @@ -18,13 +18,12 @@ module.exports = Backbone.View.extend({ * @private * */ addTo(model) { - var i = this.collection.indexOf(model); + const em = this.config.em; + const i = this.collection.indexOf(model); this.addToCollection(model, null, i); - var em = this.config.em; - if(em) { - // OLD - em.trigger('add:component', model); + if (em && !model.opt.temporary) { + em.trigger('add:component', model); // @deprecated em.trigger('component:add', model); } }, diff --git a/src/keymaps/index.js b/src/keymaps/index.js index 71275a8f2..401dd2353 100644 --- a/src/keymaps/index.js +++ b/src/keymaps/index.js @@ -7,7 +7,7 @@ * ``` * */ -import { defaults, isString } from 'underscore'; +import { isString } from 'underscore'; const keymaster = require('keymaster');