From f252d85b1a2f91e136402a22e08f5a732355032b Mon Sep 17 00:00:00 2001 From: Juan Date: Thu, 3 Sep 2020 12:12:10 +0200 Subject: [PATCH 1/2] validating presence of component before removal --- src/dom_components/model/Components.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/dom_components/model/Components.js b/src/dom_components/model/Components.js index d6b9689f1..bad644704 100644 --- a/src/dom_components/model/Components.js +++ b/src/dom_components/model/Components.js @@ -22,6 +22,12 @@ export default Backbone.Collection.extend({ }, removeChildren(removed, coll, opts = {}) { + // Removing a parent component can cause this function + // to be called with an already removed child element + if (!removed) { + return; + } + const { domc, em } = this; const allByID = domc ? domc.allById() : {}; From 3d5a98d89c9f0eed07a0781f857f5837f84323c1 Mon Sep 17 00:00:00 2001 From: Juan Date: Thu, 3 Sep 2020 12:12:20 +0200 Subject: [PATCH 2/2] typo --- src/dom_components/model/Components.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dom_components/model/Components.js b/src/dom_components/model/Components.js index bad644704..f51af7e8a 100644 --- a/src/dom_components/model/Components.js +++ b/src/dom_components/model/Components.js @@ -32,7 +32,7 @@ export default Backbone.Collection.extend({ const allByID = domc ? domc.allById() : {}; if (!opts.temporary) { - // Remove the component from the gloabl list + // Remove the component from the global list const id = removed.getId(); const sels = em.get('SelectorManager').getAll(); const rules = em.get('CssComposer').getAll();