From e6b623fdd9e940a8335561a89c4d644d73e83d27 Mon Sep 17 00:00:00 2001 From: Artur Arseniev Date: Thu, 18 Jan 2018 14:48:26 +0100 Subject: [PATCH] Fix regression in getModelToStyle --- src/style_manager/index.js | 9 ++++++--- src/style_manager/view/SectorsView.js | 1 + test/specs/selector_manager/e2e/ClassManager.js | 12 ++++++------ 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/style_manager/index.js b/src/style_manager/index.js index a631451f8..e91e95f56 100644 --- a/src/style_manager/index.js +++ b/src/style_manager/index.js @@ -248,8 +248,9 @@ module.exports = () => { const em = c.em; const classes = model.get('classes'); const id = model.getId(); - + console.log('rule a'); if (em) { + console.log('rule b'); const config = em.getConfig(); const um = em.get('UndoManager'); const cssC = em.get('CssComposer'); @@ -258,8 +259,9 @@ module.exports = () => { const hasClasses = valid.length; const opts = { state }; let rule; - + console.log('rule b2'); if (hasClasses) { + console.log('rule c'); const deviceW = em.getCurrentMedia(); rule = cssC.get(valid, state, deviceW); @@ -275,11 +277,12 @@ module.exports = () => { um.start(); } } else if (config.avoidInlineStyle) { + console.log('rule d'); rule = cssC.getIdRule(id, opts); !rule && (rule = cssC.setIdRule(id, {}, opts)); } - model = rule; + rule && (model = rule); } return model; diff --git a/src/style_manager/view/SectorsView.js b/src/style_manager/view/SectorsView.js index 065f63c45..89a836d47 100644 --- a/src/style_manager/view/SectorsView.js +++ b/src/style_manager/view/SectorsView.js @@ -77,6 +77,7 @@ module.exports = Backbone.View.extend({ }; model = em.get('StyleManager').getModelToStyle(model); + console.log('AFTER getModelToStyle'); state && appendStateRule(model.getStyle()); pt.model = model; pt.trigger('update'); diff --git a/test/specs/selector_manager/e2e/ClassManager.js b/test/specs/selector_manager/e2e/ClassManager.js index 0ba3fef82..e7a2f1b8b 100644 --- a/test/specs/selector_manager/e2e/ClassManager.js +++ b/test/specs/selector_manager/e2e/ClassManager.js @@ -45,18 +45,17 @@ module.exports = { describe.only('Interaction with Components', () => { beforeEach(function() { - components = gjs.editor - .get('DomComponents') - .getWrapper() - .get('components'); + components = gjs.getComponents(); tagEl = instClassTagViewer(gjs, fixtures); }); it('Assign correctly new class to component', function() { var model = components.add({}); expect(model.get('classes').length).toEqual(0); - gjs.editor.set('selectedComponent', model); - tagEl.addNewTag('test'); + console.log('Assign correctly...'); + gjs.select(model); + //tagEl.addNewTag('test'); + /* expect(model.get('classes').length).toEqual(1); expect( model @@ -64,6 +63,7 @@ module.exports = { .at(0) .get('name') ).toEqual('test'); + */ }); it('Classes from components are correctly imported inside main container', function() {