tsai
/
grapesjs
mirror of https://github.com/artf/grapesjs.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Rename and refactor GenericOperator

pull/6419/head
mohamedsalem401 2 years ago
parent
265d7fb6a8
commit
ebb99a653c
2 changed files with 45 additions and 40 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 16
      packages/core/src/data_sources/model/conditional_variables/operators/AnyTypeOperator.ts
  2. 69
      packages/core/test/specs/data_sources/model/conditional_variables/operators/AnyTypeOperator.ts

16
packages/core/src/data_sources/model/conditional_variables/operators/GenericOperator.ts → packages/core/src/data_sources/model/conditional_variables/operators/AnyTypeOperator.ts
View File

@ -1,7 +1,8 @@
import DataVariable from '../../DataVariable';
import { Operator } from '.';
import { Operator } from './BaseOperator';
import EditorModel from '../../../../editor/model/Editor';
export enum GenericOperation {
export enum AnyTypeOperation {
equals = 'equals',
isTruthy = 'isTruthy',
isFalsy = 'isFalsy',
@ -16,13 +17,9 @@ export enum GenericOperation {
isDefaultValue = 'isDefaultValue', // For Datasource variables
}
export class GenericOperator extends Operator {
constructor(private operator: GenericOperation) {
super();
}
export class AnyTypeOperator extends Operator<AnyTypeOperation> {
evaluate(left: any, right: any): boolean {
switch (this.operator) {
switch (this.operation) {
case 'equals':
return left === right;
case 'isTruthy':
@ -48,7 +45,8 @@ export class GenericOperator extends Operator {
case 'isDefaultValue':
return left instanceof DataVariable && left.get('defaultValue') === right;
default:
throw new Error(`Unsupported generic operator: ${this.operator}`);
this.em?.logError(`Unsupported generic operation: ${this.operation}`);
return false;
}
}
}

69
packages/core/test/specs/data_sources/model/conditional_variables/operators/GenericOperator.ts → packages/core/test/specs/data_sources/model/conditional_variables/operators/AnyTypeOperator.ts
View File

@ -1,150 +1,157 @@
import {
GenericOperator,
GenericOperation,
} from '../../../../../../src/data_sources/model/conditional_variables/operators/GenericOperator';
AnyTypeOperator,
AnyTypeOperation,
} from '../../../../../../src/data_sources/model/conditional_variables/operators/AnyTypeOperator';
import Editor from '../../../../../../src/editor/model/Editor';
import EditorModel from '../../../../../../src/editor/model/Editor';
describe('GenericOperator', () => {
let em: EditorModel;
beforeEach(() => {
em = new Editor();
});
afterEach(() => {
em.destroy();
});
describe('Operator: equals', () => {
test('should return true when values are equal', () => {
const operator = new GenericOperator(GenericOperation.equals);
const operator = new AnyTypeOperator(AnyTypeOperation.equals, { em });
expect(operator.evaluate(5, 5)).toBe(true);
});
test('should return false when values are not equal', () => {
const operator = new GenericOperator(GenericOperation.equals);
const operator = new AnyTypeOperator(AnyTypeOperation.equals, { em });
expect(operator.evaluate(5, 10)).toBe(false);
});
});
describe('Operator: isTruthy', () => {
test('should return true for truthy value', () => {
const operator = new GenericOperator(GenericOperation.isTruthy);
const operator = new AnyTypeOperator(AnyTypeOperation.isTruthy, { em });
expect(operator.evaluate('non-empty', null)).toBe(true);
});
test('should return false for falsy value', () => {
const operator = new GenericOperator(GenericOperation.isTruthy);
const operator = new AnyTypeOperator(AnyTypeOperation.isTruthy, { em });
expect(operator.evaluate('', null)).toBe(false);
});
});
describe('Operator: isFalsy', () => {
test('should return true for falsy value', () => {
const operator = new GenericOperator(GenericOperation.isFalsy);
const operator = new AnyTypeOperator(AnyTypeOperation.isFalsy, { em });
expect(operator.evaluate(0, null)).toBe(true);
});
test('should return false for truthy value', () => {
const operator = new GenericOperator(GenericOperation.isFalsy);
const operator = new AnyTypeOperator(AnyTypeOperation.isFalsy, { em });
expect(operator.evaluate(1, null)).toBe(false);
});
});
describe('Operator: isDefined', () => {
test('should return true for defined value', () => {
const operator = new GenericOperator(GenericOperation.isDefined);
const operator = new AnyTypeOperator(AnyTypeOperation.isDefined, { em });
expect(operator.evaluate(10, null)).toBe(true);
});
test('should return false for undefined value', () => {
const operator = new GenericOperator(GenericOperation.isDefined);
const operator = new AnyTypeOperator(AnyTypeOperation.isDefined, { em });
expect(operator.evaluate(undefined, null)).toBe(false);
});
});
describe('Operator: isNull', () => {
test('should return true for null value', () => {
const operator = new GenericOperator(GenericOperation.isNull);
const operator = new AnyTypeOperator(AnyTypeOperation.isNull, { em });
expect(operator.evaluate(null, null)).toBe(true);
});
test('should return false for non-null value', () => {
const operator = new GenericOperator(GenericOperation.isNull);
const operator = new AnyTypeOperator(AnyTypeOperation.isNull, { em });
expect(operator.evaluate(0, null)).toBe(false);
});
});
describe('Operator: isUndefined', () => {
test('should return true for undefined value', () => {
const operator = new GenericOperator(GenericOperation.isUndefined);
const operator = new AnyTypeOperator(AnyTypeOperation.isUndefined, { em });
expect(operator.evaluate(undefined, null)).toBe(true);
});
test('should return false for defined value', () => {
const operator = new GenericOperator(GenericOperation.isUndefined);
const operator = new AnyTypeOperator(AnyTypeOperation.isUndefined, { em });
expect(operator.evaluate(0, null)).toBe(false);
});
});
describe('Operator: isArray', () => {
test('should return true for array', () => {
const operator = new GenericOperator(GenericOperation.isArray);
const operator = new AnyTypeOperator(AnyTypeOperation.isArray, { em });
expect(operator.evaluate([1, 2, 3], null)).toBe(true);
});
test('should return false for non-array', () => {
const operator = new GenericOperator(GenericOperation.isArray);
const operator = new AnyTypeOperator(AnyTypeOperation.isArray, { em });
expect(operator.evaluate('not an array', null)).toBe(false);
});
});
describe('Operator: isObject', () => {
test('should return true for object', () => {
const operator = new GenericOperator(GenericOperation.isObject);
const operator = new AnyTypeOperator(AnyTypeOperation.isObject, { em });
expect(operator.evaluate({ key: 'value' }, null)).toBe(true);
});
test('should return false for non-object', () => {
const operator = new GenericOperator(GenericOperation.isObject);
const operator = new AnyTypeOperator(AnyTypeOperation.isObject, { em });
expect(operator.evaluate(42, null)).toBe(false);
});
});
describe('Operator: isString', () => {
test('should return true for string', () => {
const operator = new GenericOperator(GenericOperation.isString);
const operator = new AnyTypeOperator(AnyTypeOperation.isString, { em });
expect(operator.evaluate('Hello', null)).toBe(true);
});
test('should return false for non-string', () => {
const operator = new GenericOperator(GenericOperation.isString);
const operator = new AnyTypeOperator(AnyTypeOperation.isString, { em });
expect(operator.evaluate(42, null)).toBe(false);
});
});
describe('Operator: isNumber', () => {
test('should return true for number', () => {
const operator = new GenericOperator(GenericOperation.isNumber);
const operator = new AnyTypeOperator(AnyTypeOperation.isNumber, { em });
expect(operator.evaluate(42, null)).toBe(true);
});
test('should return false for non-number', () => {
const operator = new GenericOperator(GenericOperation.isNumber);
const operator = new AnyTypeOperator(AnyTypeOperation.isNumber, { em });
expect(operator.evaluate('not a number', null)).toBe(false);
});
});
describe('Operator: isBoolean', () => {
test('should return true for boolean', () => {
const operator = new GenericOperator(GenericOperation.isBoolean);
const operator = new AnyTypeOperator(AnyTypeOperation.isBoolean, { em });
expect(operator.evaluate(true, null)).toBe(true);
});
test('should return false for non-boolean', () => {
const operator = new GenericOperator(GenericOperation.isBoolean);
const operator = new AnyTypeOperator(AnyTypeOperation.isBoolean, { em });
expect(operator.evaluate(1, null)).toBe(false);
});
});
describe('Edge Case Tests', () => {
test('should handle null as input gracefully', () => {
const operator = new GenericOperator(GenericOperation.isNull);
const operator = new AnyTypeOperator(AnyTypeOperation.isNull, { em });
expect(operator.evaluate(null, null)).toBe(true);
});
test('should throw error for unsupported operator', () => {
const operator = new GenericOperator('unsupported' as GenericOperation);
expect(() => operator.evaluate(1, 2)).toThrow('Unsupported generic operator: unsupported');
});
});
});
Write Preview
Loading…
Cancel
Save