grapesjs

4140 Commits

210 Branches

160 Tags

126 MiB

Tree: 4cd3173454

Commit Graph

Author	SHA1	Message	Date
Artur Arseniev	432c480ef8	Update tests	6 years ago
mathieu.cottret	2d148aebcd	Fix borders not always toggling back when exiting preview. Fixes artf/grapesjs#2637 As described by [this issue](artf/grapesjs#2637), the component borders may not be toggled back when exiting preview mode in some cases. This fixes this issue by adding a `shouldRunSwVisibility` flag to the Preview command, set via the Commands API on its run (before stopping the `sw-visibility` command if it's active), & used on stop to reactivate the `sw-visibility` command if needed. Which also implies: - Prevent toggling of component borders while preview is active - Rely on the Commands API to detect if the `sw-visibility` command is active rather than a panel button - Prevent resetting the `shouldRunVisibility` flag on multiple subsequent (forced) runs / stops of the preview command	6 years ago

Author

SHA1

Message

Date

Artur Arseniev

432c480ef8

Update tests

6 years ago

mathieu.cottret

2d148aebcd

Fix borders not always toggling back when exiting preview. Fixes artf/grapesjs#2637

As described by [this issue](artf/grapesjs#2637), the component borders may not be toggled back when exiting preview mode in some cases.

This fixes this issue by adding a `shouldRunSwVisibility` flag to the Preview command, set via the Commands API on its run (before stopping the `sw-visibility` command if it's active), & used on stop to reactivate the `sw-visibility` command if needed.

Which also implies:

- Prevent toggling of component borders while preview is active
- Rely on the Commands API to detect if the `sw-visibility` command is active rather than a panel button
- Prevent resetting the `shouldRunVisibility` flag on multiple subsequent (forced) runs / stops of the preview command

6 years ago

2 Commits (4cd3173454317bf8d1b2a87f9a3f0cfaf2d097bf)