CI: Upgrade to Gendarme 2.8, re-enable it in continous builds

build/TeamCity/on-checkin.proj

@@ -2,11 +2,11 @@
   <UsingTask TaskName="Gallio.MSBuildTasks.Gallio" AssemblyFile="..\..\lib\Gallio_3.2.517.0\Gallio.MSBuildTasks.dll" />
   <UsingTask TaskName="MSBuild.ExtensionPack.CodeQuality.StyleCop" AssemblyFile="..\MSBuild_Extension_Pack_3.5.5\StyleCop\MSBuild.ExtensionPack.StyleCop.dll" />
   
-  <Target Name="Go" DependsOnTargets="Test; StyleCop;" />
+  <Target Name="Go" DependsOnTargets="Test; StyleCop; Gendarme" />
    
   <Target Name="Test">
     <Gallio.MSBuildTasks.Gallio ContinueOnError="False" IgnoreFailures="False" Files="../../out/test/Net40/MathNet.Numerics.UnitTests.dll" />
-    <Exec Command="$(MSBuildProjectDirectory)/../../out/test/Net40/FSharpUnitTests.exe" IgnoreExitCode="false" />
+    <Exec Command="$(MSBuildProjectDirectory)\..\..\out\test\Net40\MathNet.Numerics.FSharp.UnitTests.exe" IgnoreExitCode="false" />
   </Target>
   
   <Target Name="StyleCop">
@@ -24,7 +24,7 @@
   </Target>
   
   <Target Name="Gendarme">
-    <Exec Command="$(MSBuildProjectDirectory)/../../tools/Gendarme-2.4/gendarme.exe $(MSBuildProjectDirectory)/../../out/lib/Net40/MathNet.Numerics.dll"/>
+    <Exec Command="$(MSBuildProjectDirectory)/../../tools/Gendarme-2.8/gendarme.exe $(MSBuildProjectDirectory)/../../out/lib/Net40/MathNet.Numerics.dll" IgnoreExitCode="true"/>
   </Target>
   
 </Project>

tools/Gendarme-2.4/gendarme.1

@@ -1,102 +0,0 @@
-.\" 
-.\" Gendarme manual page.
-.\"
-.\" Author:
-.\"	Sebastien Pouliot  <sebastien@ximian.com>
-.\"
-.\" Copyright (C) 2005-2006,2008 Novell, Inc (http://www.novell.com)
-.\"
-
-.de Sp
-.if t .sp .5v
-.if n .sp
-..
-.TH Gendarme "Gendarme 2.4.0.0"
-.SH NAME
-Gendarme \- Rule-based code analysis for Mono::
-.SH SYNOPSIS
-.PP
-.B gendarme [--config configfile] [--set ruleset] [--log file | --xml file | --html file] [options] assemblies ...
-.SH DESCRIPTION
-\fIGendarme\fP is a extensible rule-based tool to find problems in .NET 
-applications and libraries. Gendarme inspects programs and libraries that
-contain code in ECMA CIL format (Mono and .NET) and looks for common 
-problems with the code, problems that compiler do not typically check or
-have not historically checked.
-.SH OPTIONS
-.TP
-.I "--config configfile"
-Specify the configuration file. Default is 'rules.xml'.
-.TP
-.I "--set ruleset"
-Specify the set of rules to verify. Default is '*'.
-.TP
-.I "--log file"
-Save the text output to the specified file.
-.TP
-.I "--xml file"
-Save the output, formatted as XML, to the specified file.
-.TP
-.I "--html file"
-Save the output, formatted as HTML, to the specified file.
-.TP
-.I "--ignore ignore-file"
-Do not report the known defects that are part of the specified file.
-.TP
-.I "--limit N"
-Stop reporting after N defects are found.
-.TP
-.I "--severity [all | audit[+] | low[+|-] | medium[+|-] | high[+|-] | critical[-]],...
-Filter the reported defects to include the specified severity levels.
-Default is 'medium+' (i.e. low and audit levels are ignored).
-.TP
-.I "--confidence [all | low[+] | normal[+|-] | high[+|-] | total[-]],...
-Filter the reported defects to include the specified confidence levels.
-Default is 'normal+' (i.e. low level is ignored).
-.TP
-.I "--quiet"
-Display minimal output (results) from the runner.
-.TP
-.I "--v|verbose"
-Enable debugging output. You can supply several -v to augment debugging verbosity.
-.TP
-.I "--version"
-Display Gendarme's version number. This number match the Mono release
-where it was released.
-.TP
-.I "assemblies ..."
-Specify the assemblies to verify. You can specify multiple filenames, 
-including masks (? and *). You can also provide a file that list several
-assemblies (one by line) by prefixing the filename with @ on the command 
-line.
-.SH FILES
-.TP
-.I rules.xml
-This files contains a list of all the rulesets available to Gendarme. Each 
-ruleset includes a list of assemblies in which some, or all, rules can be
-verified (include) or not (exclude).
-+.TP
-+.I gendarme.exe.config
-+Used by debug versions of Gendarme to enable logging for rules. A config
-+file will be generated automatically by the make file. To enable logging
-+for a rule add a switch using the rule's name and set the value to 1.
-.SH ENVIRONMENT VARIABLES
-.TP
-.I GENDARME_COLOR
-The runner will use colors when displaying defects on the console. 
-By default colors are dark in order to display correctly on any 
-background. You can change this default to "light" (lighter colors 
-looks nice on a dark background, or "none" so no colors will be used.
-E.g.
-.nf
-    GENDARME_COLOR=none gendarme ...
-.fi
-.SH COPYRIGHT
-Copyright (C) 2005-2008 Novell, Inc (http://www.novell.com)
-.SH MAILING LISTS
-Mailing lists are listed at the
-http://groups.google.com/group/gendarme
-.SH WEB SITE
-http://www.mono-project.com/Gendarme
-.SH SEE ALSO
-.BR mono(1)

tools/Gendarme-2.4/AUTHORS → tools/Gendarme-2.8/AUTHORS

@@ -15,3 +15,5 @@ Cedric Vivier <cedricv@neonux.com>
 Andres G. Aragoneses <aaragoneses@novell.com>
 Peter Johanson  <peter@peterjohanson.com>
 Jesse Jones  <jesjones@mindspring.com>
+Rolf Bjarne Kvinge <RKvinge@novell.com>
+Antoine Vandecreme  <avandecreme@sopragroup.com>

tools/Gendarme-2.4/MIT.X11 → tools/Gendarme-2.8/MIT.X11

@@ -1,4 +1,4 @@
-Copyright (c) 2005-2008 Novell, Inc and the individuals listed on the 
+Copyright (c) 2005-2010 Novell, Inc and the individuals listed on the 
 ChangeLog entries.
 
 Permission is hereby granted, free of charge, to any person obtaining

tools/Gendarme-2.4/NEWS → tools/Gendarme-2.8/NEWS

@@ -1,3 +1,81 @@
+2010-09-05  Version 2.8.0
+
+	First release in the 2.8.x serie which will lead to the 3.0
+	release. Many rules were enhanced and a lot of work was done
+	to make Gendarme adhere to its own rules (self-test).
+
+	This release also includes 10 new rules (221 rules total):
+
+	Gendarme.Rules.BadPractice
+	* PreferParamsArrayForVariableArgumentsRule [Sebastien Pouliot]
+	* PreferTryParseRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Correctness
+	* UseNoInliningWithGetCallingAssemblyRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Design
+	* ProvideTryParseAlternativeRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Design.Generic
+	* AvoidDeclaringCustomDelegatesRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Maintainability
+	* RemoveDependenceOnObsoleteCodeRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Interoperability
+	* CentralizePInvokesIntoNativeMethodsTypeRule [Sebastien Pouliot]
+
+	Gendarme.Rules.Performance
+	* AvoidConcatenatingCharsRule [Sebastien Pouliot]
+	* AvoidLocalDataStoreSlotRule [Sebastien Pouliot]
+	* AvoidRepetitiveCallsToPropertiesRule [Sebastien Pouliot]
+
+	Contributors for this release are:
+	Antoine Vandecreme, JB Evain, Rolf Bjarne Kvinge and Sebastien 
+	Pouliot.
+
+2009-12-20  Version 2.6
+
+	Released just in time for xmas Gendarme 2.6 comes with a lot of
+	enhancements and bug fixes. Rule documentation (wiki) and our MAN
+	pages were also greatly enhanced by the work of Jesse Jones.
+
+	In the ecosystem Daniel Nauck contributed Gendarme support for 
+	CC.NET and a new NAnt task with reduced dependencies. With this
+	Gendarme should be easier than ever to use on your projects.
+
+	This release includes 12 new rules (207 rules total):
+
+	Gendarme.Rules.BadPractice
+	* DoNotUseEnumIsAssignableFromRule [JB Evain]
+	* OnlyUseDisposeForIDisposableTypesRule [Jesse Jones]
+	* PreferSafeHandleRule [Jesse Jones]
+
+	Gendarme.Rules.Concurrency
+	* DoNotUseThreadStaticWithInstanceFieldsRule [Jesse Jones]
+
+	Gendarme.Rules.Correctness
+	* ProvideValidXmlStringRule [Cedric Vivier]
+	* ProvideValidXPathExpressionRule [Cedric Vivier]
+
+	Gendarme.Rules.Design
+	* PreferXmlAbstractionsRule [Cedric Vivier]
+	* UseCorrectDisposeSignaturesRule [Jesse Jones]
+	* UseFlagsAttributeRule [Jesse Jones]
+
+	Gendarme.Rules.Exceptions
+	* UseObjectDisposedExceptionRule [Jesse Jones]
+
+	Gendarme.Rules.Interoperability
+	* DelegatesPassedToNativeCodeMustIncludeExceptionHandlingRule [Rolf Bjarne Kvinge]
+
+	Gendarme.Rules.Performance
+	* ReviewLinqMethodRule [Jesse Jones]
+
+	Contributors for this release are:
+	Cedric Vivier, Daniel Nauck, JB Evain, Jesse Jones, Rolf Bjarne 
+	Kvinge and Sebastien Pouliot.
+
 2009-01-20  Version 2.4
 
 	This release was the shortest (about 2 months) release cycle ever
@@ -40,7 +118,7 @@
 	Contributors for this release are:
 	Andres G. Aragoneses, Cedric Vivier, JB Evain, Jesse Jones, 
 	Nestor Salceda, Sebastien Pouliot.
-	
+
 2008-11-10  Version 2.2
 
 	This release includes the development results of the last four 

tools/Gendarme-2.4/README → tools/Gendarme-2.8/README

@@ -19,7 +19,8 @@ http://groups.google.com/group/gendarme
 IMPORTANT NOTES
 
 * Gendarme "official" build system is based on the auto*/Makefile files
-and tested on monobuild. See mono-tools on http://mono.ximian.com/monobuild/
+and tested on MonkeyWrench. See mono-tools-trunk on 
+http://build.mono-project.com/index.aspx?lane=mono-trunk
 (checking out gendarme without its parent dir 'mono-tools' is not supported)
 
 * Visual Studio solutions and projects files (usable by both MonoDevelop

tools/Gendarme-2.8/gendarme.1

@@ -0,0 +1,128 @@
+.\" 
+.\" Gendarme manual page.
+.\"
+.\" Authors:
+.\"	Sebastien Pouliot  <sebastien@ximian.com>
+.\"	Jesse Jones  <jesjones@mindspring.com>
+.\"
+.\" Copyright (C) 2005-2006,2008-2010 Novell, Inc (http://www.novell.com)
+.\"
+
+.de Sp
+.if t .sp .5v
+.if n .sp
+..
+.TH Gendarme "Gendarme 2.8.0.0"
+.SH NAME
+Gendarme \- Rule-based code analysis for Mono.
+.SH SYNOPSIS
+.PP
+.B gendarme [--config configfile] [--set ruleset] [--log file | --xml file | --html file] [options] assemblies ...
+.SH DESCRIPTION
+\fIGendarme\fP is a extensible rule-based tool used to find problems in .NET 
+applications and libraries. Gendarme inspects programs and libraries that
+contain code in ECMA CIL format (Mono and .NET) and looks for common 
+problems with the code, problems that compilers do not typically check or
+have historically not checked.
+.SH OPTIONS
+.TP
+.I "--config configfile"
+Specify the rule sets and rule settings. Default is 'rules.xml'.
+.TP
+.I "--set ruleset"
+Specify a rule set from configfile. Defaults to 'default'.
+.TP
+.I "--log file"
+Save the report to the specified file. If none of --log, --xml, or --html are used
+then the report is written to stdout.
+.TP
+.I "--xml file"
+Save the report, formatted as XML, to the specified file.
+.TP
+.I "--html file"
+Save the report, formatted as HTML, to the specified file.
+.TP
+.I "--ignore ignore-file"
+Do not report defects listed in the specified file.
+.TP
+.I "--limit N"
+Stop reporting after N defects are found.
+.TP
+.I "--severity [all | audit[+] | low[+|-] | medium[+|-] | high[+|-] | critical[-]],...
+Filter the reported defects to include the specified severity levels.
+Default is 'medium+' (i.e. low and audit levels are ignored).
+.TP
+.I "--confidence [all | low[+] | normal[+|-] | high[+|-] | total[-]],...
+Filter the reported defects to include the specified confidence levels.
+Default is 'normal+' (i.e. low level is ignored).
+.TP
+.I "--quiet"
+Used to disable progress and other information which is normally written to stdout.
+.TP
+.I "--v|verbose"
+When present additional progress information is written to stdout. May be used
+more than once to write even more info. 
+.TP
+.I "--version"
+Display Gendarme's version number. This will match the Mono version number
+that this copy of Gendarme was released with.
+.TP
+.I "assemblies ..."
+Specify the assemblies to verify. You can specify multiple filenames, 
+including masks (? and *). You can also provide a file that lists several
+assemblies (one per line) by prefixing the filename with @ on the command 
+line.
+.SH FILES
+.TP
+.I ignore-file
+This file is used to filter out defects from gendarme reports. 
+.TP
+.I rules.xml
+This file is used in conjunction with the --set option to control and configure the rules
+used by Gendarme. It contains a set of named rules (rule sets) and each rule set contains 
+a list of rules.
+.TP
+.I gendarme.exe.config
+Used by debug versions of Gendarme to enable logging for rules. It is useful
+for Gendarme's developers (i.e. not meant for end-users).
+.SH ENVIRONMENT VARIABLES
+.TP
+.I GENDARME_COLOR
+The runner will use colors when displaying defects on the console. 
+By default colors are dark in order to display correctly on any 
+background. You can change this default to "light" (lighter colors 
+looks nice on a dark background, or "none" so no colors will be used.
+E.g.
+.nf
+    GENDARME_COLOR=none gendarme ...
+.fi
+.SH EXIT STATUS
+.TP
+.I 0
+The runner returns 0 when no error has occurred. If some code was 
+analyzed then this also means that no defects were found and reported.
+.TP
+.I 1
+The runner execution was successful but either some defects where found
+or no assembly was specified.
+.TP
+.I 2
+The runner execution was interrupted by I/O errors (e.g. missing files).
+.TP
+.I 3
+The runner founds errors in the (default or user supplied) configuration
+files. Specific error messages should be printed on the console.
+.TP
+.I 4
+The runner execution was interrupted by a non-handled exception. This
+is likely a bug inside Gendarme and should be reported on Novell's
+bugzilla (http://bugzilla.novell.com) or on the mailing-list.
+.SH COPYRIGHT
+Copyright (C) 2005-2009 Novell, Inc (http://www.novell.com)
+.SH MAILING LISTS
+Mailing lists are listed at the
+http://groups.google.com/group/gendarme
+.SH WEB SITE
+http://www.mono-project.com/Gendarme
+.SH SEE ALSO
+.BR gendarme(5), mono(1)

tools/Gendarme-2.8/gendarme.5

@@ -0,0 +1,80 @@
+.\" 
+.\" Gendarme manual page.
+.\"
+.\" Authors:
+.\"	Sebastien Pouliot  <sebastien@ximian.com>
+.\"	Jesse Jones  <jesjones@mindspring.com>
+.\"
+.\" Copyright (C) 2005-2006,2008-2009 Novell, Inc (http://www.novell.com)
+.\"
+
+.de Sp
+.if t .sp .5v
+.if n .sp
+..
+.TH Gendarme "Gendarme 2.8.0.0"
+.SH NAME
+Gendarme \- Rule-based code analysis for Mono.
+
+.SH FILE FORMATS
+.TP
+.I ignore-file
+This file is used to filter out defects from gendarme reports. It uses a line oriented
+file format where the first characters of the line control the interpretation of the line:
+.RS
+# - means that the line is a comment.
+.RE
+.RS
+R: - if the full name of a rule to be filtered.
+.RE
+.RS
+A: - is used to filter out an assembly (the extension can be omitted).
+.RE
+.RS
+T: - is used to filter out a namespace qualified type name.
+.RE
+.RS
+M: - is used to filter out a method. It must contain the full method name as it appears in the report.
+.RE
+
+.TP
+.I rules.xml
+This file is used in conjunction with the --set option to control and configure the rules
+used by Gendarme. It contains a set of named rules (rule sets) and each rule set contains 
+a list of rules. Rules have required from and include attributes, optional exclude and
+applyTo attributes, and optional parameter child elements.
+
+The from attribute is the path of a dll to load ("Gendarme.Rules.BadPractice.dll").
+Relative paths are relative to the gendarme executable.
+
+The include attribute may be "*" to match every rule in the dll or a list of rule names
+separated by '|' ("WhizBangRule | MyRule").
+
+The exclude attribute is a list of rule names separated by '|' ("IckyRule").
+These will override any rules matched by the include attribute.
+
+The applyTo attribute may be "all", "visible", or "nonvisible". If it is all (the default) then
+all types in the assemblies are checked, if it is visible then only the externally visible
+types are checked, if it is nonvisible then only the internally visible types are checked.
+
+The parameter child element is used to customize the behavior of a rule within a dll.
+It has three required attributes: rule, property, and value. rule is the name of the
+applicable rule ("AvoidSmallNamespaceRule"), property is the name of a public
+property in the rule ("Minimum"), value is the value to assign to the property ("10").
+.TP
+.I gendarme.exe.config
+Used by debug versions of Gendarme to enable logging for rules. A config
+file will be generated automatically by the make file. To enable logging
+for a rule edit the config file, add a switch using the rule's name, and set the 
+value to 1.
+
+.SH COPYRIGHT
+Copyright (C) 2005-2009 Novell, Inc (http://www.novell.com)
+.SH MAILING LISTS
+Mailing lists are listed at the
+http://groups.google.com/group/gendarme
+.SH WEB SITE
+http://www.mono-project.com/Gendarme
+.SH SEE ALSO
+.BR gendarme(1)
+