Browse Source

LA: fix bug in Matrix.RemoveRow range checks

pull/225/merge
Christoph Ruegg 12 years ago
parent
commit
55b2dbc6a8
  1. 2
      src/Numerics/LinearAlgebra/Matrix.cs
  2. 2
      src/UnitTests/LinearAlgebraTests/MatrixStructureTheory.Reform.cs

2
src/Numerics/LinearAlgebra/Matrix.cs

@ -836,7 +836,7 @@ namespace MathNet.Numerics.LinearAlgebra
/// <exception cref="ArgumentOutOfRangeException">If <paramref name="rowIndex"/> is &lt; zero or &gt; the number of rows.</exception>
public Matrix<T> RemoveRow(int rowIndex)
{
if (rowIndex < 0 || rowIndex > ColumnCount)
if (rowIndex < 0 || rowIndex > RowCount)
{
throw new ArgumentOutOfRangeException("rowIndex");
}

2
src/UnitTests/LinearAlgebraTests/MatrixStructureTheory.Reform.cs

@ -134,7 +134,6 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
[Theory]
public void CanRemoveRow(Matrix<T> matrix)
{
var row = Vector<T>.Build.Random(matrix.ColumnCount, 0);
for (var position = 0; position < matrix.RowCount; position++)
{
var result = matrix.RemoveRow(position);
@ -195,7 +194,6 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
[Theory]
public void CanRemoveColumn(Matrix<T> matrix)
{
var column = Vector<T>.Build.Random(matrix.RowCount, 0);
for (var position = 0; position < matrix.ColumnCount; position++)
{
var result = matrix.RemoveColumn(position);

Loading…
Cancel
Save