From 574ae448764bfc63258cf1eb918b2aea34dd8d4f Mon Sep 17 00:00:00 2001 From: Christoph Ruegg Date: Sun, 14 Apr 2013 13:15:02 +0200 Subject: [PATCH] Fix bad range check in Xor-shift pRNG --- src/Numerics/Random/Xorshift.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Numerics/Random/Xorshift.cs b/src/Numerics/Random/Xorshift.cs index 18720219..b21fbda0 100644 --- a/src/Numerics/Random/Xorshift.cs +++ b/src/Numerics/Random/Xorshift.cs @@ -27,6 +27,9 @@ // FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR // OTHER DEALINGS IN THE SOFTWARE. // + +using MathNet.Numerics.Properties; + namespace MathNet.Numerics.Random { using System; @@ -187,9 +190,9 @@ namespace MathNet.Numerics.Random seed = 1; } - if (a > c) + if (a <= c) { - throw new ArgumentException("a must be less than c", "a"); + throw new ArgumentException(string.Format(Resources.ArgumentOutOfRangeGreater, "a", "c"), "a"); } _x = (uint)seed;