From b414bc7464b7baefd605d29005a6d1d974c741f1 Mon Sep 17 00:00:00 2001 From: Evangelink Date: Tue, 30 Jun 2020 18:22:36 +0200 Subject: [PATCH 1/3] Fix thread culture for some tests Refactor code to force CultureInfo.InvariantCulture on the main thread for some tests --- .../DistributionTests/Continuous/BetaScaledTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/BetaTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/BurrTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/CauchyTests.cs | 1 + .../DistributionTests/Continuous/ChiSquareTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/ChiTests.cs | 1 + .../DistributionTests/Continuous/ContinuousUniformTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/ErlangTests.cs | 1 + .../DistributionTests/Continuous/ExponentialTests.cs | 1 + .../DistributionTests/Continuous/FisherSnedecorTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/GammaTests.cs | 1 + .../DistributionTests/Continuous/InverseGammaTests.cs | 2 ++ .../DistributionTests/Continuous/InverseGaussianTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/LaplaceTests.cs | 1 + .../DistributionTests/Continuous/LogNormalTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/NormalTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/ParetoTests.cs | 1 + .../DistributionTests/Continuous/RayleighTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/StableTests.cs | 1 + .../DistributionTests/Continuous/StudentTTests.cs | 1 + .../DistributionTests/Continuous/TriangularTests.cs | 1 + .../DistributionTests/Continuous/TruncatedParetoTests.cs | 1 + src/Numerics.Tests/DistributionTests/Continuous/WeibullTests.cs | 1 + src/Numerics.Tests/DistributionTests/Discrete/BernoulliTests.cs | 1 + src/Numerics.Tests/DistributionTests/Discrete/BinomialTests.cs | 1 + .../DistributionTests/Discrete/CategoricalTests.cs | 1 + .../DistributionTests/Discrete/ConwayMaxwellPoissonTests.cs | 1 + .../DistributionTests/Discrete/DiscreteUniformTests.cs | 1 + src/Numerics.Tests/DistributionTests/Discrete/GeometricTests.cs | 1 + .../DistributionTests/Discrete/HypergeometricTests.cs | 1 + .../DistributionTests/Discrete/NegativeBinomialTests.cs | 1 + src/Numerics.Tests/DistributionTests/Discrete/PoissonTests.cs | 1 + src/Numerics.Tests/DistributionTests/Discrete/ZipfTests.cs | 1 + .../DistributionTests/Multivariate/InverseWishartTests.cs | 1 + .../DistributionTests/Multivariate/MatrixNormalTests.cs | 1 + .../DistributionTests/Multivariate/MultinomialTests.cs | 1 + .../DistributionTests/Multivariate/WishartTests.cs | 1 + 37 files changed, 38 insertions(+) diff --git a/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs index 0503500f..289d0a2e 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs @@ -85,6 +85,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new BetaScaled(1d, 2d, 0.0, 1.0); Assert.AreEqual("BetaScaled(α = 1, β = 2, μ = 0, σ = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/BetaTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/BetaTests.cs index 580ed20d..3351107c 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/BetaTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/BetaTests.cs @@ -84,6 +84,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Beta(1d, 2d); Assert.AreEqual("Beta(α = 1, β = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/BurrTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/BurrTests.cs index d5e7baa3..39570e98 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/BurrTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/BurrTests.cs @@ -113,6 +113,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Burr(1d, 2d, 3d); Assert.AreEqual("Burr(a = 1, c = 2, k = 3)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/CauchyTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/CauchyTests.cs index 0374f84d..31d1fd00 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/CauchyTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/CauchyTests.cs @@ -89,6 +89,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Cauchy(1d, 2d); Assert.AreEqual("Cauchy(x0 = 1, γ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ChiSquareTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ChiSquareTests.cs index 625408c9..99da4158 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ChiSquareTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ChiSquareTests.cs @@ -75,6 +75,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new ChiSquared(1.0); Assert.AreEqual("ChiSquared(k = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ChiTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ChiTests.cs index 56c768d3..c834d8d2 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ChiTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ChiTests.cs @@ -73,6 +73,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Chi(1.0); Assert.AreEqual("Chi(k = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ContinuousUniformTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ContinuousUniformTests.cs index c6a96e28..269f7f94 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ContinuousUniformTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ContinuousUniformTests.cs @@ -92,6 +92,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new ContinuousUniform(1.0, 2.0); Assert.AreEqual("ContinuousUniform(Lower = 1, Upper = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ErlangTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ErlangTests.cs index 10e9b25e..1551c0dc 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ErlangTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ErlangTests.cs @@ -115,6 +115,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Erlang(1, 2d); Assert.AreEqual("Erlang(k = 1, λ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ExponentialTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ExponentialTests.cs index 2e234eac..b5423e64 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ExponentialTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ExponentialTests.cs @@ -73,6 +73,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Exponential(2d); Assert.AreEqual("Exponential(λ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/FisherSnedecorTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/FisherSnedecorTests.cs index a8a2d000..7b157ed4 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/FisherSnedecorTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/FisherSnedecorTests.cs @@ -96,6 +96,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new FisherSnedecor(2d, 1d); Assert.AreEqual("FisherSnedecor(d1 = 2, d2 = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/GammaTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/GammaTests.cs index 50a36db1..9f6bf8c4 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/GammaTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/GammaTests.cs @@ -117,6 +117,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Gamma(1d, 2d); Assert.AreEqual("Gamma(α = 1, β = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/InverseGammaTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/InverseGammaTests.cs index 10f571f2..b7fa81c6 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/InverseGammaTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/InverseGammaTests.cs @@ -28,6 +28,7 @@ // using System; +using System.Globalization; using System.Linq; using MathNet.Numerics.Distributions; using NUnit.Framework; @@ -81,6 +82,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture; var n = new InverseGamma(1.1d, 2.1d); Assert.AreEqual("InverseGamma(α = 1.1, β = 2.1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/InverseGaussianTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/InverseGaussianTests.cs index 5c13e79c..74bb186a 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/InverseGaussianTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/InverseGaussianTests.cs @@ -102,6 +102,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new InverseGaussian(1d, 2d); Assert.AreEqual("InverseGaussian(μ = 1, λ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/LaplaceTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/LaplaceTests.cs index 4f3b772c..8f06f6f1 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/LaplaceTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/LaplaceTests.cs @@ -75,6 +75,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Laplace(-1d, 2d); Assert.AreEqual("Laplace(μ = -1, b = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/LogNormalTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/LogNormalTests.cs index a50e423b..13ccb9bb 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/LogNormalTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/LogNormalTests.cs @@ -80,6 +80,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new LogNormal(1d, 2d); Assert.AreEqual("LogNormal(μ = 1, σ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/NormalTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/NormalTests.cs index 7dc44735..451451e7 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/NormalTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/NormalTests.cs @@ -145,6 +145,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Normal(1d, 2d); Assert.AreEqual("Normal(μ = 1, σ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/ParetoTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/ParetoTests.cs index 9fa1af20..ab926fa4 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/ParetoTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/ParetoTests.cs @@ -81,6 +81,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Pareto(1d, 2d); Assert.AreEqual("Pareto(xm = 1, α = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/RayleighTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/RayleighTests.cs index 098d50cb..ef296c81 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/RayleighTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/RayleighTests.cs @@ -73,6 +73,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Rayleigh(2d); Assert.AreEqual("Rayleigh(σ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/StableTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/StableTests.cs index 61d62a81..7549c902 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/StableTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/StableTests.cs @@ -97,6 +97,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Stable(1.2d, 0.3d, 1d, 2d); Assert.AreEqual("Stable(α = 1.2, β = 0.3, c = 1, μ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/StudentTTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/StudentTTests.cs index 80d258b2..846d1076 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/StudentTTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/StudentTTests.cs @@ -93,6 +93,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new StudentT(1.0, 2.0, 1.0); Assert.AreEqual("StudentT(μ = 1, σ = 2, ν = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/TriangularTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/TriangularTests.cs index a1bef3b3..65c63e50 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/TriangularTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/TriangularTests.cs @@ -88,6 +88,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Triangular(0d, 2d, 1d); Assert.AreEqual("Triangular(Lower = 0, Upper = 2, Mode = 1)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/TruncatedParetoTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/TruncatedParetoTests.cs index f5bae96a..e5ad712f 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/TruncatedParetoTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/TruncatedParetoTests.cs @@ -111,6 +111,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new TruncatedPareto(1d, 2d, 100d); Assert.AreEqual("Truncated Pareto(Scale = 1, Shape = 2, Truncation = 100)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Continuous/WeibullTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/WeibullTests.cs index 3042c00d..177cb0df 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/WeibullTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/WeibullTests.cs @@ -83,6 +83,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new Weibull(1d, 2d); Assert.AreEqual("Weibull(k = 1, λ = 2)", n.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/BernoulliTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/BernoulliTests.cs index 1aa99549..22bb00a9 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/BernoulliTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/BernoulliTests.cs @@ -71,6 +71,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var b = new Bernoulli(0.3); Assert.AreEqual("Bernoulli(p = 0.3)", b.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/BinomialTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/BinomialTests.cs index 2fe1d10d..d135fef2 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/BinomialTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/BinomialTests.cs @@ -75,6 +75,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var b = new Binomial(0.3, 2); Assert.AreEqual("Binomial(p = 0.3, n = 2)", b.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/CategoricalTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/CategoricalTests.cs index 859f7f7a..a8507e3d 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/CategoricalTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/CategoricalTests.cs @@ -134,6 +134,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var b = new Categorical(_smallP); Assert.AreEqual("Categorical(Dimension = 3)", b.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/ConwayMaxwellPoissonTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/ConwayMaxwellPoissonTests.cs index b08b9cdc..6984ada5 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/ConwayMaxwellPoissonTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/ConwayMaxwellPoissonTests.cs @@ -72,6 +72,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new ConwayMaxwellPoisson(1d, 2d); Assert.AreEqual("ConwayMaxwellPoisson(λ = 1, ν = 2)", d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/DiscreteUniformTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/DiscreteUniformTests.cs index 30a6f2b0..25d3d6ef 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/DiscreteUniformTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/DiscreteUniformTests.cs @@ -75,6 +75,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var b = new DiscreteUniform(0, 10); Assert.AreEqual("DiscreteUniform(Lower = 0, Upper = 10)", b.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/GeometricTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/GeometricTests.cs index 3acfac0c..109e974a 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/GeometricTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/GeometricTests.cs @@ -72,6 +72,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new Geometric(0.3); Assert.AreEqual("Geometric(p = 0.3)", d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/HypergeometricTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/HypergeometricTests.cs index bd2e149b..b7cfb0ca 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/HypergeometricTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/HypergeometricTests.cs @@ -82,6 +82,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new Hypergeometric(10, 1, 1); Assert.AreEqual("Hypergeometric(N = 10, M = 1, n = 1)", d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/NegativeBinomialTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/NegativeBinomialTests.cs index 7f8dc1b3..5744fb9f 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/NegativeBinomialTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/NegativeBinomialTests.cs @@ -79,6 +79,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new NegativeBinomial(1.0, 0.3); Assert.AreEqual(String.Format("NegativeBinomial(R = {0}, P = {1})", d.R, d.P), d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/PoissonTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/PoissonTests.cs index 905dbd2f..185867ab 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/PoissonTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/PoissonTests.cs @@ -71,6 +71,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new Poisson(0.3); Assert.AreEqual(String.Format("Poisson(λ = {0})", 0.3), d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Discrete/ZipfTests.cs b/src/Numerics.Tests/DistributionTests/Discrete/ZipfTests.cs index f4646e5a..f158d307 100644 --- a/src/Numerics.Tests/DistributionTests/Discrete/ZipfTests.cs +++ b/src/Numerics.Tests/DistributionTests/Discrete/ZipfTests.cs @@ -73,6 +73,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Discrete [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new Zipf(1.0, 5); Assert.AreEqual("Zipf(S = 1, N = 5)", d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Multivariate/InverseWishartTests.cs b/src/Numerics.Tests/DistributionTests/Multivariate/InverseWishartTests.cs index 70098568..7e1618b3 100644 --- a/src/Numerics.Tests/DistributionTests/Multivariate/InverseWishartTests.cs +++ b/src/Numerics.Tests/DistributionTests/Multivariate/InverseWishartTests.cs @@ -137,6 +137,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Multivariate [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new InverseWishart(1d, Matrix.Build.RandomPositiveDefinite(2, 1)); Assert.AreEqual("InverseWishart(ν = 1, Rows = 2, Columns = 2)", d.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Multivariate/MatrixNormalTests.cs b/src/Numerics.Tests/DistributionTests/Multivariate/MatrixNormalTests.cs index 942a792f..e55f4766 100644 --- a/src/Numerics.Tests/DistributionTests/Multivariate/MatrixNormalTests.cs +++ b/src/Numerics.Tests/DistributionTests/Multivariate/MatrixNormalTests.cs @@ -148,6 +148,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Multivariate [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; const int N = 2; const int P = 5; var d = new MatrixNormal(Matrix.Build.Random(N, P, 1), Matrix.Build.RandomPositiveDefinite(N, 1), Matrix.Build.RandomPositiveDefinite(P, 1)); diff --git a/src/Numerics.Tests/DistributionTests/Multivariate/MultinomialTests.cs b/src/Numerics.Tests/DistributionTests/Multivariate/MultinomialTests.cs index 33aee390..e1c8eac8 100644 --- a/src/Numerics.Tests/DistributionTests/Multivariate/MultinomialTests.cs +++ b/src/Numerics.Tests/DistributionTests/Multivariate/MultinomialTests.cs @@ -136,6 +136,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Multivariate [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var b = new Multinomial(_smallP, 4); Assert.AreEqual("Multinomial(Dimension = 3, Number of Trails = 4)", b.ToString()); } diff --git a/src/Numerics.Tests/DistributionTests/Multivariate/WishartTests.cs b/src/Numerics.Tests/DistributionTests/Multivariate/WishartTests.cs index 4c40bb99..42b56960 100644 --- a/src/Numerics.Tests/DistributionTests/Multivariate/WishartTests.cs +++ b/src/Numerics.Tests/DistributionTests/Multivariate/WishartTests.cs @@ -131,6 +131,7 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Multivariate [Test] public void ValidateToString() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var d = new Wishart(1.0, Matrix.Build.RandomPositiveDefinite(2, 1)); Assert.AreEqual("Wishart(DegreesOfFreedom = 1, Rows = 2, Columns = 2)", d.ToString()); } From 89be53093835390fa04d9b7e4e33cb823996cb2a Mon Sep 17 00:00:00 2001 From: Evangelink Date: Thu, 2 Jul 2020 12:00:36 +0200 Subject: [PATCH 2/3] Fix some more tests --- src/Numerics.Tests/LinearAlgebraTests/VectorToStringTests.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Numerics.Tests/LinearAlgebraTests/VectorToStringTests.cs b/src/Numerics.Tests/LinearAlgebraTests/VectorToStringTests.cs index f170735e..48ac70d7 100644 --- a/src/Numerics.Tests/LinearAlgebraTests/VectorToStringTests.cs +++ b/src/Numerics.Tests/LinearAlgebraTests/VectorToStringTests.cs @@ -15,6 +15,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests [Test] public void MinimumLimits() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; + Assert.That(v1.ToVectorString(3, 16, "G6"), Is.EqualTo("3.14159" + NL)); Assert.That(v2.ToVectorString(3, 16, "G6"), Is.EqualTo("3.14159" + NL + "6.28319" + NL)); Assert.That(v100.ToVectorString(3, 16, "G6"), Is.EqualTo("3.14159" + NL + " .." + NL + "314.159" + NL)); @@ -23,6 +25,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests [Test] public void GitHubIssue387() { + System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; + Vector v = Vector.Build.DenseOfArray(new[] { 0.607142857142857, From 544d7b08b3ee0fe3623633555e350bfb3077dd01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amaury=20Lev=C3=A9?= Date: Mon, 6 Jul 2020 22:48:04 +0200 Subject: [PATCH 3/3] Revert un-needed change --- .../DistributionTests/Continuous/BetaScaledTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs b/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs index 289d0a2e..0503500f 100644 --- a/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs +++ b/src/Numerics.Tests/DistributionTests/Continuous/BetaScaledTests.cs @@ -85,7 +85,6 @@ namespace MathNet.Numerics.UnitTests.DistributionTests.Continuous [Test] public void ValidateToString() { - System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture; var n = new BetaScaled(1d, 2d, 0.0, 1.0); Assert.AreEqual("BetaScaled(α = 1, β = 2, μ = 0, σ = 1)", n.ToString()); }