From 176427229cef92a3dfd8d4ae4a6290b2a4cba3c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Chalet?= Date: Wed, 2 Dec 2020 02:58:04 +0100 Subject: [PATCH] Reword the ID0096/ID0097 exception messages --- src/OpenIddict.Abstractions/OpenIddictResources.resx | 4 ++-- .../OpenIddictServerAspNetCoreHandlers.Authentication.cs | 2 +- .../OpenIddictServerAspNetCoreHandlers.Session.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/OpenIddict.Abstractions/OpenIddictResources.resx b/src/OpenIddict.Abstractions/OpenIddictResources.resx index 4518f130..8f1b2d43 100644 --- a/src/OpenIddict.Abstractions/OpenIddictResources.resx +++ b/src/OpenIddict.Abstractions/OpenIddictResources.resx @@ -444,10 +444,10 @@ To use key rollover, register both the new certificate and the old one in the cr No custom verification request validation handler was found. When enabling the degraded mode, a custom 'IOpenIddictServerHandler<ValidateVerificationRequestContext>' must be implemented to validate verification requests (e.g to ensure the user_code is valid). - No custom verification authentication handler was found. When enabling the degraded mode, a custom 'IOpenIddictServerHandler<ProcessAuthenticationContext>' must be implemented to validate device and user codes (e.g by retrieving them from a database). + No custom verification authentication handler was found. When enabling the degraded mode, a custom 'IOpenIddictServerHandler<ProcessAuthenticationContext>' must be implemented to handle device and user codes (e.g by retrieving them from a database). - No custom verification sign-in handler was found. When enabling the degraded mode, a custom 'IOpenIddictServerHandler<ProcessSignInContext>' must be implemented to generate device and user codes and storing them in a database, if applicable. + No custom verification sign-in handler was found. When enabling the degraded mode, a custom 'IOpenIddictServerHandler<ProcessSignInContext>' must be implemented to handle device and user codes and store them in a database, if applicable. The event handler of type '{0}' couldn't be resolved. diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs index b6a6bfce..994589f8 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs @@ -452,7 +452,7 @@ namespace OpenIddict.Server.AspNetCore var location = QueryHelpers.AddQueryString(context.RedirectUri, from parameter in context.Response.GetParameters() let values = (string?[]?) parameter.Value - where values != null + where values is not null from value in values where !string.IsNullOrEmpty(value) select KeyValuePair.Create(parameter.Key, value)); diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs index 57ac7bf8..98f340e8 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs @@ -354,7 +354,7 @@ namespace OpenIddict.Server.AspNetCore var location = QueryHelpers.AddQueryString(context.PostLogoutRedirectUri, from parameter in context.Response.GetParameters() let values = (string?[]?) parameter.Value - where values != null + where values is not null from value in values where !string.IsNullOrEmpty(value) select KeyValuePair.Create(parameter.Key, value));