Remove /p:DotNetPublishUsingPipelines=true to ensure SourceLink works correctly

.github/workflows/build.yml

@@ -46,16 +46,15 @@ jobs:
         $QuarterHours = [Math]::Floor($Now.Minute / 15.0)
         $Revision = $Hours + $QuarterHours + 1
         $BuildId = $Now.ToString("yyyyMMdd") + "." + $Revision
-        Write-Host "::set-env name=OfficialBuild::true"
-        Write-Host "::set-env name=OfficialBuildId::${BuildId}"
+        Write-Host "::set-env name=_ComputedOfficialBuildId::${BuildId}"
 
     - name: Build, test and pack
-      run: eng\common\CIBuild.cmd -configuration Release -prepareMachine -integrationTest /p:DotNetPublishUsingPipelines=true
+      run: eng\common\CIBuild.cmd -configuration Release -prepareMachine -integrationTest
       if: ${{ runner.os == 'Windows' }}
 
     - name: Build, test and pack
       shell: pwsh
-      run: ./eng/common/cibuild.sh -configuration Release -prepareMachine -integrationTest /p:DotNetPublishUsingPipelines=true
+      run: ./eng/common/cibuild.sh -configuration Release -prepareMachine -integrationTest
       if: ${{ runner.os != 'Windows' }}
 
     - name: Publish logs

Directory.Build.props

@@ -39,6 +39,15 @@
     <WarnOnPackingNonPackableProject>false</WarnOnPackingNonPackableProject>
   </PropertyGroup>
 
+  <!--
+    These are set per-project so versioning is applied correctly, but are not set globally otherwise
+    the Arcade SDK will attempt to publish artifacts such as symbols to Microsoft's servers.
+  -->
+  <PropertyGroup Condition=" '$(GITHUB_ACTIONS)' == 'true' And '$(GITHUB_REF.StartsWith(`refs/pull/`))' == 'false' ">
+    <OfficialBuild>true</OfficialBuild>
+    <OfficialBuildId>$(_ComputedOfficialBuildId)</OfficialBuildId>
+  </PropertyGroup>
+
   <PropertyGroup Condition=" $(RepoRelativeProjectDir.Contains('src')) ">
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IncludeSource>true</IncludeSource>