diff --git a/shared/OpenIddict.Extensions/Helpers/OpenIddictHelpers.cs b/shared/OpenIddict.Extensions/Helpers/OpenIddictHelpers.cs index 45ea2888..0d3444e8 100644 --- a/shared/OpenIddict.Extensions/Helpers/OpenIddictHelpers.cs +++ b/shared/OpenIddict.Extensions/Helpers/OpenIddictHelpers.cs @@ -10,7 +10,7 @@ internal static class OpenIddictHelpers /// /// The type to introspect. /// The generic type definition. - /// A instance if the base type was found, null otherwise. + /// A instance if the base type was found, otherwise. public static Type? FindGenericBaseType(Type type, Type definition) => FindGenericBaseTypes(type, definition).FirstOrDefault(); @@ -19,7 +19,7 @@ internal static class OpenIddictHelpers /// /// The type to introspect. /// The generic type definition. - /// A instance if the base type was found, null otherwise. + /// A instance if the base type was found, otherwise. public static IEnumerable FindGenericBaseTypes(Type type!!, Type definition!!) { if (!definition.IsGenericTypeDefinition) diff --git a/src/OpenIddict.Abstractions/Managers/IOpenIddictApplicationManager.cs b/src/OpenIddict.Abstractions/Managers/IOpenIddictApplicationManager.cs index 3e34f989..1de4fc67 100644 --- a/src/OpenIddict.Abstractions/Managers/IOpenIddictApplicationManager.cs +++ b/src/OpenIddict.Abstractions/Managers/IOpenIddictApplicationManager.cs @@ -310,7 +310,7 @@ public interface IOpenIddictApplicationManager /// The application. /// The expected client type. /// The that can be used to abort the operation. - /// true if the application has the specified client type, false otherwise. + /// if the application has the specified client type, otherwise. ValueTask HasClientTypeAsync(object application, string type, CancellationToken cancellationToken = default); /// @@ -319,7 +319,7 @@ public interface IOpenIddictApplicationManager /// The application. /// The expected consent type. /// The that can be used to abort the operation. - /// true if the application has the specified consent type, false otherwise. + /// if the application has the specified consent type, otherwise. ValueTask HasConsentTypeAsync(object application, string type, CancellationToken cancellationToken = default); /// @@ -328,7 +328,7 @@ public interface IOpenIddictApplicationManager /// The application. /// The permission. /// The that can be used to abort the operation. - /// true if the application has been granted the specified permission, false otherwise. + /// if the application has been granted the specified permission, otherwise. ValueTask HasPermissionAsync(object application, string permission, CancellationToken cancellationToken = default); /// @@ -337,7 +337,7 @@ public interface IOpenIddictApplicationManager /// The application. /// The requirement. /// The that can be used to abort the operation. - /// true if the requirement has been enforced for the specified application, false otherwise. + /// if the requirement has been enforced for the specified application, otherwise. ValueTask HasRequirementAsync(object application, string requirement, CancellationToken cancellationToken = default); /// diff --git a/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs b/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs index 92513bb5..2c64f2bb 100644 --- a/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs +++ b/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs @@ -289,7 +289,7 @@ public interface IOpenIddictAuthorizationManager /// The authorization. /// The scopes. /// The that can be used to abort the operation. - /// true if the scopes are included in the authorization, false otherwise. + /// if the scopes are included in the authorization, otherwise. ValueTask HasScopesAsync(object authorization, ImmutableArray scopes, CancellationToken cancellationToken = default); /// @@ -298,7 +298,7 @@ public interface IOpenIddictAuthorizationManager /// The authorization. /// The expected status. /// The that can be used to abort the operation. - /// true if the authorization has the specified status, false otherwise. + /// if the authorization has the specified status, otherwise. ValueTask HasStatusAsync(object authorization, string status, CancellationToken cancellationToken = default); /// @@ -307,7 +307,7 @@ public interface IOpenIddictAuthorizationManager /// The authorization. /// The expected type. /// The that can be used to abort the operation. - /// true if the authorization has the specified type, false otherwise. + /// if the authorization has the specified type, otherwise. ValueTask HasTypeAsync(object authorization, string type, CancellationToken cancellationToken = default); /// @@ -385,7 +385,7 @@ public interface IOpenIddictAuthorizationManager /// /// The authorization to revoke. /// The that can be used to abort the operation. - /// true if the authorization was successfully revoked, false otherwise. + /// if the authorization was successfully revoked, otherwise. ValueTask TryRevokeAsync(object authorization, CancellationToken cancellationToken = default); /// diff --git a/src/OpenIddict.Abstractions/Managers/IOpenIddictTokenManager.cs b/src/OpenIddict.Abstractions/Managers/IOpenIddictTokenManager.cs index fefe740e..af039c7e 100644 --- a/src/OpenIddict.Abstractions/Managers/IOpenIddictTokenManager.cs +++ b/src/OpenIddict.Abstractions/Managers/IOpenIddictTokenManager.cs @@ -324,7 +324,7 @@ public interface IOpenIddictTokenManager /// The token. /// The expected status. /// The that can be used to abort the operation. - /// true if the token has the specified status, false otherwise. + /// if the token has the specified status, otherwise. ValueTask HasStatusAsync(object token, string status, CancellationToken cancellationToken = default); /// @@ -333,7 +333,7 @@ public interface IOpenIddictTokenManager /// The token. /// The expected type. /// The that can be used to abort the operation. - /// true if the token has the specified type, false otherwise. + /// if the token has the specified type, otherwise. ValueTask HasTypeAsync(object token, string type, CancellationToken cancellationToken = default); /// @@ -342,7 +342,7 @@ public interface IOpenIddictTokenManager /// The token. /// The expected types. /// The that can be used to abort the operation. - /// true if the token has any of the specified types, false otherwise. + /// if the token has any of the specified types, otherwise. ValueTask HasTypeAsync(object token, ImmutableArray types, CancellationToken cancellationToken = default); /// @@ -416,7 +416,7 @@ public interface IOpenIddictTokenManager /// /// The token to redeem. /// The that can be used to abort the operation. - /// true if the token was successfully redemeed, false otherwise. + /// if the token was successfully redemeed, otherwise. ValueTask TryRedeemAsync(object token, CancellationToken cancellationToken = default); /// @@ -424,7 +424,7 @@ public interface IOpenIddictTokenManager /// /// The token to reject. /// The that can be used to abort the operation. - /// true if the token was successfully redemeed, false otherwise. + /// if the token was successfully redemeed, otherwise. ValueTask TryRejectAsync(object token, CancellationToken cancellationToken = default); /// @@ -432,7 +432,7 @@ public interface IOpenIddictTokenManager /// /// The token to revoke. /// The that can be used to abort the operation. - /// true if the token was successfully revoked, false otherwise. + /// if the token was successfully revoked, otherwise. ValueTask TryRevokeAsync(object token, CancellationToken cancellationToken = default); /// diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictConverter.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictConverter.cs index 7a711d9f..de673f10 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictConverter.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictConverter.cs @@ -18,7 +18,7 @@ public class OpenIddictConverter : JsonConverter /// Determines whether the specified type is supported by this converter. /// /// The type to convert. - /// true if the type is supported, false otherwise. + /// if the type is supported, otherwise. public override bool CanConvert(Type typeToConvert!!) { return typeToConvert == typeof(OpenIddictMessage) || diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictExtensions.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictExtensions.cs index d82b59a6..28984294 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictExtensions.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictExtensions.cs @@ -114,7 +114,7 @@ public static class OpenIddictExtensions /// See http://openid.net/specs/oauth-v2-multiple-response-types-1_0.html#none for more information. /// /// The instance. - /// true if the request is a response_type=none request, false otherwise. + /// if the request is a response_type=none request, otherwise. public static bool IsNoneFlow(this OpenIddictRequest request!!) { if (string.IsNullOrEmpty(request.ResponseType)) @@ -136,7 +136,7 @@ public static class OpenIddictExtensions /// See http://tools.ietf.org/html/rfc6749#section-4.1.1 for more information. /// /// The instance. - /// true if the request is a code flow request, false otherwise. + /// if the request is a code flow request, otherwise. public static bool IsAuthorizationCodeFlow(this OpenIddictRequest request!!) { if (string.IsNullOrEmpty(request.ResponseType)) @@ -159,7 +159,7 @@ public static class OpenIddictExtensions /// http://openid.net/specs/openid-connect-core-1_0.html for more information /// /// The instance. - /// true if the request is an implicit flow request, false otherwise. + /// if the request is an implicit flow request, otherwise. public static bool IsImplicitFlow(this OpenIddictRequest request!!) { if (string.IsNullOrEmpty(request.ResponseType)) @@ -208,7 +208,7 @@ public static class OpenIddictExtensions /// http://openid.net/specs/openid-connect-core-1_0.html for more information. /// /// The instance. - /// true if the request is an hybrid flow request, false otherwise. + /// if the request is an hybrid flow request, otherwise. public static bool IsHybridFlow(this OpenIddictRequest request!!) { if (string.IsNullOrEmpty(request.ResponseType)) @@ -268,8 +268,8 @@ public static class OpenIddictExtensions /// /// The instance. /// - /// true if the request specified the fragment response mode or if - /// it's the default value for the requested flow, false otherwise. + /// if the request specified the fragment response mode or if + /// it's the default value for the requested flow, otherwise. /// public static bool IsFragmentResponseMode(this OpenIddictRequest request!!) { @@ -296,8 +296,8 @@ public static class OpenIddictExtensions /// /// The instance. /// - /// true if the request specified the query response mode or if - /// it's the default value for the requested flow, false otherwise. + /// if the request specified the query response mode or if + /// it's the default value for the requested flow, otherwise. /// public static bool IsQueryResponseMode(this OpenIddictRequest request!!) { @@ -323,8 +323,8 @@ public static class OpenIddictExtensions /// /// The instance. /// - /// true if the request specified the form post response mode or if - /// it's the default value for the requested flow, false otherwise. + /// if the request specified the form post response mode or if + /// it's the default value for the requested flow, otherwise. /// public static bool IsFormPostResponseMode(this OpenIddictRequest request!!) => string.Equals(request.ResponseMode, ResponseModes.FormPost, StringComparison.Ordinal); @@ -334,7 +334,7 @@ public static class OpenIddictExtensions /// See http://tools.ietf.org/html/rfc6749#section-4.1.3 for more information. /// /// The instance. - /// true if the request is a code grant request, false otherwise. + /// if the request is a code grant request, otherwise. public static bool IsAuthorizationCodeGrantType(this OpenIddictRequest request!!) => string.Equals(request.GrantType, GrantTypes.AuthorizationCode, StringComparison.Ordinal); @@ -343,7 +343,7 @@ public static class OpenIddictExtensions /// See http://tools.ietf.org/html/rfc6749#section-4.4.2 for more information. /// /// The instance. - /// true if the request is a client credentials grant request, false otherwise. + /// if the request is a client credentials grant request, otherwise. public static bool IsClientCredentialsGrantType(this OpenIddictRequest request!!) => string.Equals(request.GrantType, GrantTypes.ClientCredentials, StringComparison.Ordinal); @@ -352,7 +352,7 @@ public static class OpenIddictExtensions /// See https://tools.ietf.org/html/rfc8628 for more information. /// /// The instance. - /// true if the request is a device code grant request, false otherwise. + /// if the request is a device code grant request, otherwise. public static bool IsDeviceCodeGrantType(this OpenIddictRequest request!!) => string.Equals(request.GrantType, GrantTypes.DeviceCode, StringComparison.Ordinal); @@ -361,7 +361,7 @@ public static class OpenIddictExtensions /// See http://tools.ietf.org/html/rfc6749#section-4.3.2 for more information. /// /// The instance. - /// true if the request is a password grant request, false otherwise. + /// if the request is a password grant request, otherwise. public static bool IsPasswordGrantType(this OpenIddictRequest request!!) => string.Equals(request.GrantType, GrantTypes.Password, StringComparison.Ordinal); @@ -370,7 +370,7 @@ public static class OpenIddictExtensions /// See http://tools.ietf.org/html/rfc6749#section-6 for more information. /// /// The instance. - /// true if the request is a refresh token grant request, false otherwise. + /// if the request is a refresh token grant request, otherwise. public static bool IsRefreshTokenGrantType(this OpenIddictRequest request!!) => string.Equals(request.GrantType, GrantTypes.RefreshToken, StringComparison.Ordinal); @@ -551,8 +551,8 @@ public static class OpenIddictExtensions /// /// The instance to filter. /// - /// The delegate filtering the claims: return true - /// to accept the claim, false to remove it. + /// The delegate filtering the claims: return + /// to accept the claim, to remove it. /// public static ClaimsIdentity Clone(this ClaimsIdentity identity!!, Func filter!!) { @@ -581,8 +581,8 @@ public static class OpenIddictExtensions /// /// The instance to filter. /// - /// The delegate filtering the claims: return true - /// to accept the claim, false to remove it. + /// The delegate filtering the claims: return + /// to accept the claim, to remove it. /// public static ClaimsPrincipal Clone(this ClaimsPrincipal principal!!, Func filter!!) { @@ -704,7 +704,7 @@ public static class OpenIddictExtensions /// /// The claims identity. /// The claim type. - /// true if the identity contains at least one claim of the specified type. + /// if the identity contains at least one claim of the specified type. public static bool HasClaim(this ClaimsIdentity identity!!, string type) { if (string.IsNullOrEmpty(type)) @@ -736,7 +736,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The claim type. - /// true if the principal contains at least one claim of the specified type. + /// if the principal contains at least one claim of the specified type. public static bool HasClaim(this ClaimsPrincipal principal!!, string type) { if (string.IsNullOrEmpty(type)) @@ -902,7 +902,7 @@ public static class OpenIddictExtensions /// Gets the creation date stored in the claims principal. /// /// The claims principal. - /// The creation date or null if the claim cannot be found. + /// The creation date or if the claim cannot be found. public static DateTimeOffset? GetCreationDate(this ClaimsPrincipal principal!!) { var claim = principal.FindFirst(Claims.Private.CreationDate); @@ -923,7 +923,7 @@ public static class OpenIddictExtensions /// Gets the expiration date stored in the claims principal. /// /// The claims principal. - /// The expiration date or null if the claim cannot be found. + /// The expiration date or if the claim cannot be found. public static DateTimeOffset? GetExpirationDate(this ClaimsPrincipal principal!!) { var claim = principal.FindFirst(Claims.Private.ExpirationDate); @@ -976,7 +976,7 @@ public static class OpenIddictExtensions /// Gets the access token lifetime associated with the claims principal. /// /// The claims principal. - /// The access token lifetime or null if the claim cannot be found. + /// The access token lifetime or if the claim cannot be found. public static TimeSpan? GetAccessTokenLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.AccessTokenLifetime); @@ -984,7 +984,7 @@ public static class OpenIddictExtensions /// Gets the authorization code lifetime associated with the claims principal. /// /// The claims principal. - /// The authorization code lifetime or null if the claim cannot be found. + /// The authorization code lifetime or if the claim cannot be found. public static TimeSpan? GetAuthorizationCodeLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.AuthorizationCodeLifetime); @@ -992,7 +992,7 @@ public static class OpenIddictExtensions /// Gets the device code lifetime associated with the claims principal. /// /// The claims principal. - /// The device code lifetime or null if the claim cannot be found. + /// The device code lifetime or if the claim cannot be found. public static TimeSpan? GetDeviceCodeLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.DeviceCodeLifetime); @@ -1000,7 +1000,7 @@ public static class OpenIddictExtensions /// Gets the identity token lifetime associated with the claims principal. /// /// The claims principal. - /// The identity token lifetime or null if the claim cannot be found. + /// The identity token lifetime or if the claim cannot be found. public static TimeSpan? GetIdentityTokenLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.IdentityTokenLifetime); @@ -1008,7 +1008,7 @@ public static class OpenIddictExtensions /// Gets the refresh token lifetime associated with the claims principal. /// /// The claims principal. - /// The refresh token lifetime or null if the claim cannot be found. + /// The refresh token lifetime or if the claim cannot be found. public static TimeSpan? GetRefreshTokenLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.RefreshTokenLifetime); @@ -1016,7 +1016,7 @@ public static class OpenIddictExtensions /// Gets the state token lifetime associated with the claims principal. /// /// The claims principal. - /// The state token lifetime or null if the claim cannot be found. + /// The state token lifetime or if the claim cannot be found. public static TimeSpan? GetStateTokenLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.StateTokenLifetime); @@ -1024,7 +1024,7 @@ public static class OpenIddictExtensions /// Gets the user code lifetime associated with the claims principal. /// /// The claims principal. - /// The user code lifetime or null if the claim cannot be found. + /// The user code lifetime or if the claim cannot be found. public static TimeSpan? GetUserCodeLifetime(this ClaimsPrincipal principal) => GetLifetime(principal, Claims.Private.UserCodeLifetime); @@ -1032,7 +1032,7 @@ public static class OpenIddictExtensions /// Gets the internal authorization identifier associated with the claims principal. /// /// The claims principal. - /// The unique identifier or null if the claim cannot be found. + /// The unique identifier or if the claim cannot be found. public static string? GetAuthorizationId(this ClaimsPrincipal principal) => principal.GetClaim(Claims.Private.AuthorizationId); @@ -1040,7 +1040,7 @@ public static class OpenIddictExtensions /// Gets the internal token identifier associated with the claims principal. /// /// The claims principal. - /// The unique identifier or null if the claim cannot be found. + /// The unique identifier or if the claim cannot be found. public static string? GetTokenId(this ClaimsPrincipal principal) => principal.GetClaim(Claims.Private.TokenId); @@ -1048,7 +1048,7 @@ public static class OpenIddictExtensions /// Gets the token type associated with the claims principal. /// /// The claims principal. - /// The token type or null if the claim cannot be found. + /// The token type or if the claim cannot be found. public static string? GetTokenType(this ClaimsPrincipal principal) => principal.GetClaim(Claims.Private.TokenType); @@ -1057,7 +1057,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The audience. - /// true if the principal contains the given audience. + /// if the principal contains the given audience. public static bool HasAudience(this ClaimsPrincipal principal!!, string audience) { if (string.IsNullOrEmpty(audience)) @@ -1073,7 +1073,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The presenter. - /// true if the principal contains the given presenter. + /// if the principal contains the given presenter. public static bool HasPresenter(this ClaimsPrincipal principal!!, string presenter) { if (string.IsNullOrEmpty(presenter)) @@ -1089,7 +1089,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The resource. - /// true if the principal contains the given resource. + /// if the principal contains the given resource. public static bool HasResource(this ClaimsPrincipal principal!!, string resource) { if (string.IsNullOrEmpty(resource)) @@ -1105,7 +1105,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The scope. - /// true if the principal contains the given scope. + /// if the principal contains the given scope. public static bool HasScope(this ClaimsPrincipal principal!!, string scope) { if (string.IsNullOrEmpty(scope)) @@ -1121,7 +1121,7 @@ public static class OpenIddictExtensions /// /// The claims principal. /// The token type. - /// true if the token type matches the specified type. + /// if the token type matches the specified type. public static bool HasTokenType(this ClaimsPrincipal principal!!, string type) { if (string.IsNullOrEmpty(type)) diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs index b2746aa8..efe548a9 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs @@ -218,7 +218,7 @@ public class OpenIddictMessage /// Gets the value corresponding to a given parameter. /// /// The parameter name. - /// The parameter value, or null if it cannot be found. + /// The parameter value, or if it cannot be found. public OpenIddictParameter? GetParameter(string name) { if (string.IsNullOrEmpty(name)) @@ -245,7 +245,7 @@ public class OpenIddictMessage /// Determines whether the current message contains the specified parameter. /// /// The parameter name. - /// true if the parameter is present, false otherwise. + /// if the parameter is present, otherwise. public bool HasParameter(string name) { if (string.IsNullOrEmpty(name)) @@ -306,7 +306,7 @@ public class OpenIddictMessage /// /// The parameter name. /// The parameter value. - /// true if the parameter could be found, false otherwise. + /// if the parameter could be found, otherwise. public bool TryGetParameter(string name, out OpenIddictParameter value) { if (string.IsNullOrEmpty(name)) diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs index b62c4e9b..95fb938b 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs @@ -76,8 +76,8 @@ public readonly struct OpenIddictParameter : IEquatable public OpenIddictParameter? this[string name] => GetNamedParameter(name); /// - /// Gets the number of unnamed child items contained in the current parameter or - /// 0 if the parameter doesn't represent an array of strings or a JSON array. + /// Gets the number of unnamed child items contained in the current parameter + /// or 0 if the parameter doesn't represent an array of strings or a JSON array. /// public int Count => Value switch { @@ -103,7 +103,7 @@ public readonly struct OpenIddictParameter : IEquatable /// instance is equal to the specified . /// /// The other object to which to compare this instance. - /// true if the two instances are equal, false otherwise. + /// if the two instances are equal, otherwise. public bool Equals(OpenIddictParameter other) { return (left: Value, right: other.Value) switch @@ -214,7 +214,7 @@ public readonly struct OpenIddictParameter : IEquatable /// instance is equal to the specified . /// /// The other object to which to compare this instance. - /// true if the two instances are equal, false otherwise. + /// if the two instances are equal, otherwise. public override bool Equals(object? obj) => obj is OpenIddictParameter parameter && Equals(parameter); /// @@ -431,7 +431,7 @@ public readonly struct OpenIddictParameter : IEquatable /// /// The name of the child item. /// An instance containing the item value. - /// true if the parameter could be found, false otherwise. + /// if the parameter could be found, otherwise. public bool TryGetNamedParameter(string name, out OpenIddictParameter value) { if (string.IsNullOrEmpty(name)) @@ -457,7 +457,7 @@ public readonly struct OpenIddictParameter : IEquatable /// /// The index of the child item. /// An instance containing the item value. - /// true if the parameter could be found, false otherwise. + /// if the parameter could be found, otherwise. public bool TryGetUnnamedParameter(int index, out OpenIddictParameter value) { if (index < 0) @@ -548,7 +548,7 @@ public readonly struct OpenIddictParameter : IEquatable /// /// The first instance. /// The second instance. - /// true if the two instances are equal, false otherwise. + /// if the two instances are equal, otherwise. public static bool operator ==(OpenIddictParameter left, OpenIddictParameter right) => left.Equals(right); /// @@ -556,7 +556,7 @@ public readonly struct OpenIddictParameter : IEquatable /// /// The first instance. /// The second instance. - /// true if the two instances are not equal, false otherwise. + /// if the two instances are not equal, otherwise. public static bool operator !=(OpenIddictParameter left, OpenIddictParameter right) => !left.Equals(right); /// @@ -863,7 +863,7 @@ public readonly struct OpenIddictParameter : IEquatable /// Determines whether a parameter is null or empty. /// /// The parameter. - /// true if the parameter is null or empty, false otherwise. + /// if the parameter is null or empty, otherwise. public static bool IsNullOrEmpty(OpenIddictParameter parameter) { return parameter.Value switch diff --git a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreBuilder.cs b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreBuilder.cs index fd2c8879..4c6efa0f 100644 --- a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreBuilder.cs +++ b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreBuilder.cs @@ -78,7 +78,7 @@ public class OpenIddictClientAspNetCoreBuilder /// Determines whether the specified object is equal to the current object. /// /// The object to compare with the current object. - /// true if the specified object is equal to the current object; otherwise, false. + /// if the specified object is equal to the current object; otherwise, false. [EditorBrowsable(EditorBrowsableState.Never)] public override bool Equals(object? obj) => base.Equals(obj); diff --git a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHelpers.cs b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHelpers.cs index 72a617c4..3d2ddf34 100644 --- a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHelpers.cs +++ b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHelpers.cs @@ -18,7 +18,7 @@ public static class OpenIddictClientAspNetCoreHelpers /// Retrieves the instance stored in the properties. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpRequest? GetHttpRequest(this OpenIddictClientTransaction transaction!!) { if (!transaction.Properties.TryGetValue(typeof(HttpRequest).FullName!, out object? property)) @@ -48,7 +48,7 @@ public static class OpenIddictClientAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictRequest? GetOpenIddictClientRequest(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Request; @@ -58,7 +58,7 @@ public static class OpenIddictClientAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictResponse? GetOpenIddictClientResponse(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Response; diff --git a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpBuilder.cs b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpBuilder.cs index 55fb6756..cdf2c6ec 100644 --- a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpBuilder.cs +++ b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpBuilder.cs @@ -53,7 +53,7 @@ public class OpenIddictClientSystemNetHttpBuilder /// Determines whether the specified object is equal to the current object. /// /// The object to compare with the current object. - /// true if the specified object is equal to the current object; otherwise, false. + /// if the specified object is equal to the current object; otherwise, false. [EditorBrowsable(EditorBrowsableState.Never)] public override bool Equals(object? obj) => base.Equals(obj); diff --git a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHelpers.cs b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHelpers.cs index 9b290cc7..37fcace9 100644 --- a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHelpers.cs +++ b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHelpers.cs @@ -17,7 +17,7 @@ public static class OpenIddictClientSystemNetHttpHelpers /// Gets the associated with the current context. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpRequestMessage? GetHttpRequestMessage(this OpenIddictClientTransaction transaction) => transaction.GetProperty(typeof(HttpRequestMessage).FullName!); @@ -25,7 +25,7 @@ public static class OpenIddictClientSystemNetHttpHelpers /// Gets the associated with the current context. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpResponseMessage? GetHttpResponseMessage(this OpenIddictClientTransaction transaction) => transaction.GetProperty(typeof(HttpResponseMessage).FullName!); } diff --git a/src/OpenIddict.Client/OpenIddictClientBuilder.cs b/src/OpenIddict.Client/OpenIddictClientBuilder.cs index fd1edf1e..90b2e7ec 100644 --- a/src/OpenIddict.Client/OpenIddictClientBuilder.cs +++ b/src/OpenIddict.Client/OpenIddictClientBuilder.cs @@ -122,7 +122,7 @@ public class OpenIddictClientBuilder { // If the encryption key is an asymmetric security key, ensure it has a private key. if (key is AsymmetricSecurityKey asymmetricSecurityKey && - asymmetricSecurityKey.PrivateKeyStatus == PrivateKeyStatus.DoesNotExist) + asymmetricSecurityKey.PrivateKeyStatus is PrivateKeyStatus.DoesNotExist) { throw new InvalidOperationException(SR.GetResourceString(SR.ID0055)); } @@ -482,7 +482,7 @@ public class OpenIddictClientBuilder { // If the signing key is an asymmetric security key, ensure it has a private key. if (key is AsymmetricSecurityKey asymmetricSecurityKey && - asymmetricSecurityKey.PrivateKeyStatus == PrivateKeyStatus.DoesNotExist) + asymmetricSecurityKey.PrivateKeyStatus is PrivateKeyStatus.DoesNotExist) { throw new InvalidOperationException(SR.GetResourceString(SR.ID0067)); } @@ -909,7 +909,7 @@ public class OpenIddictClientBuilder /// Sets the state token lifetime, after which authorization callbacks /// using an expired state token will be automatically rejected by OpenIddict. /// Using long-lived state tokens or tokens that never expire is not recommended. - /// While discouraged, null can be specified to issue tokens that never expire. + /// While discouraged, can be specified to issue tokens that never expire. /// /// The access token lifetime. /// The . @@ -920,7 +920,7 @@ public class OpenIddictClientBuilder /// Determines whether the specified object is equal to the current object. /// /// The object to compare with the current object. - /// true if the specified object is equal to the current object; otherwise, false. + /// if the specified object is equal to the current object; otherwise, false. [EditorBrowsable(EditorBrowsableState.Never)] public override bool Equals(object? obj) => base.Equals(obj); diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.Authentication.cs b/src/OpenIddict.Client/OpenIddictClientEvents.Authentication.cs index 7ebf4a75..1bdc7e76 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.Authentication.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.Authentication.cs @@ -80,7 +80,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the request or null if it was extracted yet. + /// Gets or sets the request or if it was extracted yet. /// public OpenIddictRequest? Request { @@ -170,7 +170,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.Discovery.cs b/src/OpenIddict.Client/OpenIddictClientEvents.Discovery.cs index 17ba49d9..f652f3b3 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.Discovery.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.Discovery.cs @@ -82,7 +82,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { @@ -200,7 +200,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.Exchange.cs b/src/OpenIddict.Client/OpenIddictClientEvents.Exchange.cs index 394a802f..0e7982bf 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.Exchange.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.Exchange.cs @@ -92,7 +92,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.Protection.cs b/src/OpenIddict.Client/OpenIddictClientEvents.Protection.cs index 154c269f..7b742f5a 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.Protection.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.Protection.cs @@ -26,7 +26,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the request, or null if it is not available. + /// Gets or sets the request, or if it is not available. /// public OpenIddictRequest? Request { @@ -79,7 +79,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the request, or null if it is not available. + /// Gets or sets the request, or if it is not available. /// public OpenIddictRequest? Request { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.Userinfo.cs b/src/OpenIddict.Client/OpenIddictClientEvents.Userinfo.cs index b16cf7cb..86a9199a 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.Userinfo.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.Userinfo.cs @@ -82,7 +82,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.cs b/src/OpenIddict.Client/OpenIddictClientEvents.cs index 5ebf9f69..29d45182 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.cs @@ -224,7 +224,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -709,7 +709,7 @@ public static partial class OpenIddictClientEvents /// /// Gets or sets the generated state token, if applicable. /// The access token will only be returned if - /// is set to true. + /// is set to . /// public string? StateToken { get; set; } diff --git a/src/OpenIddict.Client/OpenIddictClientHelpers.cs b/src/OpenIddict.Client/OpenIddictClientHelpers.cs index 574c13cb..5e016aba 100644 --- a/src/OpenIddict.Client/OpenIddictClientHelpers.cs +++ b/src/OpenIddict.Client/OpenIddictClientHelpers.cs @@ -17,7 +17,7 @@ public static class OpenIddictClientHelpers /// The type of the property. /// The client transaction. /// The property name. - /// The property value or null if it couldn't be found. + /// The property value or if it couldn't be found. public static TProperty? GetProperty( this OpenIddictClientTransaction transaction!!, string name) where TProperty : class { diff --git a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs index 39546df5..32809641 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs @@ -535,7 +535,7 @@ public class OpenIddictApplicationManager : IOpenIddictApplication TApplication application!!, CultureInfo culture!!, CancellationToken cancellationToken = default) { var names = await Store.GetDisplayNamesAsync(application, cancellationToken); - if (names is not { IsEmpty: false }) + if (names is not { Count: > 0 }) { return await Store.GetDisplayNameAsync(application, cancellationToken); } @@ -626,7 +626,7 @@ public class OpenIddictApplicationManager : IOpenIddictApplication /// The application. /// The expected client type. /// The that can be used to abort the operation. - /// true if the application has the specified client type, false otherwise. + /// if the application has the specified client type, otherwise. public virtual async ValueTask HasClientTypeAsync( TApplication application!!, string type, CancellationToken cancellationToken = default) { @@ -644,7 +644,7 @@ public class OpenIddictApplicationManager : IOpenIddictApplication /// The application. /// The expected consent type. /// The that can be used to abort the operation. - /// true if the application has the specified consent type, false otherwise. + /// if the application has the specified consent type, otherwise. public virtual async ValueTask HasConsentTypeAsync( TApplication application!!, string type, CancellationToken cancellationToken = default) { @@ -662,7 +662,7 @@ public class OpenIddictApplicationManager : IOpenIddictApplication /// The application. /// The permission. /// The that can be used to abort the operation. - /// true if the application has been granted the specified permission, false otherwise. + /// if the application has been granted the specified permission, otherwise. public virtual async ValueTask HasPermissionAsync( TApplication application!!, string permission, CancellationToken cancellationToken = default) { @@ -680,7 +680,7 @@ public class OpenIddictApplicationManager : IOpenIddictApplication /// The application. /// The requirement. /// The that can be used to abort the operation. - /// true if the requirement has been enforced for the specified application, false otherwise. + /// if the requirement has been enforced for the specified application, otherwise. public virtual async ValueTask HasRequirementAsync( TApplication application!!, string requirement, CancellationToken cancellationToken = default) { diff --git a/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs b/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs index a426384f..e5f0d8ab 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs @@ -714,7 +714,7 @@ public class OpenIddictAuthorizationManager : IOpenIddictAuthori /// The authorization. /// The scopes. /// The that can be used to abort the operation. - /// true if the scopes are included in the authorization, false otherwise. + /// if the scopes are included in the authorization, otherwise. public virtual async ValueTask HasScopesAsync(TAuthorization authorization!!, ImmutableArray scopes, CancellationToken cancellationToken = default) => new HashSet(await Store.GetScopesAsync( @@ -726,7 +726,7 @@ public class OpenIddictAuthorizationManager : IOpenIddictAuthori /// The authorization. /// The expected status. /// The that can be used to abort the operation. - /// true if the authorization has the specified status, false otherwise. + /// if the authorization has the specified status, otherwise. public virtual async ValueTask HasStatusAsync(TAuthorization authorization!!, string status, CancellationToken cancellationToken = default) { @@ -744,7 +744,7 @@ public class OpenIddictAuthorizationManager : IOpenIddictAuthori /// The authorization. /// The expected type. /// The that can be used to abort the operation. - /// true if the authorization has the specified type, false otherwise. + /// if the authorization has the specified type, otherwise. public virtual async ValueTask HasTypeAsync( TAuthorization authorization!!, string type, CancellationToken cancellationToken = default) { @@ -862,7 +862,7 @@ public class OpenIddictAuthorizationManager : IOpenIddictAuthori /// /// The authorization to revoke. /// The that can be used to abort the operation. - /// true if the authorization was successfully revoked, false otherwise. + /// if the authorization was successfully revoked, otherwise. public virtual async ValueTask TryRevokeAsync(TAuthorization authorization!!, CancellationToken cancellationToken = default) { var status = await Store.GetStatusAsync(authorization, cancellationToken); diff --git a/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs b/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs index 832edca4..a419c38c 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs @@ -450,7 +450,7 @@ public class OpenIddictScopeManager : IOpenIddictScopeManager where TSco TScope scope!!, CultureInfo culture!!, CancellationToken cancellationToken = default) { var names = await Store.GetDisplayNamesAsync(scope, cancellationToken); - if (names is not { IsEmpty: false }) + if (names is not { Count: > 0 }) { return await Store.GetDisplayNameAsync(scope, cancellationToken); } @@ -500,7 +500,7 @@ public class OpenIddictScopeManager : IOpenIddictScopeManager where TSco TScope scope!!, CultureInfo culture!!, CancellationToken cancellationToken = default) { var descriptions = await Store.GetDescriptionsAsync(scope, cancellationToken); - if (descriptions is not { IsEmpty: false }) + if (descriptions is not { Count: > 0 }) { return await Store.GetDescriptionAsync(scope, cancellationToken); } diff --git a/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs b/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs index ec556336..ec72369e 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs @@ -729,7 +729,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// The token. /// The expected status. /// The that can be used to abort the operation. - /// true if the token has the specified status, false otherwise. + /// if the token has the specified status, otherwise. public virtual async ValueTask HasStatusAsync(TToken token!!, string status, CancellationToken cancellationToken = default) { if (string.IsNullOrEmpty(status)) @@ -746,7 +746,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// The token. /// The expected type. /// The that can be used to abort the operation. - /// true if the token has the specified type, false otherwise. + /// if the token has the specified type, otherwise. public virtual async ValueTask HasTypeAsync(TToken token!!, string type, CancellationToken cancellationToken = default) { if (string.IsNullOrEmpty(type)) @@ -763,7 +763,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// The token. /// The expected types. /// The that can be used to abort the operation. - /// true if the token has any of the specified types, false otherwise. + /// if the token has any of the specified types, otherwise. public virtual async ValueTask HasTypeAsync(TToken token!!, ImmutableArray types, CancellationToken cancellationToken = default) { var type = await Store.GetTypeAsync(token, cancellationToken); @@ -892,7 +892,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// /// The token to redeem. /// The that can be used to abort the operation. - /// true if the token was successfully redemeed, false otherwise. + /// if the token was successfully redemeed, otherwise. public virtual async ValueTask TryRedeemAsync(TToken token!!, CancellationToken cancellationToken = default) { // If the token doesn't have a redemption date attached, this likely means it's @@ -933,7 +933,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// /// The token to reject. /// The that can be used to abort the operation. - /// true if the token was successfully redemeed, false otherwise. + /// if the token was successfully redemeed, otherwise. public virtual async ValueTask TryRejectAsync(TToken token!!, CancellationToken cancellationToken = default) { await Store.SetStatusAsync(token, Statuses.Rejected, cancellationToken); @@ -967,7 +967,7 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok /// /// The token to revoke. /// The that can be used to abort the operation. - /// true if the token was successfully revoked, false otherwise. + /// if the token was successfully revoked, otherwise. public virtual async ValueTask TryRevokeAsync(TToken token!!, CancellationToken cancellationToken = default) { await Store.SetStatusAsync(token, Statuses.Revoked, cancellationToken); diff --git a/src/OpenIddict.Core/OpenIddictCoreOptions.cs b/src/OpenIddict.Core/OpenIddictCoreOptions.cs index 18da6890..65f672e5 100644 --- a/src/OpenIddict.Core/OpenIddictCoreOptions.cs +++ b/src/OpenIddict.Core/OpenIddictCoreOptions.cs @@ -39,7 +39,7 @@ public class OpenIddictCoreOptions /// Gets or sets a boolean indicating whether additional filtering should be disabled, /// so that the OpenIddict managers don't execute a second check to ensure the results /// returned by the stores exactly match the specified query filters, casing included. - /// This property SHOULD NOT be set to true except when the underlying stores + /// This property SHOULD NOT be set to except when the underlying stores /// are guaranteed to execute case-sensitive filtering at the database level. /// Disabling this feature MAY result in security vulnerabilities in the other cases. /// @@ -56,7 +56,7 @@ public class OpenIddictCoreOptions /// Gets or sets the maximum number of cached entries allowed. When the threshold /// is reached, the cache is automatically compacted to ensure it doesn't grow /// abnormally and doesn't cause a memory starvation or out-of-memory exceptions. - /// This property is not used when is true. + /// This property is not used when is . /// public int EntityCacheLimit { get; set; } = 250; } diff --git a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkApplication.cs b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkApplication.cs index a3ab19b5..572fffcb 100644 --- a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkApplication.cs +++ b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkApplication.cs @@ -87,7 +87,7 @@ public class OpenIddictEntityFrameworkApplication /// /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current application. + /// or if no bag was associated with the current application. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkAuthorization.cs b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkAuthorization.cs index 5f3d6f7c..e65d51e7 100644 --- a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkAuthorization.cs +++ b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkAuthorization.cs @@ -51,7 +51,7 @@ public class OpenIddictEntityFrameworkAuthorization /// /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current authorization. + /// or if no bag was associated with the current authorization. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkScope.cs b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkScope.cs index b1bf2a58..db941a82 100644 --- a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkScope.cs +++ b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkScope.cs @@ -66,7 +66,7 @@ public class OpenIddictEntityFrameworkScope where TKey : notnull, IEquatab /// /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current scope. + /// or if no bag was associated with the current scope. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkToken.cs b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkToken.cs index 91aa8a7a..3b8fb8e1 100644 --- a/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkToken.cs +++ b/src/OpenIddict.EntityFramework.Models/OpenIddictEntityFrameworkToken.cs @@ -68,7 +68,7 @@ public class OpenIddictEntityFrameworkToken /// /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current token. + /// or if no bag was associated with the current token. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs index c7c9ea78..406e2a40 100644 --- a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs +++ b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs @@ -350,7 +350,7 @@ public class OpenIddictEntityFrameworkAuthorizationStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -598,7 +598,7 @@ public class OpenIddictEntityFrameworkAuthorizationStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs index 7ebf9d68..9176e987 100644 --- a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs +++ b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs @@ -290,7 +290,7 @@ public class OpenIddictEntityFrameworkTokenStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -321,7 +321,7 @@ public class OpenIddictEntityFrameworkTokenStore entry.Authorization); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -541,7 +541,7 @@ public class OpenIddictEntityFrameworkTokenStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } @@ -569,7 +569,7 @@ public class OpenIddictEntityFrameworkTokenStore entry.Authorization); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } @@ -609,7 +609,7 @@ public class OpenIddictEntityFrameworkTokenStore properties, CancellationToken cancellationToken) { - if (properties is not { IsEmpty: false }) + if (properties is not { Count: > 0 }) { token.Properties = null; diff --git a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreApplication.cs b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreApplication.cs index 87f171e6..134729f8 100644 --- a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreApplication.cs +++ b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreApplication.cs @@ -95,7 +95,7 @@ public class OpenIddictEntityFrameworkCoreApplication /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current application. + /// or if no bag was associated with the current application. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreAuthorization.cs b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreAuthorization.cs index 5a09ab68..77a3c905 100644 --- a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreAuthorization.cs +++ b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreAuthorization.cs @@ -59,7 +59,7 @@ public class OpenIddictEntityFrameworkCoreAuthorization /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current authorization. + /// or if no bag was associated with the current authorization. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreScope.cs b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreScope.cs index cccb0267..fe5eda1f 100644 --- a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreScope.cs +++ b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreScope.cs @@ -66,7 +66,7 @@ public class OpenIddictEntityFrameworkCoreScope where TKey : notnull, IEqu /// /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current scope. + /// or if no bag was associated with the current scope. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreToken.cs b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreToken.cs index 8c02ae79..1ee7162c 100644 --- a/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreToken.cs +++ b/src/OpenIddict.EntityFrameworkCore.Models/OpenIddictEntityFrameworkCoreToken.cs @@ -76,7 +76,7 @@ public class OpenIddictEntityFrameworkCoreToken /// Gets or sets the additional properties serialized as a JSON object, - /// or null if no bag was associated with the current token. + /// or if no bag was associated with the current token. /// public virtual string? Properties { get; set; } diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs index 46e39163..9830d112 100644 --- a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs +++ b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs @@ -415,7 +415,7 @@ public class OpenIddictEntityFrameworkCoreAuthorizationStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -683,7 +683,7 @@ public class OpenIddictEntityFrameworkCoreAuthorizationStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs index bcddf543..881d6d17 100644 --- a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs +++ b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs @@ -339,7 +339,7 @@ public class OpenIddictEntityFrameworkCoreTokenStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -370,7 +370,7 @@ public class OpenIddictEntityFrameworkCoreTokenStore entry.Authorization); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return null; } @@ -606,7 +606,7 @@ public class OpenIddictEntityFrameworkCoreTokenStore entry.Application); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } @@ -639,7 +639,7 @@ public class OpenIddictEntityFrameworkCoreTokenStore entry.Authorization); - if (reference.EntityEntry.State == EntityState.Detached) + if (reference.EntityEntry.State is EntityState.Detached) { return; } @@ -679,7 +679,7 @@ public class OpenIddictEntityFrameworkCoreTokenStore properties, CancellationToken cancellationToken) { - if (properties is not { IsEmpty: false }) + if (properties is not { Count: > 0 }) { token.Properties = null; diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs index 00bf35d1..65c638e4 100644 --- a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs +++ b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs @@ -545,7 +545,7 @@ public class OpenIddictMongoDbTokenStore : IOpenIddictTokenStore public virtual ValueTask SetPropertiesAsync(TToken token!!, ImmutableDictionary properties, CancellationToken cancellationToken) { - if (properties is not { IsEmpty: false }) + if (properties is not { Count: > 0 }) { token.Properties = null; diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHelpers.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHelpers.cs index c9be806d..7277079f 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHelpers.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHelpers.cs @@ -18,7 +18,7 @@ public static class OpenIddictServerAspNetCoreHelpers /// Retrieves the instance stored in the properties. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpRequest? GetHttpRequest(this OpenIddictServerTransaction transaction!!) { if (!transaction.Properties.TryGetValue(typeof(HttpRequest).FullName!, out object? property)) @@ -48,7 +48,7 @@ public static class OpenIddictServerAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictRequest? GetOpenIddictServerRequest(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Request; @@ -58,7 +58,7 @@ public static class OpenIddictServerAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictResponse? GetOpenIddictServerResponse(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Response; diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreOptions.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreOptions.cs index 3173daa6..fee26534 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreOptions.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreOptions.cs @@ -16,7 +16,7 @@ public class OpenIddictServerAspNetCoreOptions : AuthenticationSchemeOptions { /// /// Gets or sets a boolean indicating whether incoming requests arriving on insecure endpoints should be rejected. - /// By default, this property is set to false to help mitigate man-in-the-middle attacks. + /// By default, this property is set to to help mitigate man-in-the-middle attacks. /// public bool DisableTransportSecurityRequirement { get; set; } diff --git a/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionOptions.cs b/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionOptions.cs index a943c626..3dde0b56 100644 --- a/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionOptions.cs +++ b/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionOptions.cs @@ -17,7 +17,7 @@ public class OpenIddictServerDataProtectionOptions /// /// Gets or sets the data protection provider used to create the default /// data protectors used by the OpenIddict Data Protection server services. - /// When this property is set to null, the data protection provider + /// When this property is set to , the data protection provider /// is directly retrieved from the dependency injection container. /// public IDataProtectionProvider DataProtectionProvider { get; set; } = default!; @@ -30,31 +30,31 @@ public class OpenIddictServerDataProtectionOptions /// /// Gets or sets a boolean indicating whether the default access token format should be - /// used when issuing new access tokens. This property is set to false by default. + /// used when issuing new access tokens. This property is set to by default. /// public bool PreferDefaultAccessTokenFormat { get; set; } /// /// Gets or sets a boolean indicating whether the default authorization code format should be - /// used when issuing new authorization codes. This property is set to false by default. + /// used when issuing new authorization codes. This property is set to by default. /// public bool PreferDefaultAuthorizationCodeFormat { get; set; } /// /// Gets or sets a boolean indicating whether the default device code format should be - /// used when issuing new device codes. This property is set to false by default. + /// used when issuing new device codes. This property is set to by default. /// public bool PreferDefaultDeviceCodeFormat { get; set; } /// /// Gets or sets a boolean indicating whether the default refresh token format should be - /// used when issuing new refresh tokens. This property is set to false by default. + /// used when issuing new refresh tokens. This property is set to by default. /// public bool PreferDefaultRefreshTokenFormat { get; set; } /// /// Gets or sets a boolean indicating whether the default user code format should be - /// used when issuing new user codes. This property is set to false by default. + /// used when issuing new user codes. This property is set to by default. /// public bool PreferDefaultUserCodeFormat { get; set; } } diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHelpers.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHelpers.cs index 8d95cf54..fc2167f3 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHelpers.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHelpers.cs @@ -28,7 +28,7 @@ public static class OpenIddictServerOwinHelpers /// Retrieves the instance stored in the properties. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static IOwinRequest? GetOwinRequest(this OpenIddictServerTransaction transaction!!) { if (!transaction.Properties.TryGetValue(typeof(IOwinRequest).FullName!, out object? property)) @@ -56,7 +56,7 @@ public static class OpenIddictServerOwinHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictRequest? GetOpenIddictServerRequest(this IOwinContext context!!) => context.Get(typeof(OpenIddictServerTransaction).FullName)?.Request; @@ -64,7 +64,7 @@ public static class OpenIddictServerOwinHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictResponse? GetOpenIddictServerResponse(this IOwinContext context!!) => context.Get(typeof(OpenIddictServerTransaction).FullName)?.Response; } diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinOptions.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinOptions.cs index 72e64a11..bb1b3be5 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinOptions.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinOptions.cs @@ -23,7 +23,7 @@ public class OpenIddictServerOwinOptions : AuthenticationOptions /// /// Gets or sets a boolean indicating whether incoming requests arriving on insecure endpoints should be rejected. - /// By default, this property is set to false to help mitigate man-in-the-middle attacks. + /// By default, this property is set to to help mitigate man-in-the-middle attacks. /// public bool DisableTransportSecurityRequirement { get; set; } diff --git a/src/OpenIddict.Server/OpenIddictServerBuilder.cs b/src/OpenIddict.Server/OpenIddictServerBuilder.cs index 33d88020..3d751669 100644 --- a/src/OpenIddict.Server/OpenIddictServerBuilder.cs +++ b/src/OpenIddict.Server/OpenIddictServerBuilder.cs @@ -131,7 +131,7 @@ public class OpenIddictServerBuilder { // If the encryption key is an asymmetric security key, ensure it has a private key. if (key is AsymmetricSecurityKey asymmetricSecurityKey && - asymmetricSecurityKey.PrivateKeyStatus == PrivateKeyStatus.DoesNotExist) + asymmetricSecurityKey.PrivateKeyStatus is PrivateKeyStatus.DoesNotExist) { throw new InvalidOperationException(SR.GetResourceString(SR.ID0055)); } @@ -491,7 +491,7 @@ public class OpenIddictServerBuilder { // If the signing key is an asymmetric security key, ensure it has a private key. if (key is AsymmetricSecurityKey asymmetricSecurityKey && - asymmetricSecurityKey.PrivateKeyStatus == PrivateKeyStatus.DoesNotExist) + asymmetricSecurityKey.PrivateKeyStatus is PrivateKeyStatus.DoesNotExist) { throw new InvalidOperationException(SR.GetResourceString(SR.ID0067)); } @@ -1505,7 +1505,7 @@ public class OpenIddictServerBuilder /// a new access token by making a grant_type=refresh_token token request /// or a prompt=none authorization request, depending on the selected flow. /// Using long-lived access tokens or tokens that never expire is not recommended. - /// While discouraged, null can be specified to issue tokens that never expire. + /// While discouraged, can be specified to issue tokens that never expire. /// /// The access token lifetime. /// The . @@ -1516,7 +1516,7 @@ public class OpenIddictServerBuilder /// Sets the authorization code lifetime, after which client applications /// are unable to send a grant_type=authorization_code token request. /// Using short-lived authorization codes is strongly recommended. - /// While discouraged, null can be specified to issue codes that never expire. + /// While discouraged, can be specified to issue codes that never expire. /// /// The authorization code lifetime. /// The . @@ -1527,7 +1527,7 @@ public class OpenIddictServerBuilder /// Sets the device code lifetime, after which client applications are unable to /// send a grant_type=urn:ietf:params:oauth:grant-type:device_code token request. /// Using short-lived device codes is strongly recommended. - /// While discouraged, null can be specified to issue codes that never expire. + /// While discouraged, can be specified to issue codes that never expire. /// /// The authorization code lifetime. /// The . @@ -1537,7 +1537,7 @@ public class OpenIddictServerBuilder /// /// Sets the identity token lifetime, after which client /// applications should refuse processing identity tokens. - /// While discouraged, null can be specified to issue tokens that never expire. + /// While discouraged, can be specified to issue tokens that never expire. /// /// The identity token lifetime. /// The . @@ -1549,7 +1549,7 @@ public class OpenIddictServerBuilder /// a new authorization from the user. When sliding expiration is enabled, /// a new refresh token is always issued to the client application, /// which prolongs the validity period of the refresh token. - /// While discouraged, null can be specified to issue tokens that never expire. + /// While discouraged, can be specified to issue tokens that never expire. /// /// The refresh token lifetime. /// The . @@ -1568,7 +1568,7 @@ public class OpenIddictServerBuilder /// /// Sets the user code lifetime, after which they'll no longer be considered valid. /// Using short-lived device codes is strongly recommended. - /// While discouraged, null can be specified to issue codes that never expire. + /// While discouraged, can be specified to issue codes that never expire. /// /// The authorization code lifetime. /// The . diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Authentication.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Authentication.cs index 06961dcb..d5a44cce 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Authentication.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Authentication.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request or null if it was extracted yet. + /// Gets or sets the request or if it was extracted yet. /// public OpenIddictRequest? Request { @@ -153,7 +153,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -187,7 +187,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response?.Error; diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Device.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Device.cs index 45177f18..fe3755f5 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Device.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Device.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -119,7 +119,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -139,7 +139,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } @@ -159,7 +159,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -263,7 +263,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -283,7 +283,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Discovery.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Discovery.cs index b7c544e5..8a548da6 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Discovery.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Discovery.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -206,7 +206,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -226,7 +226,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } @@ -246,7 +246,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -331,7 +331,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -351,7 +351,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Exchange.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Exchange.cs index bc72310d..412c3d14 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Exchange.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Exchange.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -125,7 +125,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -145,7 +145,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Introspection.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Introspection.cs index 385913e9..ee579830 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Introspection.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Introspection.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -59,7 +59,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the optional token_type_hint parameter extracted from the - /// introspection request, or null if it cannot be found. + /// introspection request, or if it cannot be found. /// public string? TokenTypeHint => Request?.TokenTypeHint; @@ -182,7 +182,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -202,7 +202,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Protection.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Protection.cs index faec92fd..55c7cc06 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Protection.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Protection.cs @@ -26,7 +26,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it is not available. + /// Gets or sets the request, or if it is not available. /// public OpenIddictRequest? Request { @@ -97,7 +97,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it is not available. + /// Gets or sets the request, or if it is not available. /// public OpenIddictRequest? Request { diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Revocation.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Revocation.cs index 10bf9d3d..efc73b67 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Revocation.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Revocation.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -59,7 +59,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the optional token_type_hint parameter extracted from the - /// revocation request, or null if it cannot be found. + /// revocation request, or if it cannot be found. /// public string? TokenTypeHint => Request.TokenTypeHint; @@ -112,7 +112,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -132,7 +132,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Session.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Session.cs index 0c660d9c..738b715b 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Session.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Session.cs @@ -23,7 +23,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if wasn't extracted yet. + /// Gets or sets the request, or if wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -147,7 +147,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -167,7 +167,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs b/src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs index e18ae98d..a23babb0 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs @@ -26,7 +26,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it wasn't extracted yet. + /// Gets or sets the request, or if it wasn't extracted yet. /// public OpenIddictRequest? Request { @@ -200,7 +200,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -220,7 +220,7 @@ public static partial class OpenIddictServerEvents /// /// Gets the error code returned to the client application. /// When the response indicates a successful response, - /// this property returns null. + /// this property returns . /// public string? Error => Response.Error; } diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.cs b/src/OpenIddict.Server/OpenIddictServerEvents.cs index 3028d37f..3cc5a484 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.cs @@ -196,7 +196,7 @@ public static partial class OpenIddictServerEvents public ClaimsPrincipal? Principal { get; set; } /// - /// Gets the client identifier, or null if the client application is unknown. + /// Gets the client identifier, or if the client application is unknown. /// public string? ClientId => Transaction.Request?.ClientId; } @@ -229,7 +229,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets or sets the request or null if it couldn't be extracted. + /// Gets or sets the request or if it couldn't be extracted. /// public OpenIddictRequest? Request { @@ -705,7 +705,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated access token, if applicable. /// The access token will only be returned if - /// is set to true. + /// is set to . /// public string? AccessToken { get; set; } @@ -718,7 +718,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated authorization code, if applicable. /// The authorization code will only be returned if - /// is set to true. + /// is set to . /// public string? AuthorizationCode { get; set; } @@ -731,7 +731,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated device code, if applicable. /// The device code will only be returned if - /// is set to true. + /// is set to . /// public string? DeviceCode { get; set; } @@ -744,7 +744,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated identity token, if applicable. /// The identity token will only be returned if - /// is set to true. + /// is set to . /// public string? IdentityToken { get; set; } @@ -757,7 +757,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated refresh token, if applicable. /// The refresh token will only be returned if - /// is set to true. + /// is set to . /// public string? RefreshToken { get; set; } @@ -770,7 +770,7 @@ public static partial class OpenIddictServerEvents /// /// Gets or sets the generated user code, if applicable. /// The user code will only be returned if - /// is set to true. + /// is set to . /// public string? UserCode { get; set; } diff --git a/src/OpenIddict.Server/OpenIddictServerHelpers.cs b/src/OpenIddict.Server/OpenIddictServerHelpers.cs index 895ac102..55f38bff 100644 --- a/src/OpenIddict.Server/OpenIddictServerHelpers.cs +++ b/src/OpenIddict.Server/OpenIddictServerHelpers.cs @@ -17,7 +17,7 @@ public static class OpenIddictServerHelpers /// The type of the property. /// The server transaction. /// The property name. - /// The property value or null if it couldn't be found. + /// The property value or if it couldn't be found. public static TProperty? GetProperty( this OpenIddictServerTransaction transaction!!, string name) where TProperty : class { diff --git a/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHelpers.cs b/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHelpers.cs index ec3d0526..907e5f99 100644 --- a/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHelpers.cs +++ b/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHelpers.cs @@ -18,7 +18,7 @@ public static class OpenIddictValidationAspNetCoreHelpers /// Retrieves the instance stored in the properties. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpRequest? GetHttpRequest(this OpenIddictValidationTransaction transaction!!) { if (!transaction.Properties.TryGetValue(typeof(HttpRequest).FullName!, out object? property)) @@ -48,7 +48,7 @@ public static class OpenIddictValidationAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictRequest? GetOpenIddictValidationRequest(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Request; @@ -58,7 +58,7 @@ public static class OpenIddictValidationAspNetCoreHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictResponse? GetOpenIddictValidationResponse(this HttpContext context!!) { return context.Features.Get()?.Transaction?.Response; diff --git a/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionOptions.cs b/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionOptions.cs index 689bdb6e..df967c85 100644 --- a/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionOptions.cs +++ b/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionOptions.cs @@ -17,7 +17,7 @@ public class OpenIddictValidationDataProtectionOptions /// /// Gets or sets the data protection provider used to create the default /// data protectors used by the OpenIddict Data Protection validation services. - /// When this property is set to null, the data protection provider + /// When this property is set to , the data protection provider /// is directly retrieved from the dependency injection container. /// public IDataProtectionProvider DataProtectionProvider { get; set; } = default!; diff --git a/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHelpers.cs b/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHelpers.cs index c7c228ea..fffcf09e 100644 --- a/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHelpers.cs +++ b/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHelpers.cs @@ -28,7 +28,7 @@ public static class OpenIddictValidationOwinHelpers /// Retrieves the instance stored in the properties. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static IOwinRequest? GetOwinRequest(this OpenIddictValidationTransaction transaction!!) { if (!transaction.Properties.TryGetValue(typeof(IOwinRequest).FullName!, out object? property)) @@ -56,7 +56,7 @@ public static class OpenIddictValidationOwinHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictRequest? GetOpenIddictValidationRequest(this IOwinContext context!!) => context.Get(typeof(OpenIddictValidationTransaction).FullName)?.Request; @@ -64,7 +64,7 @@ public static class OpenIddictValidationOwinHelpers /// Retrieves the instance stored in . /// /// The context instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static OpenIddictResponse? GetOpenIddictValidationResponse(this IOwinContext context!!) => context.Get(typeof(OpenIddictValidationTransaction).FullName)?.Response; } diff --git a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHelpers.cs b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHelpers.cs index 77f9ea84..9f2bc2e3 100644 --- a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHelpers.cs +++ b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHelpers.cs @@ -17,7 +17,7 @@ public static class OpenIddictValidationSystemNetHttpHelpers /// Gets the associated with the current context. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpRequestMessage? GetHttpRequestMessage(this OpenIddictValidationTransaction transaction) => transaction.GetProperty(typeof(HttpRequestMessage).FullName!); @@ -25,7 +25,7 @@ public static class OpenIddictValidationSystemNetHttpHelpers /// Gets the associated with the current context. /// /// The transaction instance. - /// The instance or null if it couldn't be found. + /// The instance or if it couldn't be found. public static HttpResponseMessage? GetHttpResponseMessage(this OpenIddictValidationTransaction transaction) => transaction.GetProperty(typeof(HttpResponseMessage).FullName!); } diff --git a/src/OpenIddict.Validation/OpenIddictValidationBuilder.cs b/src/OpenIddict.Validation/OpenIddictValidationBuilder.cs index b041aaca..4aa34ac0 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationBuilder.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationBuilder.cs @@ -121,7 +121,7 @@ public class OpenIddictValidationBuilder { // If the encryption key is an asymmetric security key, ensure it has a private key. if (key is AsymmetricSecurityKey asymmetricSecurityKey && - asymmetricSecurityKey.PrivateKeyStatus == PrivateKeyStatus.DoesNotExist) + asymmetricSecurityKey.PrivateKeyStatus is PrivateKeyStatus.DoesNotExist) { throw new InvalidOperationException(SR.GetResourceString(SR.ID0055)); } diff --git a/src/OpenIddict.Validation/OpenIddictValidationEvents.Discovery.cs b/src/OpenIddict.Validation/OpenIddictValidationEvents.Discovery.cs index 6aa7bb0d..2ef16e49 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationEvents.Discovery.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationEvents.Discovery.cs @@ -82,7 +82,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { @@ -200,7 +200,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { diff --git a/src/OpenIddict.Validation/OpenIddictValidationEvents.Introspection.cs b/src/OpenIddict.Validation/OpenIddictValidationEvents.Introspection.cs index 35959529..beb0156f 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationEvents.Introspection.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationEvents.Introspection.cs @@ -92,7 +92,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets or sets the response, or null if it wasn't extracted yet. + /// Gets or sets the response, or if it wasn't extracted yet. /// public OpenIddictResponse? Response { diff --git a/src/OpenIddict.Validation/OpenIddictValidationEvents.Protection.cs b/src/OpenIddict.Validation/OpenIddictValidationEvents.Protection.cs index c3173e30..3f8743d8 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationEvents.Protection.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationEvents.Protection.cs @@ -26,7 +26,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets or sets the request, or null if it is not available. + /// Gets or sets the request, or if it is not available. /// public OpenIddictRequest? Request { diff --git a/src/OpenIddict.Validation/OpenIddictValidationEvents.cs b/src/OpenIddict.Validation/OpenIddictValidationEvents.cs index 047917f7..866c4c17 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationEvents.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationEvents.cs @@ -195,7 +195,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets or sets the request, or null if it couldn't be extracted. + /// Gets or sets the request, or if it couldn't be extracted. /// public OpenIddictRequest? Request { diff --git a/src/OpenIddict.Validation/OpenIddictValidationHelpers.cs b/src/OpenIddict.Validation/OpenIddictValidationHelpers.cs index 6ebde856..9ebc7297 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHelpers.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHelpers.cs @@ -17,7 +17,7 @@ public static class OpenIddictValidationHelpers /// The type of the property. /// The validation transaction. /// The property name. - /// The property value or null if it couldn't be found. + /// The property value or if it couldn't be found. public static TProperty? GetProperty( this OpenIddictValidationTransaction transaction!!, string name) where TProperty : class {