diff --git a/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs b/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs index f6e4981b..5a64369f 100644 --- a/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs +++ b/src/OpenIddict.Abstractions/Managers/IOpenIddictAuthorizationManager.cs @@ -110,7 +110,7 @@ namespace OpenIddict.Abstractions /// A that can be used to monitor the asynchronous operation, /// whose result returns the authorizations corresponding to the criteria. /// - Task> FindAsync([NotNull] string subject, [NotNull] string client, [NotNull] string status, CancellationToken cancellationToken); + Task> FindAsync([NotNull] string subject, [NotNull] string client, [NotNull] string status, CancellationToken cancellationToken = default); /// /// Retrieves the authorizations matching the specified parameters. @@ -357,7 +357,7 @@ namespace OpenIddict.Abstractions Task PopulateAsync([NotNull] object authorization, [NotNull] OpenIddictAuthorizationDescriptor descriptor, CancellationToken cancellationToken = default); /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.Abstractions/Stores/IOpenIddictAuthorizationStore.cs b/src/OpenIddict.Abstractions/Stores/IOpenIddictAuthorizationStore.cs index 3cd9825b..77324e8a 100644 --- a/src/OpenIddict.Abstractions/Stores/IOpenIddictAuthorizationStore.cs +++ b/src/OpenIddict.Abstractions/Stores/IOpenIddictAuthorizationStore.cs @@ -279,7 +279,7 @@ namespace OpenIddict.Abstractions [CanBeNull] TState state, CancellationToken cancellationToken); /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs index d30a1fd7..8fd2790d 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs @@ -90,7 +90,7 @@ namespace OpenIddict.Core /// A that can be used to monitor the asynchronous operation. /// public virtual Task CreateAsync([NotNull] TApplication application, CancellationToken cancellationToken = default) - => CreateAsync(application, /* secret: */ null, cancellationToken); + => CreateAsync(application, secret: null, cancellationToken); /// /// Creates a new application. @@ -180,7 +180,7 @@ namespace OpenIddict.Core var secret = await Store.GetClientSecretAsync(application, cancellationToken); if (!string.IsNullOrEmpty(secret)) { - await Store.SetClientSecretAsync(application, /* secret: */ null, cancellationToken); + await Store.SetClientSecretAsync(application, secret: null, cancellationToken); await CreateAsync(application, secret, cancellationToken); } else diff --git a/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs b/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs index 3644a105..1a42933d 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictAuthorizationManager.cs @@ -887,7 +887,7 @@ namespace OpenIddict.Core } /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictAuthorizationStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictAuthorizationStore.cs index b0478dda..69dfe095 100644 --- a/src/OpenIddict.EntityFramework/Stores/OpenIddictAuthorizationStore.cs +++ b/src/OpenIddict.EntityFramework/Stores/OpenIddictAuthorizationStore.cs @@ -691,7 +691,7 @@ namespace OpenIddict.EntityFramework } /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictAuthorizationStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictAuthorizationStore.cs index 9e5cab67..e6521006 100644 --- a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictAuthorizationStore.cs +++ b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictAuthorizationStore.cs @@ -780,7 +780,7 @@ namespace OpenIddict.EntityFrameworkCore } /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictAuthorizationStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictAuthorizationStore.cs index 1b9277ca..501999c7 100644 --- a/src/OpenIddict.MongoDb/Stores/OpenIddictAuthorizationStore.cs +++ b/src/OpenIddict.MongoDb/Stores/OpenIddictAuthorizationStore.cs @@ -615,7 +615,7 @@ namespace OpenIddict.MongoDb } /// - /// Removes the ad-hoc authorizations that are marked as invalid or have no valid/nonexpired token attached. + /// Removes the authorizations that are marked as invalid and the ad-hoc ones that have no valid/nonexpired token attached. /// /// The that can be used to abort the operation. /// diff --git a/src/OpenIddict.Server/Internal/OpenIddictServerProvider.Helpers.cs b/src/OpenIddict.Server/Internal/OpenIddictServerProvider.Helpers.cs index b2be2d9c..57113b8e 100644 --- a/src/OpenIddict.Server/Internal/OpenIddictServerProvider.Helpers.cs +++ b/src/OpenIddict.Server/Internal/OpenIddictServerProvider.Helpers.cs @@ -569,8 +569,8 @@ namespace OpenIddict.Server.Internal if (property.Key.EndsWith(OpenIddictConstants.PropertyTypes.Boolean)) { var name = property.Key.Substring( - /* index: */ 0, - /* length: */ property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Boolean)); + startIndex: 0, + length: property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Boolean)); bool value; @@ -593,8 +593,8 @@ namespace OpenIddict.Server.Internal else if (property.Key.EndsWith(OpenIddictConstants.PropertyTypes.Integer)) { var name = property.Key.Substring( - /* index: */ 0, - /* length: */ property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Integer)); + startIndex: 0, + length: property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Integer)); long value; @@ -617,8 +617,8 @@ namespace OpenIddict.Server.Internal else if (property.Key.EndsWith(OpenIddictConstants.PropertyTypes.Json)) { var name = property.Key.Substring( - /* index: */ 0, - /* length: */ property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Json)); + startIndex: 0, + length: property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.Json)); if (request.IsAuthorizationRequest() || request.IsLogoutRequest()) { @@ -649,8 +649,8 @@ namespace OpenIddict.Server.Internal else if (property.Key.EndsWith(OpenIddictConstants.PropertyTypes.String)) { var name = property.Key.Substring( - /* index: */ 0, - /* length: */ property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.String)); + startIndex: 0, + length: property.Key.LastIndexOf(OpenIddictConstants.PropertyTypes.String)); yield return (property.Key, name, property.Value); }