diff --git a/sandbox/OpenIddict.Sandbox.AspNetCore.Server/Startup.cs b/sandbox/OpenIddict.Sandbox.AspNetCore.Server/Startup.cs index 7e8ccfe4..b8d17bc5 100644 --- a/sandbox/OpenIddict.Sandbox.AspNetCore.Server/Startup.cs +++ b/sandbox/OpenIddict.Sandbox.AspNetCore.Server/Startup.cs @@ -164,7 +164,7 @@ public class Startup services.AddTransient(); services.AddTransient(); - // Register the worker responsible of seeding the database with the sample clients. + // Register the worker responsible for seeding the database with the sample clients. // Note: in a real world application, this step should be part of a setup script. services.AddHostedService(); } diff --git a/src/OpenIddict.Abstractions/OpenIddictResources.resx b/src/OpenIddict.Abstractions/OpenIddictResources.resx index 25370af1..4df9cd32 100644 --- a/src/OpenIddict.Abstractions/OpenIddictResources.resx +++ b/src/OpenIddict.Abstractions/OpenIddictResources.resx @@ -494,7 +494,7 @@ Make sure that neither DefaultAuthenticateScheme, DefaultChallengeScheme, Defaul The OpenID Connect response was not correctly processed. -This may indicate that the event handler responsible of processing OpenID Connect responses was not registered or was explicitly removed from the handlers list. +This may indicate that the event handler responsible for processing OpenID Connect responses was not registered or was explicitly removed from the handlers list. An error occurred while retrieving the OpenIddict server context. On ASP.NET Core, this may indicate that the authentication middleware was not registered early enough in the request pipeline. Make sure that 'app.UseAuthentication()' is registered before 'app.UseAuthorization()' and 'app.UseEndpoints()' (or 'app.UseMvc()') and try again. diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs index 6fb1f1e2..b2746aa8 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictMessage.cs @@ -18,7 +18,7 @@ namespace OpenIddict.Abstractions; /// Represents an abstract OpenIddict message. /// /// -/// Security notice: developers instantiating this type are responsible of ensuring that the +/// Security notice: developers instantiating this type are responsible for ensuring that the /// imported parameters are safe and won't cause the resulting message to grow abnormally, /// which may result in an excessive memory consumption and a potential denial of service. /// diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictRequest.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictRequest.cs index b7bc993a..ae9e5a18 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictRequest.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictRequest.cs @@ -15,7 +15,7 @@ namespace OpenIddict.Abstractions; /// Represents a generic OpenIddict request. /// /// -/// Security notice: developers instantiating this type are responsible of ensuring that the +/// Security notice: developers instantiating this type are responsible for ensuring that the /// imported parameters are safe and won't cause the resulting message to grow abnormally, /// which may result in an excessive memory consumption and a potential denial of service. /// diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictResponse.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictResponse.cs index e2cc9836..1631781f 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictResponse.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictResponse.cs @@ -15,7 +15,7 @@ namespace OpenIddict.Abstractions; /// Represents a generic OpenIddict response. /// /// -/// Security notice: developers instantiating this type are responsible of ensuring that the +/// Security notice: developers instantiating this type are responsible for ensuring that the /// imported parameters are safe and won't cause the resulting message to grow abnormally, /// which may result in an excessive memory consumption and a potential denial of service. /// diff --git a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.Authentication.cs b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.Authentication.cs index 52dfeb61..bddd8faa 100644 --- a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.Authentication.cs +++ b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.Authentication.cs @@ -40,7 +40,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers ProcessLocalErrorResponse.Descriptor); /// - /// Contains the logic responsible of processing authorization requests using 302 redirects. + /// Contains the logic responsible for processing authorization requests using 302 redirects. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessQueryRequest : IOpenIddictClientHandler diff --git a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.cs b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.cs index 5e9c9992..002693f6 100644 --- a/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.cs +++ b/src/OpenIddict.Client.AspNetCore/OpenIddictClientAspNetCoreHandlers.cs @@ -41,7 +41,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers .AddRange(Authentication.DefaultHandlers); /// - /// Contains the logic responsible of inferring the endpoint type from the request address. + /// Contains the logic responsible for inferring the endpoint type from the request address. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class InferEndpointType : IOpenIddictClientHandler @@ -124,7 +124,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractGetRequest : IOpenIddictClientHandler where TContext : BaseValidatingContext @@ -170,7 +170,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET or POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET or POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractGetOrPostRequest : IOpenIddictClientHandler where TContext : BaseValidatingContext @@ -245,7 +245,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractPostRequest : IOpenIddictClientHandler where TContext : BaseValidatingContext @@ -315,7 +315,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of validating the correlation cookie that serves as a CSRF protection. + /// Contains the logic responsible for validating the correlation cookie that serves as a CSRF protection. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ValidateCorrelationCookie : IOpenIddictClientHandler @@ -391,7 +391,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of resolving the additional challenge parameters stored in the ASP.NET + /// Contains the logic responsible for resolving the additional challenge parameters stored in the ASP.NET /// Core authentication properties specified by the application that triggered the challenge operation. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -456,7 +456,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of creating a correlation cookie that serves as a CSRF countermeasure. + /// Contains the logic responsible for creating a correlation cookie that serves as a CSRF countermeasure. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class GenerateCorrelationCookie : IOpenIddictClientHandler @@ -481,7 +481,6 @@ public static partial class OpenIddictClientAspNetCoreHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Note: using a correlation cookie serves as an antiforgery protection as the request will // always be rejected if a cookie corresponding to the request forgery protection claim // persisted in the state token cannot be found. This protection is considered essential @@ -523,7 +522,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of enabling the pass-through mode for the received request. + /// Contains the logic responsible for enabling the pass-through mode for the received request. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class EnablePassthroughMode : IOpenIddictClientHandler @@ -552,7 +551,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching an appropriate HTTP status code. + /// Contains the logic responsible for attaching an appropriate HTTP status code. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachHttpResponseCode : IOpenIddictClientHandler where TContext : BaseRequestContext @@ -590,7 +589,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching the appropriate HTTP response cache headers. + /// Contains the logic responsible for attaching the appropriate HTTP response cache headers. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachCacheControlHeader : IOpenIddictClientHandler where TContext : BaseRequestContext @@ -624,7 +623,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be handled by another + /// Contains the logic responsible for processing OpenID Connect responses that must be handled by another /// middleware in the pipeline at a later stage (e.g an ASP.NET Core MVC action or a NancyFX module). /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -667,7 +666,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses handled by the status code pages middleware. + /// Contains the logic responsible for processing OpenID Connect responses handled by the status code pages middleware. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessStatusCodePagesErrorResponse : IOpenIddictClientHandler @@ -719,7 +718,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of processing context responses that must be returned as plain-text. + /// Contains the logic responsible for processing context responses that must be returned as plain-text. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessLocalErrorResponse : IOpenIddictClientHandler @@ -788,7 +787,7 @@ public static partial class OpenIddictClientAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that don't specify any parameter. + /// Contains the logic responsible for processing OpenID Connect responses that don't specify any parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessEmptyResponse : IOpenIddictClientHandler diff --git a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs index d3d3b9e9..1810b234 100644 --- a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs +++ b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs @@ -32,7 +32,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers DisposeHttpResponse.Descriptor); /// - /// Contains the logic responsible of attaching the client credentials to the HTTP Authorization header. + /// Contains the logic responsible for attaching the client credentials to the HTTP Authorization header. /// public class AttachBasicAuthenticationCredentials : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Userinfo.cs b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Userinfo.cs index b352d0ac..7deae5b0 100644 --- a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Userinfo.cs +++ b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Userinfo.cs @@ -32,7 +32,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers DisposeHttpResponse.Descriptor); /// - /// Contains the logic responsible of attaching the access token to the HTTP Authorization header. + /// Contains the logic responsible for attaching the access token to the HTTP Authorization header. /// public class AttachBearerAccessToken : IOpenIddictClientHandler { @@ -68,7 +68,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of extracting the response from the userinfo response. + /// Contains the logic responsible for extracting the response from the userinfo response. /// public class ExtractUserinfoHttpResponse : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs index d45a718e..682f4179 100644 --- a/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs +++ b/src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs @@ -23,7 +23,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers .AddRange(Userinfo.DefaultHandlers); /// - /// Contains the logic responsible of preparing an HTTP GET request message. + /// Contains the logic responsible for preparing an HTTP GET request message. /// public class PrepareGetHttpRequest : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -60,7 +60,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of preparing an HTTP POST request message. + /// Contains the logic responsible for preparing an HTTP POST request message. /// public class PreparePostHttpRequest : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -97,7 +97,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of attaching the query string parameters to the HTTP request. + /// Contains the logic responsible for attaching the query string parameters to the HTTP request. /// public class AttachQueryStringParameters : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -155,7 +155,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of attaching the form parameters to the HTTP request. + /// Contains the logic responsible for attaching the form parameters to the HTTP request. /// public class AttachFormParameters : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -193,7 +193,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of sending the HTTP request to the remote server. + /// Contains the logic responsible for sending the HTTP request to the remote server. /// public class SendHttpRequest : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -244,7 +244,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of disposing of the HTTP request message. + /// Contains the logic responsible for disposing of the HTTP request message. /// public class DisposeHttpRequest : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -277,7 +277,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of extracting the response from the JSON-encoded HTTP body. + /// Contains the logic responsible for extracting the response from the JSON-encoded HTTP body. /// public class ExtractJsonHttpResponse : IOpenIddictClientHandler where TContext : BaseExternalContext { @@ -310,7 +310,7 @@ public static partial class OpenIddictClientSystemNetHttpHandlers } /// - /// Contains the logic responsible of disposing of the HTTP response message. + /// Contains the logic responsible for disposing of the HTTP response message. /// public class DisposeHttpResponse : IOpenIddictClientHandler where TContext : BaseExternalContext { diff --git a/src/OpenIddict.Client/OpenIddictClientEvents.cs b/src/OpenIddict.Client/OpenIddictClientEvents.cs index 237e56a0..5ebf9f69 100644 --- a/src/OpenIddict.Client/OpenIddictClientEvents.cs +++ b/src/OpenIddict.Client/OpenIddictClientEvents.cs @@ -39,7 +39,7 @@ public static partial class OpenIddictClientEvents } /// - /// Gets the logger responsible of logging processed operations. + /// Gets the logger responsible for logging processed operations. /// public ILogger Logger => Transaction.Logger; diff --git a/src/OpenIddict.Client/OpenIddictClientHandlerDescriptor.cs b/src/OpenIddict.Client/OpenIddictClientHandlerDescriptor.cs index 5f12141b..5a718680 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlerDescriptor.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlerDescriptor.cs @@ -28,7 +28,7 @@ public class OpenIddictClientHandlerDescriptor public Type ContextType { get; private set; } = default!; /// - /// Gets the list of filters responsible of excluding the handler + /// Gets the list of filters responsible for excluding the handler /// from the activated handlers if it doesn't meet the criteria. /// public ImmutableArray FilterTypes { get; private set; } = ImmutableArray.Create(); diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.Authentication.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.Authentication.cs index 54630784..d3b33390 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.Authentication.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.Authentication.cs @@ -45,7 +45,7 @@ public static partial class OpenIddictClientHandlers ValidateTokens.Descriptor); /// - /// Contains the logic responsible of preparing authorization requests and invoking the corresponding event handlers. + /// Contains the logic responsible for preparing authorization requests and invoking the corresponding event handlers. /// public class PrepareAuthorizationRequest : IOpenIddictClientHandler { @@ -85,7 +85,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of applying authorization requests and invoking the corresponding event handlers. + /// Contains the logic responsible for applying authorization requests and invoking the corresponding event handlers. /// public class ApplyAuthorizationRequest : IOpenIddictClientHandler { @@ -125,7 +125,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the address of the authorization request to the request. + /// Contains the logic responsible for attaching the address of the authorization request to the request. /// public class AttachAuthorizationEndpoint : IOpenIddictClientHandler { @@ -162,7 +162,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting redirection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting redirection requests and invoking the corresponding event handlers. /// public class ExtractRedirectionRequest : IOpenIddictClientHandler { @@ -218,7 +218,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating redirection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating redirection requests and invoking the corresponding event handlers. /// public class ValidateRedirectionRequest : IOpenIddictClientHandler { @@ -270,7 +270,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of handling redirection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling redirection requests and invoking the corresponding event handlers. /// public class HandleRedirectionRequest : IOpenIddictClientHandler { @@ -321,7 +321,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of processing redirection responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing redirection responses and invoking the corresponding event handlers. /// public class ApplyRedirectionResponse : IOpenIddictClientHandler where TContext : BaseRequestContext { @@ -364,7 +364,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of removing the response mode parameter from the + /// Contains the logic responsible for removing the response mode parameter from the /// request if it corresponds to the default mode for the selected response type. /// public class NormalizeResponseModeParameter : IOpenIddictClientHandler @@ -381,7 +381,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(PrepareAuthorizationRequestContext context!!) { - // When the response mode corresponds to the default mode assigned to the selected // response type, the specification explicitly recommends omitting the response mode. // As such, this handler is expected to remove the mode parameter in the following cases: @@ -405,7 +404,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting redirection requests that don't + /// Contains the logic responsible for rejecting redirection requests that don't /// specify a valid access token, authorization code, identity token or state token. /// public class ValidateTokens : IOpenIddictClientHandler diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs index 230072ea..5ca81d9d 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs @@ -38,7 +38,7 @@ public static partial class OpenIddictClientHandlers ExtractSigningKeys.Descriptor); /// - /// Contains the logic responsible of extracting the issuer from the discovery document. + /// Contains the logic responsible for extracting the issuer from the discovery document. /// public class ValidateIssuer : IOpenIddictClientHandler { @@ -55,7 +55,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // The issuer returned in the discovery document must exactly match the URL used to access it. // See https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderConfigurationClient. var issuer = (string?) context.Response[Metadata.Issuer]; @@ -86,7 +85,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the authorization endpoint address from the discovery document. + /// Contains the logic responsible for extracting the authorization endpoint address from the discovery document. /// public class ExtractAuthorizationEndpoint : IOpenIddictClientHandler { @@ -133,7 +132,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the JWKS endpoint address from the discovery document. + /// Contains the logic responsible for extracting the JWKS endpoint address from the discovery document. /// public class ExtractCryptographyEndpoint : IOpenIddictClientHandler { @@ -180,7 +179,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the token endpoint address from the discovery document. + /// Contains the logic responsible for extracting the token endpoint address from the discovery document. /// public class ExtractTokenEndpoint : IOpenIddictClientHandler { @@ -218,7 +217,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the userinfo endpoint address from the discovery document. + /// Contains the logic responsible for extracting the userinfo endpoint address from the discovery document. /// public class ExtractUserinfoEndpoint : IOpenIddictClientHandler { @@ -256,7 +255,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the supported grant types from the discovery document. + /// Contains the logic responsible for extracting the supported grant types from the discovery document. /// public class ExtractGrantTypes : IOpenIddictClientHandler { @@ -273,7 +272,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the grant types supported by the authorization endpoint, if available. var types = context.Response[Metadata.GrantTypesSupported]?.GetUnnamedParameters(); if (types is { Count: > 0 }) @@ -294,7 +292,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the supported response types from the discovery document. + /// Contains the logic responsible for extracting the supported response types from the discovery document. /// public class ExtractResponseModes : IOpenIddictClientHandler { @@ -311,7 +309,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the response modes supported by the authorization endpoint, if available. var modes = context.Response[Metadata.ResponseModesSupported]?.GetUnnamedParameters(); if (modes is { Count: > 0 }) @@ -332,7 +329,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the supported response types from the discovery document. + /// Contains the logic responsible for extracting the supported response types from the discovery document. /// public class ExtractResponseTypes : IOpenIddictClientHandler { @@ -349,7 +346,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the response types supported by the authorization endpoint, if available. var types = context.Response[Metadata.ResponseTypesSupported]?.GetUnnamedParameters(); if (types is { Count: > 0 }) @@ -370,7 +366,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the supported code challenge methods from the discovery document. + /// Contains the logic responsible for extracting the supported code challenge methods from the discovery document. /// public class ExtractCodeChallengeMethods : IOpenIddictClientHandler { @@ -387,7 +383,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the code challenge methods supported by the authorization endpoint, if available. var methods = context.Response[Metadata.CodeChallengeMethodsSupported]?.GetUnnamedParameters(); if (methods is { Count: > 0 }) @@ -408,7 +403,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the supported scopes from the discovery document. + /// Contains the logic responsible for extracting the supported scopes from the discovery document. /// public class ExtractScopes : IOpenIddictClientHandler { @@ -425,7 +420,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the scopes supported by the remote server, if available. var scopes = context.Response[Metadata.ScopesSupported]?.GetUnnamedParameters(); if (scopes is { Count: > 0 }) @@ -446,7 +440,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the flag indicating + /// Contains the logic responsible for extracting the flag indicating /// whether the "iss" parameter is supported from the discovery document. /// public class ExtractIssuerParameterRequirement : IOpenIddictClientHandler @@ -472,7 +466,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the authentication methods + /// Contains the logic responsible for extracting the authentication methods /// supported by the token endpoint from the discovery document. /// public class ExtractTokenEndpointClientAuthenticationMethods : IOpenIddictClientHandler @@ -490,7 +484,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the client authentication methods supported by the token endpoint, if available. var methods = context.Response[Metadata.TokenEndpointAuthMethodsSupported]?.GetUnnamedParameters(); if (methods is { Count: > 0 }) @@ -511,7 +504,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the signing keys from the JWKS document. + /// Contains the logic responsible for extracting the signing keys from the JWKS document. /// public class ExtractSigningKeys : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.Exchange.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.Exchange.cs index a077013b..50dd2c9c 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.Exchange.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.Exchange.cs @@ -21,7 +21,7 @@ public static partial class OpenIddictClientHandlers ValidateWellKnownParameters.Descriptor); /// - /// Contains the logic responsible of validating the well-known parameters contained in the token response. + /// Contains the logic responsible for validating the well-known parameters contained in the token response. /// public class ValidateWellKnownParameters : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.Protection.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.Protection.cs index 6fdd07c2..9916a17d 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.Protection.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.Protection.cs @@ -35,7 +35,7 @@ public static partial class OpenIddictClientHandlers GenerateIdentityModelToken.Descriptor); /// - /// Contains the logic responsible of resolving the validation parameters used to validate tokens. + /// Contains the logic responsible for resolving the validation parameters used to validate tokens. /// public class ResolveTokenValidationParameters : IOpenIddictClientHandler { @@ -52,7 +52,6 @@ public static partial class OpenIddictClientHandlers /// public async ValueTask HandleAsync(ValidateTokenContext context!!) { - // The OpenIddict client is expected to validate tokens it creates (e.g state tokens) and // tokens that are created by one or multiple authorization servers (e.g identity tokens). // @@ -143,7 +142,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating tokens generated using IdentityModel. + /// Contains the logic responsible for validating tokens generated using IdentityModel. /// public class ValidateIdentityModelToken : IOpenIddictClientHandler { @@ -254,7 +253,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of mapping internal claims used by OpenIddict. + /// Contains the logic responsible for mapping internal claims used by OpenIddict. /// public class MapInternalClaims : IOpenIddictClientHandler { @@ -306,7 +305,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands for which no valid principal was resolved. + /// Contains the logic responsible for rejecting authentication demands for which no valid principal was resolved. /// public class ValidatePrincipal : IOpenIddictClientHandler { @@ -353,7 +352,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that use an expired token. + /// Contains the logic responsible for rejecting authentication demands that use an expired token. /// public class ValidateExpirationDate : IOpenIddictClientHandler { @@ -388,7 +387,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the signing and encryption credentials used to protect tokens. + /// Contains the logic responsible for resolving the signing and encryption credentials used to protect tokens. /// public class AttachSecurityCredentials : IOpenIddictClientHandler { @@ -415,7 +414,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of generating a token using IdentityModel. + /// Contains the logic responsible for generating a token using IdentityModel. /// public class GenerateIdentityModelToken : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.Userinfo.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.Userinfo.cs index a9500ce7..bf535d97 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.Userinfo.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.Userinfo.cs @@ -25,7 +25,7 @@ public static partial class OpenIddictClientHandlers PopulateClaims.Descriptor); /// - /// Contains the logic responsible of validating the well-known parameters contained in the userinfo response. + /// Contains the logic responsible for validating the well-known parameters contained in the userinfo response. /// public class ValidateWellKnownClaims : IOpenIddictClientHandler { @@ -77,7 +77,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting the claims from the introspection response. + /// Contains the logic responsible for extracting the claims from the introspection response. /// public class PopulateClaims : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client/OpenIddictClientHandlers.cs b/src/OpenIddict.Client/OpenIddictClientHandlers.cs index 484e5d2c..8e52d92d 100644 --- a/src/OpenIddict.Client/OpenIddictClientHandlers.cs +++ b/src/OpenIddict.Client/OpenIddictClientHandlers.cs @@ -109,7 +109,7 @@ public static partial class OpenIddictClientHandlers .AddRange(Userinfo.DefaultHandlers); /// - /// Contains the logic responsible of rejecting invalid authentication demands. + /// Contains the logic responsible for rejecting invalid authentication demands. /// public class ValidateAuthenticationDemand : IOpenIddictClientHandler { @@ -126,7 +126,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessAuthenticationContext context!!) { - // Authentication demands can be triggered from the redirection endpoint // to handle authorization callbacks but also from unknown endpoints // when using the refresh token grant, to perform a token refresh dance. @@ -162,7 +161,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of determining the types of tokens to validate upfront. + /// Contains the logic responsible for determining the types of tokens to validate upfront. /// public class EvaluateValidatedUpfrontTokens : IOpenIddictClientHandler { @@ -198,7 +197,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the state token to validate upfront from the incoming request. + /// Contains the logic responsible for resolving the state token to validate upfront from the incoming request. /// public class ResolveValidatedStateToken : IOpenIddictClientHandler { @@ -228,7 +227,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack the required state token. + /// Contains the logic responsible for rejecting authentication demands that lack the required state token. /// public class ValidateRequiredStateToken : IOpenIddictClientHandler { @@ -260,7 +259,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the state token resolved from the context. + /// Contains the logic responsible for validating the state token resolved from the context. /// public class ValidateStateToken : IOpenIddictClientHandler { @@ -323,7 +322,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the client registration + /// Contains the logic responsible for resolving the client registration /// based on the authorization server identity stored in the state token. /// public class ResolveClientRegistrationFromStateToken : IOpenIddictClientHandler @@ -377,7 +376,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of ensuring the issuer parameter, if available, matches the expected issuer. + /// Contains the logic responsible for ensuring the issuer parameter, if available, matches the expected issuer. /// public class ValidateIssuerParameter : IOpenIddictClientHandler { @@ -463,7 +462,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting errored authorization responses. + /// Contains the logic responsible for rejecting errored authorization responses. /// public class ValidateFrontchannelErrorParameters : IOpenIddictClientHandler { @@ -500,7 +499,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the grant type + /// Contains the logic responsible for resolving the grant type /// initially negotiated and stored in the state token, if applicable. /// public class ResolveGrantTypeFromStateToken : IOpenIddictClientHandler @@ -548,7 +547,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the response type + /// Contains the logic responsible for resolving the response type /// initially negotiated and stored in the state token, if applicable. /// public class ResolveResponseTypeFromStateToken : IOpenIddictClientHandler @@ -577,7 +576,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of determining the set of frontchannel tokens to validate. + /// Contains the logic responsible for determining the set of frontchannel tokens to validate. /// public class EvaluateValidatedFrontchannelTokens : IOpenIddictClientHandler { @@ -654,7 +653,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the token from the incoming request. + /// Contains the logic responsible for resolving the token from the incoming request. /// public class ResolveValidatedFrontchannelTokens : IOpenIddictClientHandler { @@ -700,7 +699,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack required tokens. + /// Contains the logic responsible for rejecting authentication demands that lack required tokens. /// public class ValidateRequiredFrontchannelTokens : IOpenIddictClientHandler { @@ -734,7 +733,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the frontchannel identity token resolved from the context. + /// Contains the logic responsible for validating the frontchannel identity token resolved from the context. /// public class ValidateFrontchannelIdentityToken : IOpenIddictClientHandler { @@ -797,7 +796,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the well-known claims contained in the frontchannel identity token. + /// Contains the logic responsible for validating the well-known claims contained in the frontchannel identity token. /// public class ValidateFrontchannelIdentityTokenWellknownClaims : IOpenIddictClientHandler { @@ -929,7 +928,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the audience returned in the frontchannel identity token, if applicable. + /// Contains the logic responsible for validating the audience returned in the frontchannel identity token, if applicable. /// public class ValidateFrontchannelIdentityTokenAudience : IOpenIddictClientHandler { @@ -969,7 +968,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the presenter returned in the frontchannel identity token, if applicable. + /// Contains the logic responsible for validating the presenter returned in the frontchannel identity token, if applicable. /// public class ValidateFrontchannelIdentityTokenPresenter : IOpenIddictClientHandler { @@ -1007,7 +1006,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the nonce returned in the frontchannel identity token, if applicable. + /// Contains the logic responsible for validating the nonce returned in the frontchannel identity token, if applicable. /// public class ValidateFrontchannelIdentityTokenNonce : IOpenIddictClientHandler { @@ -1066,7 +1065,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the digests of the frontchannel tokens, if applicable. + /// Contains the logic responsible for validating the digests of the frontchannel tokens, if applicable. /// public class ValidateFrontchannelTokenDigests : IOpenIddictClientHandler { @@ -1197,7 +1196,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the frontchannel access token resolved from the context. + /// Contains the logic responsible for validating the frontchannel access token resolved from the context. /// Note: this handler is typically not used for standard-compliant implementations as access tokens /// are supposed to be opaque to clients. /// @@ -1262,7 +1261,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the authorization code resolved from the context. + /// Contains the logic responsible for validating the authorization code resolved from the context. /// Note: this handler is typically not used for standard-compliant implementations as authorization codes /// are supposed to be opaque to clients. /// @@ -1327,7 +1326,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of determining the set of backchannel tokens to validate. + /// Contains the logic responsible for determining the set of backchannel tokens to validate. /// public class EvaluateValidatedBackchannelTokens : IOpenIddictClientHandler { @@ -1414,7 +1413,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the parameters to the token request, if applicable. + /// Contains the logic responsible for attaching the parameters to the token request, if applicable. /// public class AttachTokenRequestParameters : IOpenIddictClientHandler { @@ -1486,7 +1485,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of sending the token request, if applicable. + /// Contains the logic responsible for sending the token request, if applicable. /// public class SendTokenRequest : IOpenIddictClientHandler { @@ -1515,7 +1514,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting errored token responses. + /// Contains the logic responsible for rejecting errored token responses. /// public class ValidateTokenErrorParameters : IOpenIddictClientHandler { @@ -1549,7 +1548,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the backchannel tokens by sending a token request, if applicable. + /// Contains the logic responsible for resolving the backchannel tokens by sending a token request, if applicable. /// public class ResolveValidatedBackchannelTokens : IOpenIddictClientHandler { @@ -1591,7 +1590,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack required tokens. + /// Contains the logic responsible for rejecting authentication demands that lack required tokens. /// public class ValidateRequiredBackchannelTokens : IOpenIddictClientHandler { @@ -1625,7 +1624,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the backchannel identity token resolved from the context. + /// Contains the logic responsible for validating the backchannel identity token resolved from the context. /// public class ValidateBackchannelIdentityToken : IOpenIddictClientHandler { @@ -1688,7 +1687,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the well-known claims contained in the backchannel identity token. + /// Contains the logic responsible for validating the well-known claims contained in the backchannel identity token. /// public class ValidateBackchannelIdentityTokenWellknownClaims : IOpenIddictClientHandler { @@ -1820,7 +1819,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the audience returned in the backchannel identity token, if applicable. + /// Contains the logic responsible for validating the audience returned in the backchannel identity token, if applicable. /// public class ValidateBackchannelIdentityTokenAudience : IOpenIddictClientHandler { @@ -1860,7 +1859,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the presenter returned in the backchannel identity token, if applicable. + /// Contains the logic responsible for validating the presenter returned in the backchannel identity token, if applicable. /// public class ValidateBackchannelIdentityTokenPresenter : IOpenIddictClientHandler { @@ -1898,7 +1897,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the nonce returned in the backchannel identity token, if applicable. + /// Contains the logic responsible for validating the nonce returned in the backchannel identity token, if applicable. /// public class ValidateBackchannelIdentityTokenNonce : IOpenIddictClientHandler { @@ -1957,7 +1956,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the digests of the backchannel access token. + /// Contains the logic responsible for validating the digests of the backchannel access token. /// public class ValidateBackchannelTokenDigests : IOpenIddictClientHandler { @@ -2061,7 +2060,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the backchannel access token resolved from the context. + /// Contains the logic responsible for validating the backchannel access token resolved from the context. /// Note: this handler is typically not used for standard-compliant implementations as access tokens /// are supposed to be opaque to clients. /// @@ -2126,7 +2125,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the refresh token resolved from the context. + /// Contains the logic responsible for validating the refresh token resolved from the context. /// Note: this handler is typically not used for standard-compliant implementations as refresh tokens /// are supposed to be opaque to clients. /// @@ -2191,7 +2190,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of determining whether a userinfo token should be validated. + /// Contains the logic responsible for determining whether a userinfo token should be validated. /// public class EvaluateValidatedUserinfoToken : IOpenIddictClientHandler { @@ -2244,7 +2243,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the parameters to the userinfo request, if applicable. + /// Contains the logic responsible for attaching the parameters to the userinfo request, if applicable. /// public class AttachUserinfoRequestParameters : IOpenIddictClientHandler { @@ -2261,7 +2260,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessAuthenticationContext context!!) { - // Attach a new request instance if necessary. context.UserinfoRequest ??= new OpenIddictRequest(); @@ -2283,7 +2281,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of sending the userinfo request, if applicable. + /// Contains the logic responsible for sending the userinfo request, if applicable. /// public class SendUserinfoRequest : IOpenIddictClientHandler { @@ -2317,7 +2315,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting errored userinfo responses. + /// Contains the logic responsible for rejecting errored userinfo responses. /// public class ValidateUserinfoErrorParameters : IOpenIddictClientHandler { @@ -2351,7 +2349,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack the required userinfo token. + /// Contains the logic responsible for rejecting authentication demands that lack the required userinfo token. /// public class ValidateRequiredUserinfoToken : IOpenIddictClientHandler { @@ -2383,7 +2381,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the userinfo token resolved from the context. + /// Contains the logic responsible for validating the userinfo token resolved from the context. /// public class ValidateUserinfoToken : IOpenIddictClientHandler { @@ -2445,7 +2443,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the well-known claims contained in the userinfo token. + /// Contains the logic responsible for validating the well-known claims contained in the userinfo token. /// public class ValidateUserinfoTokenWellknownClaims : IOpenIddictClientHandler { @@ -2513,7 +2511,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of validating the subject claim contained in the userinfo token. + /// Contains the logic responsible for validating the subject claim contained in the userinfo token. /// public class ValidateUserinfoTokenSubject : IOpenIddictClientHandler { @@ -2594,7 +2592,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of rejecting invalid challenge demands. + /// Contains the logic responsible for rejecting invalid challenge demands. /// public class ValidateChallengeDemand : IOpenIddictClientHandler { @@ -2633,7 +2631,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the client registration applicable to the challenge demand. + /// Contains the logic responsible for resolving the client registration applicable to the challenge demand. /// public class ResolveClientRegistration : IOpenIddictClientHandler { @@ -2650,7 +2648,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Note: if the static registration cannot be found in the options, this may indicate // the client was removed after the authorization dance started and thus, can no longer // be used to authenticate users. In this case, throw an exception to abort the flow. @@ -2663,7 +2660,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of resolving the best grant type + /// Contains the logic responsible for resolving the best grant type /// supported by both the client and the authorization server. /// public class AttachGrantType : IOpenIddictClientHandler @@ -2748,7 +2745,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of selecting the token types that + /// Contains the logic responsible for selecting the token types that /// should be generated and optionally returned in the response. /// public class EvaluateGeneratedTokens : IOpenIddictClientHandler @@ -2766,7 +2763,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // In OpenIddict, per-authorization demand values are stored in an encrypted and signed token // called "state token", that allows flowing per-authorization demand data like the issuer // targeted by the authorization demand or secret values like the code verifier used to @@ -2789,7 +2785,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the response type to the challenge request. + /// Contains the logic responsible for attaching the response type to the challenge request. /// public class AttachResponseType : IOpenIddictClientHandler { @@ -2982,7 +2978,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the response mode to the challenge request. + /// Contains the logic responsible for attaching the response mode to the challenge request. /// public class AttachResponseMode : IOpenIddictClientHandler { @@ -3089,7 +3085,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the client identifier to the challenge request. + /// Contains the logic responsible for attaching the client identifier to the challenge request. /// public class AttachClientId : IOpenIddictClientHandler { @@ -3113,7 +3109,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the redirect_uri to the challenge request. + /// Contains the logic responsible for attaching the redirect_uri to the challenge request. /// public class AttachRedirectUri : IOpenIddictClientHandler { @@ -3130,7 +3126,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Unlike OpenID Connect, OAuth 2.0 and 2.1 don't require specifying a redirect_uri. // To keep OpenIddict compatible with OAuth 2.0/2.1 deployments, the redirect_uri // is not required for OAuth 2.0 requests but an exception will be thrown later @@ -3142,7 +3137,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the scopes to the challenge request. + /// Contains the logic responsible for attaching the scopes to the challenge request. /// public class AttachScopes : IOpenIddictClientHandler { @@ -3189,7 +3184,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching a request forgery protection to the authorization request. + /// Contains the logic responsible for attaching a request forgery protection to the authorization request. /// public class AttachRequestForgeryProtection : IOpenIddictClientHandler { @@ -3206,7 +3201,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Generate a new crypto-secure random identifier that will // be used as the non-guessable part of the state token. var data = new byte[256 / 8]; @@ -3223,7 +3217,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching a nonce to the authorization request. + /// Contains the logic responsible for attaching a nonce to the authorization request. /// public class AttachNonce : IOpenIddictClientHandler { @@ -3268,7 +3262,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the code challenge parameters to the authorization request. + /// Contains the logic responsible for attaching the code challenge parameters to the authorization request. /// public class AttachCodeChallengeParameters : IOpenIddictClientHandler { @@ -3285,7 +3279,6 @@ public static partial class OpenIddictClientHandlers /// public async ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Don't attach a code challenge method if no authorization code is requested as some implementations // (like OpenIddict server) are known to eagerly block authorization requests that specify an invalid // code_challenge/code_challenge_method/response_type combination (e.g response_type=id_token). @@ -3369,7 +3362,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the state token, if one is going to be returned. /// public class PrepareStateTokenPrincipal : IOpenIddictClientHandler @@ -3472,7 +3465,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of generating a state token for the current challenge operation. + /// Contains the logic responsible for generating a state token for the current challenge operation. /// public class GenerateStateToken : IOpenIddictClientHandler { @@ -3529,7 +3522,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of ensuring the redirect_uri parameter is present + /// Contains the logic responsible for ensuring the redirect_uri parameter is present /// if the "openid" scope is requested (indicating the request is an OpenID Connect request). /// public class ValidateRedirectUriParameter : IOpenIddictClientHandler @@ -3547,7 +3540,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // While OAuth 2.0/2.1 allows sending an authorization request without a redirect_uri, // doing so is illegal in OpenID Connect and such requests will always be rejected. // To make that requirement explicit, an exception is proactively thrown here. @@ -3561,7 +3553,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the challenge response. + /// Contains the logic responsible for attaching the appropriate parameters to the challenge response. /// public class AttachChallengeParameters : IOpenIddictClientHandler { @@ -3578,7 +3570,6 @@ public static partial class OpenIddictClientHandlers /// public ValueTask HandleAsync(ProcessChallengeContext context!!) { - // Note: while the exact order of the parameters has typically no effect on how requests // are handled by an authorization server, client_id and redirect_uri are deliberately // set first so that they appear early in the URL (when GET requests are used), making @@ -3618,7 +3609,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of extracting potential errors from the response. + /// Contains the logic responsible for extracting potential errors from the response. /// public class HandleErrorResponse : IOpenIddictClientHandler where TContext : BaseValidatingContext { @@ -3650,7 +3641,7 @@ public static partial class OpenIddictClientHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the error response. + /// Contains the logic responsible for attaching the appropriate parameters to the error response. /// public class AttachErrorParameters : IOpenIddictClientHandler { diff --git a/src/OpenIddict.Client/OpenIddictClientOptions.cs b/src/OpenIddict.Client/OpenIddictClientOptions.cs index a312d943..68ae34c2 100644 --- a/src/OpenIddict.Client/OpenIddictClientOptions.cs +++ b/src/OpenIddict.Client/OpenIddictClientOptions.cs @@ -15,7 +15,7 @@ namespace OpenIddict.Client; public class OpenIddictClientOptions { /// - /// Gets the list of the handlers responsible of processing the OpenIddict client operations. + /// Gets the list of the handlers responsible for processing the OpenIddict client operations. /// Note: the list is automatically sorted based on the order assigned to each handler descriptor. /// As such, it MUST NOT be mutated after options initialization to preserve the exact order. /// diff --git a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs index 98dc8390..7b302f88 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictApplicationManager.cs @@ -916,7 +916,6 @@ public class OpenIddictApplicationManager : IOpenIddictApplication public virtual async ValueTask UpdateAsync(TApplication application!!, OpenIddictApplicationDescriptor descriptor!!, CancellationToken cancellationToken = default) { - // Store the original client secret for later comparison. var comparand = await Store.GetClientSecretAsync(application, cancellationToken); await PopulateAsync(application, descriptor, cancellationToken); @@ -942,7 +941,6 @@ public class OpenIddictApplicationManager : IOpenIddictApplication public virtual async IAsyncEnumerable ValidateAsync( TApplication application!!, [EnumeratorCancellation] CancellationToken cancellationToken = default) { - // Ensure the client_id is not null or empty and is not already used for a different application. var identifier = await Store.GetClientIdAsync(application, cancellationToken); if (string.IsNullOrEmpty(identifier)) diff --git a/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs b/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs index b5f009be..c6dd6e27 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictScopeManager.cs @@ -750,7 +750,6 @@ public class OpenIddictScopeManager : IOpenIddictScopeManager where TSco public virtual async IAsyncEnumerable ValidateAsync( TScope scope!!, [EnumeratorCancellation] CancellationToken cancellationToken = default) { - // Ensure the name is not null or empty, does not contain a // space and is not already used for a different scope entity. var name = await Store.GetNameAsync(scope, cancellationToken); diff --git a/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs b/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs index 1d3a73bb..e803afba 100644 --- a/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs +++ b/src/OpenIddict.Core/Managers/OpenIddictTokenManager.cs @@ -1058,7 +1058,6 @@ public class OpenIddictTokenManager : IOpenIddictTokenManager where TTok public virtual async ValueTask UpdateAsync(TToken token!!, OpenIddictTokenDescriptor descriptor!!, CancellationToken cancellationToken = default) { - // Store the original reference identifier for later comparison. var comparand = await Store.GetReferenceIdAsync(token, cancellationToken); await PopulateAsync(token, descriptor, cancellationToken); diff --git a/src/OpenIddict.Quartz/OpenIddictQuartzJob.cs b/src/OpenIddict.Quartz/OpenIddictQuartzJob.cs index a8dc3499..be1d289d 100644 --- a/src/OpenIddict.Quartz/OpenIddictQuartzJob.cs +++ b/src/OpenIddict.Quartz/OpenIddictQuartzJob.cs @@ -52,7 +52,7 @@ public class OpenIddictQuartzJob : IJob try { - // Note: this background task is responsible of automatically removing orphaned tokens/authorizations + // Note: this background task is responsible for automatically removing orphaned tokens/authorizations // (i.e tokens that are no longer valid and ad-hoc authorizations that have no valid tokens associated). // Import: since tokens associated to ad-hoc authorizations are not removed as part of the same operation, // the tokens MUST be deleted before removing the ad-hoc authorizations that no longer have any token. diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs index abed35be..3a9fedd9 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Authentication.cs @@ -55,7 +55,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers ProcessLocalErrorResponse.Descriptor); /// - /// Contains the logic responsible of restoring cached requests from the request_id, if specified. + /// Contains the logic responsible for restoring cached requests from the request_id, if specified. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class RestoreCachedRequestParameters : IOpenIddictServerHandler @@ -147,7 +147,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of caching authorization requests, if applicable. + /// Contains the logic responsible for caching authorization requests, if applicable. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class CacheRequestParameters : IOpenIddictServerHandler @@ -240,7 +240,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of removing cached authorization requests from the distributed cache. + /// Contains the logic responsible for removing cached authorization requests from the distributed cache. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class RemoveCachedRequest : IOpenIddictServerHandler @@ -283,7 +283,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing authorization responses using the form_post response mode. + /// Contains the logic responsible for processing authorization responses using the form_post response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessFormPostResponse : IOpenIddictServerHandler @@ -369,7 +369,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing authorization responses using the query response mode. + /// Contains the logic responsible for processing authorization responses using the query response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessQueryResponse : IOpenIddictServerHandler @@ -435,7 +435,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing authorization responses using the fragment response mode. + /// Contains the logic responsible for processing authorization responses using the fragment response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessFragmentResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Device.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Device.cs index 7fcf5a41..d3ac363e 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Device.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Device.cs @@ -52,7 +52,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing verification responses that should trigger a host redirection. + /// Contains the logic responsible for processing verification responses that should trigger a host redirection. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessHostRedirectionResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs index bb997d11..d4206310 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.Session.cs @@ -52,7 +52,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers ProcessEmptyResponse.Descriptor); /// - /// Contains the logic responsible of restoring cached requests from the request_id, if specified. + /// Contains the logic responsible for restoring cached requests from the request_id, if specified. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class RestoreCachedRequestParameters : IOpenIddictServerHandler @@ -144,7 +144,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of caching logout requests, if applicable. + /// Contains the logic responsible for caching logout requests, if applicable. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class CacheRequestParameters : IOpenIddictServerHandler @@ -237,7 +237,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of removing cached logout requests from the distributed cache. + /// Contains the logic responsible for removing cached logout requests from the distributed cache. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class RemoveCachedRequest : IOpenIddictServerHandler @@ -280,7 +280,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing logout responses. + /// Contains the logic responsible for processing logout responses. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessQueryResponse : IOpenIddictServerHandler @@ -345,7 +345,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing logout responses that should trigger a host redirection. + /// Contains the logic responsible for processing logout responses that should trigger a host redirection. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessHostRedirectionResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.cs b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.cs index 158cde9d..34a80ce2 100644 --- a/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.cs +++ b/src/OpenIddict.Server.AspNetCore/OpenIddictServerAspNetCoreHandlers.cs @@ -54,7 +54,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers .AddRange(Userinfo.DefaultHandlers); /// - /// Contains the logic responsible of inferring the endpoint type from the request address. + /// Contains the logic responsible for inferring the endpoint type from the request address. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class InferEndpointType : IOpenIddictServerHandler @@ -152,7 +152,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of infering the issuer URL from the HTTP request host and validating it. + /// Contains the logic responsible for infering the issuer URL from the HTTP request host and validating it. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class InferIssuerFromHost : IOpenIddictServerHandler @@ -211,7 +211,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of rejecting OpenID Connect requests that don't use transport security. + /// Contains the logic responsible for rejecting OpenID Connect requests that don't use transport security. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ValidateTransportSecurityRequirement : IOpenIddictServerHandler @@ -258,7 +258,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of resolving the additional sign-in parameters stored in the ASP.NET + /// Contains the logic responsible for resolving the additional sign-in parameters stored in the ASP.NET /// Core authentication properties specified by the application that triggered the sign-in operation. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -329,7 +329,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of resolving the additional sign-in parameters stored in the ASP.NET + /// Contains the logic responsible for resolving the additional sign-in parameters stored in the ASP.NET /// Core authentication properties specified by the application that triggered the sign-in operation. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -376,7 +376,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of resolving the additional sign-out parameters stored in the ASP.NET + /// Contains the logic responsible for resolving the additional sign-out parameters stored in the ASP.NET /// Core authentication properties specified by the application that triggered the sign-out operation. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -423,7 +423,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractGetRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -469,7 +469,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET or POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET or POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractGetOrPostRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -544,7 +544,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractPostRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -614,7 +614,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting client credentials from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting client credentials from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractBasicAuthenticationCredentials : IOpenIddictServerHandler @@ -708,7 +708,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting an access token from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting an access token from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractAccessToken : IOpenIddictServerHandler @@ -749,7 +749,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of enabling the pass-through mode for the received request. + /// Contains the logic responsible for enabling the pass-through mode for the received request. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class EnablePassthroughMode : IOpenIddictServerHandler @@ -778,7 +778,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching an appropriate HTTP status code. + /// Contains the logic responsible for attaching an appropriate HTTP status code. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachHttpResponseCode : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -827,7 +827,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching the appropriate HTTP response cache headers. + /// Contains the logic responsible for attaching the appropriate HTTP response cache headers. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachCacheControlHeader : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -861,7 +861,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching errors details to the WWW-Authenticate header. + /// Contains the logic responsible for attaching errors details to the WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachWwwAuthenticateHeader : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -972,7 +972,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing challenge responses that contain a WWW-Authenticate header. + /// Contains the logic responsible for processing challenge responses that contain a WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessChallengeErrorResponse : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -1010,7 +1010,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be returned as JSON. + /// Contains the logic responsible for processing OpenID Connect responses that must be returned as JSON. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessJsonResponse : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -1059,7 +1059,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be handled by another + /// Contains the logic responsible for processing OpenID Connect responses that must be handled by another /// middleware in the pipeline at a later stage (e.g an ASP.NET Core MVC action or a NancyFX module). /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// @@ -1102,7 +1102,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses handled by the status code pages middleware. + /// Contains the logic responsible for processing OpenID Connect responses handled by the status code pages middleware. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessStatusCodePagesErrorResponse : IOpenIddictServerHandler @@ -1154,7 +1154,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing context responses that must be returned as plain-text. + /// Contains the logic responsible for processing context responses that must be returned as plain-text. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessLocalErrorResponse : IOpenIddictServerHandler @@ -1223,7 +1223,7 @@ public static partial class OpenIddictServerAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that don't specify any parameter. + /// Contains the logic responsible for processing OpenID Connect responses that don't specify any parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessEmptyResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionHandlers.Protection.cs b/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionHandlers.Protection.cs index 4ca1a965..c6826581 100644 --- a/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionHandlers.Protection.cs +++ b/src/OpenIddict.Server.DataProtection/OpenIddictServerDataProtectionHandlers.Protection.cs @@ -32,7 +32,7 @@ public static partial class OpenIddictServerDataProtectionHandlers GenerateDataProtectionToken.Descriptor); /// - /// Contains the logic responsible of validating tokens generated using Data Protection. + /// Contains the logic responsible for validating tokens generated using Data Protection. /// public class ValidateDataProtectionToken : IOpenIddictServerHandler { @@ -232,7 +232,7 @@ public static partial class OpenIddictServerDataProtectionHandlers } /// - /// Contains the logic responsible of generating a token using Data Protection. + /// Contains the logic responsible for generating a token using Data Protection. /// public class GenerateDataProtectionToken : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Authentication.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Authentication.cs index 735ec08d..67857fee 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Authentication.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Authentication.cs @@ -52,7 +52,7 @@ public static partial class OpenIddictServerOwinHandlers ProcessLocalErrorResponse.Descriptor); /// - /// Contains the logic responsible of restoring cached requests from the request_id, if specified. + /// Contains the logic responsible for restoring cached requests from the request_id, if specified. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class RestoreCachedRequestParameters : IOpenIddictServerHandler @@ -144,7 +144,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of caching authorization requests, if applicable. + /// Contains the logic responsible for caching authorization requests, if applicable. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class CacheRequestParameters : IOpenIddictServerHandler @@ -232,7 +232,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of removing cached authorization requests from the distributed cache. + /// Contains the logic responsible for removing cached authorization requests from the distributed cache. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class RemoveCachedRequest : IOpenIddictServerHandler @@ -275,7 +275,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing authorization responses using the form_post response mode. + /// Contains the logic responsible for processing authorization responses using the form_post response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessFormPostResponse : IOpenIddictServerHandler @@ -361,7 +361,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing authorization responses using the query response mode. + /// Contains the logic responsible for processing authorization responses using the query response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessQueryResponse : IOpenIddictServerHandler @@ -417,7 +417,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing authorization responses using the fragment response mode. + /// Contains the logic responsible for processing authorization responses using the fragment response mode. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessFragmentResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Device.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Device.cs index ba6b7960..d3cf300c 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Device.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Device.cs @@ -51,7 +51,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing verification responses that should trigger a host redirection. + /// Contains the logic responsible for processing verification responses that should trigger a host redirection. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessHostRedirectionResponse : IOpenIddictServerHandler @@ -84,7 +84,7 @@ public static partial class OpenIddictServerOwinHandlers } var properties = context.Transaction.GetProperty(typeof(AuthenticationProperties).FullName!); - if (properties is not null && !string.IsNullOrEmpty(properties.RedirectUri)) + if (!string.IsNullOrEmpty(properties?.RedirectUri)) { response.Redirect(properties.RedirectUri); diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Session.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Session.cs index 7c4cc8c6..27eb5f29 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Session.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.Session.cs @@ -50,7 +50,7 @@ public static partial class OpenIddictServerOwinHandlers ProcessEmptyResponse.Descriptor); /// - /// Contains the logic responsible of restoring cached requests from the request_id, if specified. + /// Contains the logic responsible for restoring cached requests from the request_id, if specified. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class RestoreCachedRequestParameters : IOpenIddictServerHandler @@ -142,7 +142,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of caching logout requests, if applicable. + /// Contains the logic responsible for caching logout requests, if applicable. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class CacheRequestParameters : IOpenIddictServerHandler @@ -230,7 +230,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of removing cached logout requests from the distributed cache. + /// Contains the logic responsible for removing cached logout requests from the distributed cache. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class RemoveCachedRequest : IOpenIddictServerHandler @@ -273,7 +273,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing logout responses. + /// Contains the logic responsible for processing logout responses. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessQueryResponse : IOpenIddictServerHandler @@ -328,7 +328,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing logout responses that should trigger a host redirection. + /// Contains the logic responsible for processing logout responses that should trigger a host redirection. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessHostRedirectionResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.cs b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.cs index 1310ed9c..50cc2d38 100644 --- a/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.cs +++ b/src/OpenIddict.Server.Owin/OpenIddictServerOwinHandlers.cs @@ -43,7 +43,7 @@ public static partial class OpenIddictServerOwinHandlers .AddRange(Userinfo.DefaultHandlers); /// - /// Contains the logic responsible of inferring the endpoint type from the request address. + /// Contains the logic responsible for inferring the endpoint type from the request address. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class InferEndpointType : IOpenIddictServerHandler @@ -143,7 +143,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of infering the issuer URL from the HTTP request host and validating it. + /// Contains the logic responsible for infering the issuer URL from the HTTP request host and validating it. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class InferIssuerFromHost : IOpenIddictServerHandler @@ -202,7 +202,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of rejecting OpenID Connect requests that don't use transport security. + /// Contains the logic responsible for rejecting OpenID Connect requests that don't use transport security. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ValidateTransportSecurityRequirement : IOpenIddictServerHandler @@ -249,7 +249,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of resolving the additional sign-in parameters stored in the OWIN + /// Contains the logic responsible for resolving the additional sign-in parameters stored in the OWIN /// authentication properties specified by the application that triggered the sign-in operation. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// @@ -304,7 +304,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractGetRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -350,7 +350,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from GET or POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from GET or POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractGetOrPostRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -425,7 +425,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of extracting OpenID Connect requests from POST HTTP requests. + /// Contains the logic responsible for extracting OpenID Connect requests from POST HTTP requests. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractPostRequest : IOpenIddictServerHandler where TContext : BaseValidatingContext @@ -495,7 +495,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of extracting client credentials from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting client credentials from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractBasicAuthenticationCredentials : IOpenIddictServerHandler @@ -589,7 +589,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of extracting an access token from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting an access token from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractAccessToken : IOpenIddictServerHandler @@ -630,7 +630,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of enabling the pass-through mode for the received request. + /// Contains the logic responsible for enabling the pass-through mode for the received request. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class EnablePassthroughMode : IOpenIddictServerHandler @@ -659,7 +659,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of attaching an appropriate HTTP status code. + /// Contains the logic responsible for attaching an appropriate HTTP status code. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachHttpResponseCode : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -708,7 +708,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of attaching the appropriate HTTP response cache headers. + /// Contains the logic responsible for attaching the appropriate HTTP response cache headers. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachCacheControlHeader : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -742,7 +742,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of attaching errors details to the WWW-Authenticate header. + /// Contains the logic responsible for attaching errors details to the WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachWwwAuthenticateHeader : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -853,7 +853,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing challenge responses that contain a WWW-Authenticate header. + /// Contains the logic responsible for processing challenge responses that contain a WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessChallengeErrorResponse : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -891,7 +891,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be returned as JSON. + /// Contains the logic responsible for processing OpenID Connect responses that must be returned as JSON. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessJsonResponse : IOpenIddictServerHandler where TContext : BaseRequestContext @@ -940,7 +940,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be handled by another + /// Contains the logic responsible for processing OpenID Connect responses that must be handled by another /// middleware in the pipeline at a later stage (e.g an ASP.NET MVC action or a NancyFX module). /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// @@ -986,7 +986,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be returned as plain-text. + /// Contains the logic responsible for processing OpenID Connect responses that must be returned as plain-text. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessLocalErrorResponse : IOpenIddictServerHandler @@ -1055,7 +1055,7 @@ public static partial class OpenIddictServerOwinHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that don't specify any parameter. + /// Contains the logic responsible for processing OpenID Connect responses that don't specify any parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessEmptyResponse : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server/OpenIddictServerConfiguration.cs b/src/OpenIddict.Server/OpenIddictServerConfiguration.cs index 275458f4..afc48590 100644 --- a/src/OpenIddict.Server/OpenIddictServerConfiguration.cs +++ b/src/OpenIddict.Server/OpenIddictServerConfiguration.cs @@ -23,7 +23,6 @@ public class OpenIddictServerConfiguration : IPostConfigureOptionsThe options instance to initialize. public void PostConfigure(string name, OpenIddictServerOptions options!!) { - // Explicitly disable all the features that are implicitly excluded when the degraded mode is active. if (options.EnableDegradedMode) { diff --git a/src/OpenIddict.Server/OpenIddictServerEvents.cs b/src/OpenIddict.Server/OpenIddictServerEvents.cs index d8fcacce..3028d37f 100644 --- a/src/OpenIddict.Server/OpenIddictServerEvents.cs +++ b/src/OpenIddict.Server/OpenIddictServerEvents.cs @@ -48,7 +48,7 @@ public static partial class OpenIddictServerEvents } /// - /// Gets the logger responsible of logging processed operations. + /// Gets the logger responsible for logging processed operations. /// public ILogger Logger => Transaction.Logger; diff --git a/src/OpenIddict.Server/OpenIddictServerHandlerDescriptor.cs b/src/OpenIddict.Server/OpenIddictServerHandlerDescriptor.cs index c42ca463..5c46c80b 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlerDescriptor.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlerDescriptor.cs @@ -28,7 +28,7 @@ public class OpenIddictServerHandlerDescriptor public Type ContextType { get; private set; } = default!; /// - /// Gets the list of filters responsible of excluding the handler + /// Gets the list of filters responsible for excluding the handler /// from the activated handlers if it doesn't meet the criteria. /// public ImmutableArray FilterTypes { get; private set; } = ImmutableArray.Create(); diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs index 46dac199..b853f67b 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs @@ -60,7 +60,7 @@ public static partial class OpenIddictServerHandlers AttachIssuer.Descriptor); /// - /// Contains the logic responsible of extracting authorization requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting authorization requests and invoking the corresponding event handlers. /// public class ExtractAuthorizationRequest : IOpenIddictServerHandler { @@ -117,7 +117,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating authorization requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating authorization requests and invoking the corresponding event handlers. /// public class ValidateAuthorizationRequest : IOpenIddictServerHandler { @@ -178,7 +178,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling authorization requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling authorization requests and invoking the corresponding event handlers. /// public class HandleAuthorizationRequest : IOpenIddictServerHandler { @@ -270,7 +270,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyAuthorizationResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -313,7 +313,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that specify the unsupported request parameter. + /// Contains the logic responsible for rejecting authorization requests that specify the unsupported request parameter. /// public class ValidateRequestParameter : IOpenIddictServerHandler { @@ -330,7 +330,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject requests using the unsupported request parameter. if (!string.IsNullOrEmpty(context.Request.Request)) { @@ -349,7 +348,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that specify the unsupported request_uri parameter. + /// Contains the logic responsible for rejecting authorization requests that specify the unsupported request_uri parameter. /// public class ValidateRequestUriParameter : IOpenIddictServerHandler { @@ -366,7 +365,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject requests using the unsupported request_uri parameter. if (!string.IsNullOrEmpty(context.Request.RequestUri)) { @@ -385,7 +383,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that lack the mandatory client_id parameter. + /// Contains the logic responsible for rejecting authorization requests that lack the mandatory client_id parameter. /// public class ValidateClientIdParameter : IOpenIddictServerHandler { @@ -402,7 +400,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // client_id is a required parameter and MUST cause an error when missing. // See http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest. if (string.IsNullOrEmpty(context.ClientId)) @@ -422,7 +419,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that lack the mandatory redirect_uri parameter. + /// Contains the logic responsible for rejecting authorization requests that lack the mandatory redirect_uri parameter. /// public class ValidateRedirectUriParameter : IOpenIddictServerHandler { @@ -439,7 +436,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // While redirect_uri was not mandatory in OAuth 2.0, this parameter // is now declared as REQUIRED and MUST cause an error when missing. // See http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest. @@ -523,7 +519,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that specify an invalid response_type parameter. + /// Contains the logic responsible for rejecting authorization requests that specify an invalid response_type parameter. /// public class ValidateResponseTypeParameter : IOpenIddictServerHandler { @@ -540,7 +536,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject requests missing the mandatory response_type parameter. if (string.IsNullOrEmpty(context.Request.ResponseType)) { @@ -614,7 +609,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that specify an invalid response_mode parameter. + /// Contains the logic responsible for rejecting authorization requests that specify an invalid response_mode parameter. /// public class ValidateResponseModeParameter : IOpenIddictServerHandler { @@ -631,7 +626,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // response_mode=query (explicit or not) and a response_type containing id_token // or token are not considered as a safe combination and MUST be rejected. // See http://openid.net/specs/oauth-v2-multiple-response-types-1_0.html#Security. @@ -692,7 +686,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that don't specify a valid scope parameter. + /// Contains the logic responsible for rejecting authorization requests that don't specify a valid scope parameter. /// public class ValidateScopeParameter : IOpenIddictServerHandler { @@ -709,7 +703,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject authorization requests containing the id_token response_type if no openid scope has been received. if (context.Request.HasResponseType(ResponseTypes.IdToken) && !context.Request.HasScope(Scopes.OpenId)) { @@ -739,7 +732,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that don't specify a nonce. + /// Contains the logic responsible for rejecting authorization requests that don't specify a nonce. /// public class ValidateNonceParameter : IOpenIddictServerHandler { @@ -756,7 +749,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject OpenID Connect implicit/hybrid requests missing the mandatory nonce parameter. // See http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest, // http://openid.net/specs/openid-connect-implicit-1_0.html#RequestParameters @@ -784,7 +776,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that don't specify a valid prompt parameter. + /// Contains the logic responsible for rejecting authorization requests that don't specify a valid prompt parameter. /// public class ValidatePromptParameter : IOpenIddictServerHandler { @@ -801,7 +793,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateAuthorizationRequestContext context!!) { - // Reject requests specifying prompt=none with consent/login or select_account. if (context.Request.HasPrompt(Prompts.None) && (context.Request.HasPrompt(Prompts.Consent) || context.Request.HasPrompt(Prompts.Login) || @@ -822,7 +813,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that don't specify valid PKCE parameters. + /// Contains the logic responsible for rejecting authorization requests that don't specify valid PKCE parameters. /// public class ValidateProofKeyForCodeExchangeParameters : IOpenIddictServerHandler { @@ -936,7 +927,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use an invalid client_id. + /// Contains the logic responsible for rejecting authorization requests that use an invalid client_id. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientId : IOpenIddictServerHandler @@ -980,7 +971,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use a + /// Contains the logic responsible for rejecting authorization requests that use a /// response_type containing token if the application is a confidential client. /// Note: this handler is not used when the degraded mode is enabled /// or when response type permissions enforcement is not disabled. @@ -1042,7 +1033,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use an invalid redirect_uri. + /// Contains the logic responsible for rejecting authorization requests that use an invalid redirect_uri. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientRedirectUri : IOpenIddictServerHandler @@ -1114,7 +1105,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use unregistered scopes. + /// Contains the logic responsible for rejecting authorization requests that use unregistered scopes. /// Note: this handler partially works with the degraded mode but is not used when scope validation is disabled. /// public class ValidateScopes : IOpenIddictServerHandler @@ -1188,7 +1179,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests made by unauthorized applications. + /// Contains the logic responsible for rejecting authorization requests made by unauthorized applications. /// Note: this handler is not used when the degraded mode is enabled or when endpoint permissions are disabled. /// public class ValidateEndpointPermissions : IOpenIddictServerHandler @@ -1239,7 +1230,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests made by unauthorized applications. + /// Contains the logic responsible for rejecting authorization requests made by unauthorized applications. /// Note: this handler is not used when the degraded mode is enabled or when grant type permissions are disabled. /// public class ValidateGrantTypePermissions : IOpenIddictServerHandler @@ -1335,7 +1326,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests made by unauthorized applications. + /// Contains the logic responsible for rejecting authorization requests made by unauthorized applications. /// Note: this handler is not used when the degraded mode is enabled or when grant type permissions are disabled. /// public class ValidateResponseTypePermissions : IOpenIddictServerHandler @@ -1413,7 +1404,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests made by unauthorized applications. + /// Contains the logic responsible for rejecting authorization requests made by unauthorized applications. /// Note: this handler is not used when the degraded mode is enabled or when scope permissions are disabled. /// public class ValidateScopePermissions : IOpenIddictServerHandler @@ -1474,7 +1465,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests made by + /// Contains the logic responsible for rejecting authorization requests made by /// applications for which proof key for code exchange (PKCE) was enforced. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -1531,7 +1522,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of inferring the redirect URL + /// Contains the logic responsible for inferring the redirect URL /// used to send the response back to the client application. /// public class AttachRedirectUri : IOpenIddictServerHandler @@ -1569,7 +1560,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of inferring the response mode + /// Contains the logic responsible for inferring the response mode /// used to send the response back to the client application. /// public class InferResponseMode : IOpenIddictServerHandler @@ -1607,7 +1598,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the state to the response. + /// Contains the logic responsible for attaching the state to the response. /// public class AttachResponseState : IOpenIddictServerHandler { @@ -1638,7 +1629,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching an "iss" parameter + /// Contains the logic responsible for attaching an "iss" parameter /// containing the address of the authorization server to the response. /// public class AttachIssuer : IOpenIddictServerHandler diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs index c07d6c78..15e7b593 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs @@ -59,7 +59,7 @@ public static partial class OpenIddictServerHandlers AttachUserCodePrincipal.Descriptor); /// - /// Contains the logic responsible of extracting device requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting device requests and invoking the corresponding event handlers. /// public class ExtractDeviceRequest : IOpenIddictServerHandler { @@ -116,7 +116,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating device requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating device requests and invoking the corresponding event handlers. /// public class ValidateDeviceRequest : IOpenIddictServerHandler { @@ -168,7 +168,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling device requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling device requests and invoking the corresponding event handlers. /// public class HandleDeviceRequest : IOpenIddictServerHandler { @@ -264,7 +264,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyDeviceResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -307,7 +307,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests that don't specify a client identifier. + /// Contains the logic responsible for rejecting device requests that don't specify a client identifier. /// public class ValidateClientIdParameter : IOpenIddictServerHandler { @@ -324,7 +324,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateDeviceRequestContext context!!) { - // client_id is a required parameter and MUST cause an error when missing. // See https://tools.ietf.org/html/rfc8628#section-3.1 for more information. if (string.IsNullOrEmpty(context.ClientId)) @@ -344,7 +343,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests that don't specify a valid scope parameter. + /// Contains the logic responsible for rejecting device requests that don't specify a valid scope parameter. /// public class ValidateScopeParameter : IOpenIddictServerHandler { @@ -361,7 +360,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateDeviceRequestContext context!!) { - // Reject device requests that specify scope=offline_access if the refresh token flow is not enabled. if (context.Request.HasScope(Scopes.OfflineAccess) && !context.Options.GrantTypes.Contains(GrantTypes.RefreshToken)) { @@ -378,7 +376,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use unregistered scopes. + /// Contains the logic responsible for rejecting authorization requests that use unregistered scopes. /// Note: this handler partially works with the degraded mode but is not used when scope validation is disabled. /// public class ValidateScopes : IOpenIddictServerHandler @@ -452,7 +450,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests that use an invalid client_id. + /// Contains the logic responsible for rejecting device requests that use an invalid client_id. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientId : IOpenIddictServerHandler @@ -499,7 +497,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests made by applications + /// Contains the logic responsible for rejecting device requests made by applications /// whose client type is not compatible with the requested grant type. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -569,7 +567,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests specifying an invalid client secret. + /// Contains the logic responsible for rejecting device requests specifying an invalid client secret. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientSecret : IOpenIddictServerHandler @@ -627,7 +625,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests made by + /// Contains the logic responsible for rejecting device requests made by /// applications that haven't been granted the device endpoint permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -680,7 +678,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests made by unauthorized applications. + /// Contains the logic responsible for rejecting device requests made by unauthorized applications. /// Note: this handler is not used when the degraded mode is enabled or when grant type permissions are disabled. /// public class ValidateGrantTypePermissions : IOpenIddictServerHandler @@ -746,7 +744,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting device requests made by applications + /// Contains the logic responsible for rejecting device requests made by applications /// that haven't been granted the appropriate grant type permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -809,7 +807,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of extracting verification requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting verification requests and invoking the corresponding event handlers. /// public class ExtractVerificationRequest : IOpenIddictServerHandler { @@ -866,7 +864,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating verification requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating verification requests and invoking the corresponding event handlers. /// public class ValidateVerificationRequest : IOpenIddictServerHandler { @@ -918,7 +916,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling verification requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling verification requests and invoking the corresponding event handlers. /// public class HandleVerificationRequest : IOpenIddictServerHandler { @@ -1010,7 +1008,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyVerificationResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -1053,7 +1051,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the claims principal resolved from the user code. + /// Contains the logic responsible for attaching the claims principal resolved from the user code. /// public class AttachUserCodePrincipal : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Discovery.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Discovery.cs index 42632b1a..497f3702 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Discovery.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Discovery.cs @@ -58,7 +58,7 @@ public static partial class OpenIddictServerHandlers AttachSigningKeys.Descriptor); /// - /// Contains the logic responsible of extracting configuration requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting configuration requests and invoking the corresponding event handlers. /// public class ExtractConfigurationRequest : IOpenIddictServerHandler { @@ -115,7 +115,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating configuration requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating configuration requests and invoking the corresponding event handlers. /// public class ValidateConfigurationRequest : IOpenIddictServerHandler { @@ -167,7 +167,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling configuration requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling configuration requests and invoking the corresponding event handlers. /// public class HandleConfigurationRequest : IOpenIddictServerHandler { @@ -248,7 +248,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing configuration responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing configuration responses and invoking the corresponding event handlers. /// public class ApplyConfigurationResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -291,7 +291,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the endpoint URLs to the provider discovery document. + /// Contains the logic responsible for attaching the endpoint URLs to the provider discovery document. /// public class AttachEndpoints : IOpenIddictServerHandler { @@ -377,7 +377,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported grant types to the provider discovery document. + /// Contains the logic responsible for attaching the supported grant types to the provider discovery document. /// public class AttachGrantTypes : IOpenIddictServerHandler { @@ -401,7 +401,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported response modes to the provider discovery document. + /// Contains the logic responsible for attaching the supported response modes to the provider discovery document. /// public class AttachResponseModes : IOpenIddictServerHandler { @@ -425,7 +425,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported response types to the provider discovery document. + /// Contains the logic responsible for attaching the supported response types to the provider discovery document. /// public class AttachResponseTypes : IOpenIddictServerHandler { @@ -449,7 +449,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported client + /// Contains the logic responsible for attaching the supported client /// authentication methods to the provider discovery document. /// public class AttachClientAuthenticationMethods : IOpenIddictServerHandler @@ -490,7 +490,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported + /// Contains the logic responsible for attaching the supported /// code challenge methods to the provider discovery document. /// public class AttachCodeChallengeMethods : IOpenIddictServerHandler @@ -515,7 +515,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported response types to the provider discovery document. + /// Contains the logic responsible for attaching the supported response types to the provider discovery document. /// public class AttachScopes : IOpenIddictServerHandler { @@ -539,7 +539,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported claims to the provider discovery document. + /// Contains the logic responsible for attaching the supported claims to the provider discovery document. /// public class AttachClaims : IOpenIddictServerHandler { @@ -563,7 +563,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported subject types to the provider discovery document. + /// Contains the logic responsible for attaching the supported subject types to the provider discovery document. /// public class AttachSubjectTypes : IOpenIddictServerHandler { @@ -587,7 +587,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the supported signing algorithms to the provider discovery document. + /// Contains the logic responsible for attaching the supported signing algorithms to the provider discovery document. /// public class AttachSigningAlgorithms : IOpenIddictServerHandler { @@ -648,7 +648,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching additional metadata to the provider discovery document. + /// Contains the logic responsible for attaching additional metadata to the provider discovery document. /// public class AttachAdditionalMetadata : IOpenIddictServerHandler { @@ -681,7 +681,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of extracting cryptography requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting cryptography requests and invoking the corresponding event handlers. /// public class ExtractCryptographyRequest : IOpenIddictServerHandler { @@ -738,7 +738,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating cryptography requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating cryptography requests and invoking the corresponding event handlers. /// public class ValidateCryptographyRequest : IOpenIddictServerHandler { @@ -790,7 +790,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling cryptography requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling cryptography requests and invoking the corresponding event handlers. /// public class HandleCryptographyRequest : IOpenIddictServerHandler { @@ -913,7 +913,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing cryptography responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing cryptography responses and invoking the corresponding event handlers. /// public class ApplyCryptographyResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -956,7 +956,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the signing keys to the JWKS document. + /// Contains the logic responsible for attaching the signing keys to the JWKS document. /// public class AttachSigningKeys : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs index b7950f6a..ddf4d6af 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs @@ -72,7 +72,7 @@ public static partial class OpenIddictServerHandlers NormalizeErrorResponse.Descriptor); /// - /// Contains the logic responsible of extracting token requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting token requests and invoking the corresponding event handlers. /// public class ExtractTokenRequest : IOpenIddictServerHandler { @@ -129,7 +129,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating token requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating token requests and invoking the corresponding event handlers. /// public class ValidateTokenRequest : IOpenIddictServerHandler { @@ -185,7 +185,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling token requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling token requests and invoking the corresponding event handlers. /// public class HandleTokenRequest : IOpenIddictServerHandler { @@ -277,7 +277,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyTokenResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -320,7 +320,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that specify an invalid grant type. + /// Contains the logic responsible for rejecting token requests that specify an invalid grant type. /// public class ValidateGrantType : IOpenIddictServerHandler { @@ -337,7 +337,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject token requests missing the mandatory grant_type parameter. if (string.IsNullOrEmpty(context.Request.GrantType)) { @@ -381,7 +380,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that don't specify a client identifier. + /// Contains the logic responsible for rejecting token requests that don't specify a client identifier. /// public class ValidateClientIdParameter : IOpenIddictServerHandler { @@ -425,7 +424,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that don't + /// Contains the logic responsible for rejecting token requests that don't /// specify an authorization code for the authorization code grant type. /// public class ValidateAuthorizationCodeParameter : IOpenIddictServerHandler @@ -443,7 +442,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject grant_type=authorization_code requests missing the authorization code. // See https://tools.ietf.org/html/rfc6749#section-4.1.3 for more information. if (context.Request.IsAuthorizationCodeGrantType() && string.IsNullOrEmpty(context.Request.Code)) @@ -463,7 +461,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that don't + /// Contains the logic responsible for rejecting token requests that don't /// specify client credentials for the client credentials grant type. /// public class ValidateClientCredentialsParameters : IOpenIddictServerHandler @@ -481,7 +479,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject grant_type=client_credentials requests missing the client credentials. // See https://tools.ietf.org/html/rfc6749#section-4.4.1 for more information. if (context.Request.IsClientCredentialsGrantType() && (string.IsNullOrEmpty(context.Request.ClientId) || @@ -500,7 +497,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that + /// Contains the logic responsible for rejecting token requests that /// don't specify a device code for the device code grant type. /// public class ValidateDeviceCodeParameter : IOpenIddictServerHandler @@ -518,7 +515,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject grant_type=urn:ietf:params:oauth:grant-type:device_code requests missing the device code. // See https://tools.ietf.org/html/rfc8628#section-3.4 for more information. if (context.Request.IsDeviceCodeGrantType() && string.IsNullOrEmpty(context.Request.DeviceCode)) @@ -536,7 +532,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that + /// Contains the logic responsible for rejecting token requests that /// specify invalid parameters for the refresh token grant type. /// public class ValidateRefreshTokenParameter : IOpenIddictServerHandler @@ -554,7 +550,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject grant_type=refresh_token requests missing the refresh token. // See https://tools.ietf.org/html/rfc6749#section-6 for more information. if (context.Request.IsRefreshTokenGrantType() && string.IsNullOrEmpty(context.Request.RefreshToken)) @@ -574,7 +569,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests + /// Contains the logic responsible for rejecting token requests /// that specify invalid parameters for the password grant type. /// public class ValidateResourceOwnerCredentialsParameters : IOpenIddictServerHandler @@ -592,7 +587,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateTokenRequestContext context!!) { - // Reject grant_type=password requests missing username or password. // See https://tools.ietf.org/html/rfc6749#section-4.3.2 for more information. if (context.Request.IsPasswordGrantType() && (string.IsNullOrEmpty(context.Request.Username) || @@ -613,7 +607,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that don't specify valid PKCE parameters. + /// Contains the logic responsible for rejecting token requests that don't specify valid PKCE parameters. /// public class ValidateProofKeyForCodeExchangeParameters : IOpenIddictServerHandler { @@ -656,7 +650,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authorization requests that use unregistered scopes. + /// Contains the logic responsible for rejecting authorization requests that use unregistered scopes. /// Note: this handler partially works with the degraded mode but is not used when scope validation is disabled. /// public class ValidateScopes : IOpenIddictServerHandler @@ -730,7 +724,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that use an invalid client_id. + /// Contains the logic responsible for rejecting token requests that use an invalid client_id. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientId : IOpenIddictServerHandler @@ -777,7 +771,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests made by applications + /// Contains the logic responsible for rejecting token requests made by applications /// whose client type is not compatible with the requested grant type. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -860,7 +854,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests specifying an invalid client secret. + /// Contains the logic responsible for rejecting token requests specifying an invalid client secret. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientSecret : IOpenIddictServerHandler @@ -918,7 +912,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests made by + /// Contains the logic responsible for rejecting token requests made by /// applications that haven't been granted the token endpoint permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -971,7 +965,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests made by applications + /// Contains the logic responsible for rejecting token requests made by applications /// that haven't been granted the appropriate grant type permissions. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -1039,7 +1033,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests made by applications + /// Contains the logic responsible for rejecting token requests made by applications /// that haven't been granted the appropriate grant type permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -1102,7 +1096,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests made by + /// Contains the logic responsible for rejecting token requests made by /// applications for which proof key for code exchange (PKCE) was enforced. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -1165,7 +1159,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that don't + /// Contains the logic responsible for rejecting token requests that don't /// specify a valid authorization code, device code or refresh token. /// public class ValidateToken : IOpenIddictServerHandler @@ -1231,7 +1225,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that use an authorization code, + /// Contains the logic responsible for rejecting token requests that use an authorization code, /// a device code or a refresh token that was issued for a different client application. /// public class ValidatePresenters : IOpenIddictServerHandler @@ -1319,7 +1313,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that specify an invalid redirect_uri. + /// Contains the logic responsible for rejecting token requests that specify an invalid redirect_uri. /// public class ValidateRedirectUri : IOpenIddictServerHandler { @@ -1385,7 +1379,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that specify an invalid code verifier. + /// Contains the logic responsible for rejecting token requests that specify an invalid code verifier. /// public class ValidateCodeVerifier : IOpenIddictServerHandler { @@ -1498,7 +1492,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting token requests that specify scopes that + /// Contains the logic responsible for rejecting token requests that specify scopes that /// were not initially granted by the resource owner during the authorization request. /// public class ValidateGrantedScopes : IOpenIddictServerHandler @@ -1565,7 +1559,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the principal extracted + /// Contains the logic responsible for attaching the principal extracted /// from the authorization code/refresh token to the event context. /// public class AttachPrincipal : IOpenIddictServerHandler @@ -1599,7 +1593,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of converting token errors to standard invalid_grant responses. + /// Contains the logic responsible for converting token errors to standard invalid_grant responses. /// public class NormalizeErrorResponse : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Introspection.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Introspection.cs index 33237c84..f8c4d5fd 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Introspection.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Introspection.cs @@ -57,7 +57,7 @@ public static partial class OpenIddictServerHandlers NormalizeErrorResponse.Descriptor); /// - /// Contains the logic responsible of extracting introspection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting introspection requests and invoking the corresponding event handlers. /// public class ExtractIntrospectionRequest : IOpenIddictServerHandler { @@ -114,7 +114,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating introspection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating introspection requests and invoking the corresponding event handlers. /// public class ValidateIntrospectionRequest : IOpenIddictServerHandler { @@ -170,7 +170,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling introspection requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling introspection requests and invoking the corresponding event handlers. /// public class HandleIntrospectionRequest : IOpenIddictServerHandler { @@ -268,7 +268,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyIntrospectionResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -311,7 +311,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that don't specify a token. + /// Contains the logic responsible for rejecting introspection requests that don't specify a token. /// public class ValidateTokenParameter : IOpenIddictServerHandler { @@ -328,7 +328,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateIntrospectionRequestContext context!!) { - // Reject introspection requests missing the mandatory token parameter. if (string.IsNullOrEmpty(context.Request.Token)) { @@ -347,7 +346,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that don't specify a client identifier. + /// Contains the logic responsible for rejecting introspection requests that don't specify a client identifier. /// public class ValidateClientIdParameter : IOpenIddictServerHandler { @@ -364,7 +363,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateIntrospectionRequestContext context!!) { - // At this stage, reject the introspection request unless the client identification requirement was disabled. if (!context.Options.AcceptAnonymousClients && string.IsNullOrEmpty(context.ClientId)) { @@ -383,7 +381,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that use an invalid client_id. + /// Contains the logic responsible for rejecting introspection requests that use an invalid client_id. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientId : IOpenIddictServerHandler @@ -430,7 +428,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests made by applications + /// Contains the logic responsible for rejecting introspection requests made by applications /// whose client type is not compatible with the presence or absence of a client secret. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -500,7 +498,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests specifying an invalid client secret. + /// Contains the logic responsible for rejecting introspection requests specifying an invalid client secret. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientSecret : IOpenIddictServerHandler @@ -558,7 +556,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests made by + /// Contains the logic responsible for rejecting introspection requests made by /// applications that haven't been granted the introspection endpoint permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -611,7 +609,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that don't specify a valid token. + /// Contains the logic responsible for rejecting introspection requests that don't specify a valid token. /// public class ValidateToken : IOpenIddictServerHandler { @@ -667,7 +665,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that specify an unsupported token. + /// Contains the logic responsible for rejecting introspection requests that specify an unsupported token. /// public class ValidateTokenType : IOpenIddictServerHandler { @@ -704,7 +702,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting introspection requests that specify a token + /// Contains the logic responsible for rejecting introspection requests that specify a token /// that cannot be introspected by the client application sending the introspection requests. /// public class ValidateAuthorizedParty : IOpenIddictServerHandler @@ -769,7 +767,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the principal + /// Contains the logic responsible for attaching the principal /// extracted from the introspected token to the event context. /// public class AttachPrincipal : IOpenIddictServerHandler @@ -800,7 +798,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the metadata claims extracted from the token the event context. + /// Contains the logic responsible for attaching the metadata claims extracted from the token the event context. /// public class AttachMetadataClaims : IOpenIddictServerHandler { @@ -844,7 +842,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the application-specific claims extracted from the token the event context. + /// Contains the logic responsible for attaching the application-specific claims extracted from the token the event context. /// Note: this handler is not used when the degraded mode is enabled. /// public class AttachApplicationClaims : IOpenIddictServerHandler @@ -1010,7 +1008,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of converting introspection errors to standard active: false responses. + /// Contains the logic responsible for converting introspection errors to standard active: false responses. /// public class NormalizeErrorResponse : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs index 61936172..638ae209 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs @@ -45,7 +45,7 @@ public static partial class OpenIddictServerHandlers BeautifyToken.Descriptor); /// - /// Contains the logic responsible of resolving the validation parameters used to validate tokens. + /// Contains the logic responsible for resolving the validation parameters used to validate tokens. /// public class ResolveTokenValidationParameters : IOpenIddictServerHandler { @@ -113,7 +113,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating reference token identifiers. + /// Contains the logic responsible for validating reference token identifiers. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateReferenceTokenIdentifier : IOpenIddictServerHandler @@ -230,7 +230,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating tokens generated using IdentityModel. + /// Contains the logic responsible for validating tokens generated using IdentityModel. /// public class ValidateIdentityModelToken : IOpenIddictServerHandler { @@ -376,7 +376,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of normalizing the scope claims stored in the tokens. + /// Contains the logic responsible for normalizing the scope claims stored in the tokens. /// public class NormalizeScopeClaims : IOpenIddictServerHandler { @@ -416,7 +416,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of mapping internal claims used by OpenIddict. + /// Contains the logic responsible for mapping internal claims used by OpenIddict. /// public class MapInternalClaims : IOpenIddictServerHandler { @@ -440,7 +440,7 @@ public static partial class OpenIddictServerHandlers // To reduce the size of tokens, some of the private claims used by OpenIddict // are mapped to their standard equivalent before being removed from the token. - // This handler is responsible of adding back the private claims to the principal + // This handler is responsible for adding back the private claims to the principal // when receiving the token (e.g "oi_prst" is resolved from the "scope" claim). // In OpenIddict 3.0, the creation date of a token is stored in "oi_crt_dt". @@ -514,7 +514,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of restoring the properties associated with a reference token entry. + /// Contains the logic responsible for restoring the properties associated with a reference token entry. /// Note: this handler is not used when the degraded mode is enabled. /// public class RestoreReferenceTokenProperties : IOpenIddictServerHandler @@ -561,7 +561,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authentication demands for which no valid principal was resolved. + /// Contains the logic responsible for rejecting authentication demands for which no valid principal was resolved. /// public class ValidatePrincipal : IOpenIddictServerHandler { @@ -633,7 +633,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that use an expired token. + /// Contains the logic responsible for rejecting authentication demands that use an expired token. /// public class ValidateExpirationDate : IOpenIddictServerHandler { @@ -687,7 +687,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that + /// Contains the logic responsible for rejecting authentication demands that /// use a token whose entry is no longer valid (e.g was revoked). /// Note: this handler is not used when the degraded mode is enabled. /// @@ -885,7 +885,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of authentication demands a token whose + /// Contains the logic responsible for authentication demands a token whose /// associated authorization entry is no longer valid (e.g was revoked). /// Note: this handler is not used when the degraded mode is enabled. /// @@ -950,7 +950,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of resolving the signing and encryption credentials used to protect tokens. + /// Contains the logic responsible for resolving the signing and encryption credentials used to protect tokens. /// public class AttachSecurityCredentials : IOpenIddictServerHandler { @@ -993,7 +993,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of creating a token entry. + /// Contains the logic responsible for creating a token entry. /// Note: this handler is not used when the degraded mode is enabled. /// public class CreateTokenEntry : IOpenIddictServerHandler @@ -1085,7 +1085,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating a token using IdentityModel. + /// Contains the logic responsible for generating a token using IdentityModel. /// public class GenerateIdentityModelToken : IOpenIddictServerHandler { @@ -1203,7 +1203,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of converting the token to a reference token. + /// Contains the logic responsible for converting the token to a reference token. /// Note: this handler is not used when the degraded mode is enabled. /// public class ConvertReferenceToken : IOpenIddictServerHandler @@ -1305,7 +1305,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of beautifying user-typed tokens. + /// Contains the logic responsible for beautifying user-typed tokens. /// Note: this handler is not used when the degraded mode is enabled. /// public class BeautifyToken : IOpenIddictServerHandler @@ -1327,7 +1327,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(GenerateTokenContext context!!) { - // To make user codes easier to read and type by humans, a dash is automatically // appended before each new block of 4 integers. These dashes are expected to be // stripped from the user codes when receiving them at the verification endpoint. diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Revocation.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Revocation.cs index f7c0fda9..c7eccdb2 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Revocation.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Revocation.cs @@ -50,7 +50,7 @@ public static partial class OpenIddictServerHandlers NormalizeErrorResponse.Descriptor); /// - /// Contains the logic responsible of extracting revocation requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting revocation requests and invoking the corresponding event handlers. /// public class ExtractRevocationRequest : IOpenIddictServerHandler { @@ -107,7 +107,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating revocation requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating revocation requests and invoking the corresponding event handlers. /// public class ValidateRevocationRequest : IOpenIddictServerHandler { @@ -163,7 +163,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling revocation requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling revocation requests and invoking the corresponding event handlers. /// public class HandleRevocationRequest : IOpenIddictServerHandler { @@ -215,7 +215,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyRevocationResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -258,7 +258,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that don't specify a token. + /// Contains the logic responsible for rejecting revocation requests that don't specify a token. /// public class ValidateTokenParameter : IOpenIddictServerHandler { @@ -275,7 +275,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateRevocationRequestContext context!!) { - // Reject revocation requests missing the mandatory token parameter. if (string.IsNullOrEmpty(context.Request.Token)) { @@ -294,7 +293,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that don't specify a client identifier. + /// Contains the logic responsible for rejecting revocation requests that don't specify a client identifier. /// public class ValidateClientIdParameter : IOpenIddictServerHandler { @@ -311,7 +310,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ValidateRevocationRequestContext context!!) { - // At this stage, reject the revocation request unless the client identification requirement was disabled. if (!context.Options.AcceptAnonymousClients && string.IsNullOrEmpty(context.ClientId)) { @@ -330,7 +328,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that use an invalid client_id. + /// Contains the logic responsible for rejecting revocation requests that use an invalid client_id. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientId : IOpenIddictServerHandler @@ -377,7 +375,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests made by applications + /// Contains the logic responsible for rejecting revocation requests made by applications /// whose client type is not compatible with the presence or absence of a client secret. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -447,7 +445,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests specifying an invalid client secret. + /// Contains the logic responsible for rejecting revocation requests specifying an invalid client secret. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientSecret : IOpenIddictServerHandler @@ -505,7 +503,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests made by + /// Contains the logic responsible for rejecting revocation requests made by /// applications that haven't been granted the revocation endpoint permission. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -558,7 +556,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that don't specify a valid token. + /// Contains the logic responsible for rejecting revocation requests that don't specify a valid token. /// public class ValidateToken : IOpenIddictServerHandler { @@ -614,7 +612,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that specify an unsupported token. + /// Contains the logic responsible for rejecting revocation requests that specify an unsupported token. /// public class ValidateTokenType : IOpenIddictServerHandler { @@ -651,7 +649,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting revocation requests that specify a token + /// Contains the logic responsible for rejecting revocation requests that specify a token /// that cannot be revoked by the client application sending the revocation requests. /// public class ValidateAuthorizedParty : IOpenIddictServerHandler @@ -716,7 +714,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the principal + /// Contains the logic responsible for attaching the principal /// extracted from the revoked token to the event context. /// public class AttachPrincipal : IOpenIddictServerHandler @@ -747,7 +745,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of revoking the token sent by the client application. + /// Contains the logic responsible for revoking the token sent by the client application. /// Note: this handler is not used when the degraded mode is enabled. /// public class RevokeToken : IOpenIddictServerHandler @@ -816,7 +814,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of converting revocation errors to standard empty responses. + /// Contains the logic responsible for converting revocation errors to standard empty responses. /// public class NormalizeErrorResponse : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs index b089821f..c7294e7c 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs @@ -38,7 +38,7 @@ public static partial class OpenIddictServerHandlers AttachResponseState.Descriptor); /// - /// Contains the logic responsible of extracting logout requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting logout requests and invoking the corresponding event handlers. /// public class ExtractLogoutRequest : IOpenIddictServerHandler { @@ -95,7 +95,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating logout requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating logout requests and invoking the corresponding event handlers. /// public class ValidateLogoutRequest : IOpenIddictServerHandler { @@ -151,7 +151,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling logout requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling logout requests and invoking the corresponding event handlers. /// public class HandleLogoutRequest : IOpenIddictServerHandler { @@ -242,7 +242,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing sign-in responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing sign-in responses and invoking the corresponding event handlers. /// public class ApplyLogoutResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -285,7 +285,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting logout requests that specify an invalid post_logout_redirect_uri parameter. + /// Contains the logic responsible for rejecting logout requests that specify an invalid post_logout_redirect_uri parameter. /// public class ValidatePostLogoutRedirectUriParameter : IOpenIddictServerHandler { @@ -337,7 +337,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting logout requests that use an invalid redirect_uri. + /// Contains the logic responsible for rejecting logout requests that use an invalid redirect_uri. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateClientPostLogoutRedirectUri : IOpenIddictServerHandler @@ -398,7 +398,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of inferring the redirect URL + /// Contains the logic responsible for inferring the redirect URL /// used to send the response back to the client application. /// public class AttachPostLogoutRedirectUri : IOpenIddictServerHandler @@ -436,7 +436,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the state to the response. + /// Contains the logic responsible for attaching the state to the response. /// public class AttachResponseState : IOpenIddictServerHandler { @@ -453,7 +453,6 @@ public static partial class OpenIddictServerHandlers /// public ValueTask HandleAsync(ApplyLogoutResponseContext context!!) { - // Attach the request state to the logout response. if (string.IsNullOrEmpty(context.Response.State)) { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.Userinfo.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.Userinfo.cs index b528a2c8..184e22e8 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.Userinfo.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.Userinfo.cs @@ -40,7 +40,7 @@ public static partial class OpenIddictServerHandlers AttachClaims.Descriptor); /// - /// Contains the logic responsible of extracting userinfo requests and invoking the corresponding event handlers. + /// Contains the logic responsible for extracting userinfo requests and invoking the corresponding event handlers. /// public class ExtractUserinfoRequest : IOpenIddictServerHandler { @@ -97,7 +97,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating userinfo requests and invoking the corresponding event handlers. + /// Contains the logic responsible for validating userinfo requests and invoking the corresponding event handlers. /// public class ValidateUserinfoRequest : IOpenIddictServerHandler { @@ -153,7 +153,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of handling userinfo requests and invoking the corresponding event handlers. + /// Contains the logic responsible for handling userinfo requests and invoking the corresponding event handlers. /// public class HandleUserinfoRequest : IOpenIddictServerHandler { @@ -240,7 +240,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of processing userinfo responses and invoking the corresponding event handlers. + /// Contains the logic responsible for processing userinfo responses and invoking the corresponding event handlers. /// public class ApplyUserinfoResponse : IOpenIddictServerHandler where TContext : BaseRequestContext { @@ -283,7 +283,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting userinfo requests that don't specify an access token. + /// Contains the logic responsible for rejecting userinfo requests that don't specify an access token. /// public class ValidateAccessTokenParameter : IOpenIddictServerHandler { @@ -317,7 +317,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting userinfo requests that don't specify a valid token. + /// Contains the logic responsible for rejecting userinfo requests that don't specify a valid token. /// public class ValidateToken : IOpenIddictServerHandler { @@ -373,7 +373,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the principal + /// Contains the logic responsible for attaching the principal /// extracted from the access token to the event context. /// public class AttachPrincipal : IOpenIddictServerHandler @@ -404,7 +404,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the audiences to the userinfo response. + /// Contains the logic responsible for attaching the audiences to the userinfo response. /// public class AttachAudiences : IOpenIddictServerHandler { @@ -433,7 +433,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching well known claims to the userinfo response. + /// Contains the logic responsible for attaching well known claims to the userinfo response. /// public class AttachClaims : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerHandlers.cs b/src/OpenIddict.Server/OpenIddictServerHandlers.cs index 1a3a9cb3..27475abe 100644 --- a/src/OpenIddict.Server/OpenIddictServerHandlers.cs +++ b/src/OpenIddict.Server/OpenIddictServerHandlers.cs @@ -99,7 +99,7 @@ public static partial class OpenIddictServerHandlers .AddRange(Userinfo.DefaultHandlers); /// - /// Contains the logic responsible of rejecting authentication demands made from unsupported endpoints. + /// Contains the logic responsible for rejecting authentication demands made from unsupported endpoints. /// public class ValidateAuthenticationDemand : IOpenIddictServerHandler { @@ -138,7 +138,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of selecting the token types that should be validated. + /// Contains the logic responsible for selecting the token types that should be validated. /// public class EvaluateValidatedTokens : IOpenIddictServerHandler { @@ -233,7 +233,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of resolving the token from the incoming request. + /// Contains the logic responsible for resolving the token from the incoming request. /// public class ResolveValidatedTokens : IOpenIddictServerHandler { @@ -313,7 +313,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack required tokens. + /// Contains the logic responsible for rejecting authentication demands that lack required tokens. /// public class ValidateRequiredTokens : IOpenIddictServerHandler { @@ -351,7 +351,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the access token resolved from the context. + /// Contains the logic responsible for validating the access token resolved from the context. /// public class ValidateAccessToken : IOpenIddictServerHandler { @@ -413,7 +413,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the authorization code resolved from the context. + /// Contains the logic responsible for validating the authorization code resolved from the context. /// public class ValidateAuthorizationCode : IOpenIddictServerHandler { @@ -475,7 +475,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the device code resolved from the context. + /// Contains the logic responsible for validating the device code resolved from the context. /// public class ValidateDeviceCode : IOpenIddictServerHandler { @@ -537,7 +537,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating tokens of unknown types resolved from the context. + /// Contains the logic responsible for validating tokens of unknown types resolved from the context. /// public class ValidateGenericToken : IOpenIddictServerHandler { @@ -606,7 +606,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the identity token resolved from the context. + /// Contains the logic responsible for validating the identity token resolved from the context. /// public class ValidateIdentityToken : IOpenIddictServerHandler { @@ -671,7 +671,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the refresh token resolved from the context. + /// Contains the logic responsible for validating the refresh token resolved from the context. /// public class ValidateRefreshToken : IOpenIddictServerHandler { @@ -733,7 +733,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of validating the user code resolved from the context. + /// Contains the logic responsible for validating the user code resolved from the context. /// public class ValidateUserCode : IOpenIddictServerHandler { @@ -795,7 +795,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting challenge demands made from unsupported endpoints. + /// Contains the logic responsible for rejecting challenge demands made from unsupported endpoints. /// public class ValidateChallengeDemand : IOpenIddictServerHandler { @@ -825,7 +825,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of ensuring that the challenge response contains an appropriate error. + /// Contains the logic responsible for ensuring that the challenge response contains an appropriate error. /// public class AttachDefaultChallengeError : IOpenIddictServerHandler { @@ -889,7 +889,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting the device code entry associated with the user code. + /// Contains the logic responsible for rejecting the device code entry associated with the user code. /// Note: this handler is not used when the degraded mode is enabled. /// public class RejectDeviceCodeEntry : IOpenIddictServerHandler @@ -943,7 +943,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of rejecting the user code entry, if applicable. + /// Contains the logic responsible for rejecting the user code entry, if applicable. /// Note: this handler is not used when the degraded mode is enabled. /// public class RejectUserCodeEntry : IOpenIddictServerHandler @@ -997,7 +997,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the challenge response. + /// Contains the logic responsible for attaching the appropriate parameters to the challenge response. /// public class AttachChallengeParameters : IOpenIddictServerHandler { @@ -1027,7 +1027,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of ensuring that the sign-in demand + /// Contains the logic responsible for ensuring that the sign-in demand /// is compatible with the type of the endpoint that handled the request. /// public class ValidateSignInDemand : IOpenIddictServerHandler @@ -1092,7 +1092,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of re-attaching internal claims to the authentication principal. + /// Contains the logic responsible for re-attaching internal claims to the authentication principal. /// public class RestoreInternalClaims : IOpenIddictServerHandler { @@ -1175,7 +1175,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching default scopes to the authentication principal. + /// Contains the logic responsible for attaching default scopes to the authentication principal. /// public class AttachDefaultScopes : IOpenIddictServerHandler { @@ -1207,7 +1207,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching default presenters to the authentication principal. + /// Contains the logic responsible for attaching default presenters to the authentication principal. /// public class AttachDefaultPresenters : IOpenIddictServerHandler { @@ -1238,7 +1238,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of inferring resources from the audience claims if necessary. + /// Contains the logic responsible for inferring resources from the audience claims if necessary. /// public class InferResources : IOpenIddictServerHandler { @@ -1272,7 +1272,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of selecting the token types that + /// Contains the logic responsible for selecting the token types that /// should be generated and optionally returned in the response. /// public class EvaluateGeneratedTokens : IOpenIddictServerHandler @@ -1366,7 +1366,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of creating an ad-hoc authorization, if necessary. + /// Contains the logic responsible for creating an ad-hoc authorization, if necessary. /// Note: this handler is not used when the degraded mode is enabled. /// public class AttachAuthorization : IOpenIddictServerHandler @@ -1461,7 +1461,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the access token, if one is going to be returned. /// public class PrepareAccessTokenPrincipal : IOpenIddictServerHandler @@ -1574,7 +1574,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the authorization code, if one is going to be returned. /// public class PrepareAuthorizationCodePrincipal : IOpenIddictServerHandler @@ -1655,7 +1655,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the device code, if one is going to be returned. /// public class PrepareDeviceCodePrincipal : IOpenIddictServerHandler @@ -1723,7 +1723,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the refresh token, if one is going to be returned. /// public class PrepareRefreshTokenPrincipal : IOpenIddictServerHandler @@ -1802,7 +1802,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the identity token, if one is going to be returned. /// public class PrepareIdentityTokenPrincipal : IOpenIddictServerHandler @@ -1910,7 +1910,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of preparing and attaching the claims principal + /// Contains the logic responsible for preparing and attaching the claims principal /// used to generate the user code, if one is going to be returned. /// public class PrepareUserCodePrincipal : IOpenIddictServerHandler @@ -1974,7 +1974,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of redeeming the token entry corresponding to + /// Contains the logic responsible for redeeming the token entry corresponding to /// the received authorization code, device code, user code or refresh token. /// Note: this handler is not used when the degraded mode is enabled. /// @@ -2035,7 +2035,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating an access token for the current sign-in operation. + /// Contains the logic responsible for generating an access token for the current sign-in operation. /// public class GenerateAccessToken : IOpenIddictServerHandler { @@ -2097,7 +2097,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating an authorization code for the current sign-in operation. + /// Contains the logic responsible for generating an authorization code for the current sign-in operation. /// public class GenerateAuthorizationCode : IOpenIddictServerHandler { @@ -2157,7 +2157,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating a device code for the current sign-in operation. + /// Contains the logic responsible for generating a device code for the current sign-in operation. /// public class GenerateDeviceCode : IOpenIddictServerHandler { @@ -2224,7 +2224,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating a refresh token for the current sign-in operation. + /// Contains the logic responsible for generating a refresh token for the current sign-in operation. /// public class GenerateRefreshToken : IOpenIddictServerHandler { @@ -2286,7 +2286,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating and attaching the device code identifier to the user code principal. + /// Contains the logic responsible for generating and attaching the device code identifier to the user code principal. /// public class AttachDeviceCodeIdentifier : IOpenIddictServerHandler { @@ -2321,7 +2321,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of updating the existing reference device code entry. + /// Contains the logic responsible for updating the existing reference device code entry. /// Note: this handler is not used when the degraded mode is enabled. /// public class UpdateReferenceDeviceCodeEntry : IOpenIddictServerHandler @@ -2393,7 +2393,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating and attaching the hashes of + /// Contains the logic responsible for generating and attaching the hashes of /// the access token and authorization code to the identity token principal. /// public class AttachTokenDigests : IOpenIddictServerHandler @@ -2516,7 +2516,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating a user code for the current sign-in operation. + /// Contains the logic responsible for generating a user code for the current sign-in operation. /// public class GenerateUserCode : IOpenIddictServerHandler { @@ -2576,7 +2576,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of generating an identity token for the current sign-in operation. + /// Contains the logic responsible for generating an identity token for the current sign-in operation. /// public class GenerateIdentityToken : IOpenIddictServerHandler { @@ -2637,7 +2637,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the sign-in response. + /// Contains the logic responsible for attaching the appropriate parameters to the sign-in response. /// public class AttachSignInParameters : IOpenIddictServerHandler { @@ -2778,7 +2778,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of ensuring that the sign-out demand + /// Contains the logic responsible for ensuring that the sign-out demand /// is compatible with the type of the endpoint that handled the request. /// public class ValidateSignOutDemand : IOpenIddictServerHandler @@ -2806,7 +2806,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the sign-out response. + /// Contains the logic responsible for attaching the appropriate parameters to the sign-out response. /// public class AttachSignOutParameters : IOpenIddictServerHandler { @@ -2836,7 +2836,7 @@ public static partial class OpenIddictServerHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the error response. + /// Contains the logic responsible for attaching the appropriate parameters to the error response. /// public class AttachErrorParameters : IOpenIddictServerHandler { diff --git a/src/OpenIddict.Server/OpenIddictServerOptions.cs b/src/OpenIddict.Server/OpenIddictServerOptions.cs index 41ebf261..3ba95a07 100644 --- a/src/OpenIddict.Server/OpenIddictServerOptions.cs +++ b/src/OpenIddict.Server/OpenIddictServerOptions.cs @@ -236,7 +236,7 @@ public class OpenIddictServerOptions public bool EnableDegradedMode { get; set; } /// - /// Gets the list of the handlers responsible of processing the OpenIddict server operations. + /// Gets the list of the handlers responsible for processing the OpenIddict server operations. /// Note: the list is automatically sorted based on the order assigned to each handler descriptor. /// As such, it MUST NOT be mutated after options initialization to preserve the exact order. /// diff --git a/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHandlers.cs b/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHandlers.cs index c0afeb21..290da0a6 100644 --- a/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHandlers.cs +++ b/src/OpenIddict.Validation.AspNetCore/OpenIddictValidationAspNetCoreHandlers.cs @@ -56,7 +56,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers ProcessJsonResponse.Descriptor); /// - /// Contains the logic responsible of infering the default issuer from the HTTP request host and validating it. + /// Contains the logic responsible for infering the default issuer from the HTTP request host and validating it. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class InferIssuerFromHost : IOpenIddictValidationHandler @@ -115,7 +115,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting the access token from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractAccessTokenFromAuthorizationHeader : IOpenIddictValidationHandler @@ -161,7 +161,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard access_token form parameter. + /// Contains the logic responsible for extracting the access token from the standard access_token form parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractAccessTokenFromBodyForm : IOpenIddictValidationHandler @@ -211,7 +211,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard access_token query parameter. + /// Contains the logic responsible for extracting the access token from the standard access_token query parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ExtractAccessTokenFromQueryString : IOpenIddictValidationHandler @@ -256,7 +256,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching the error details using the ASP.NET Core authentication properties. + /// Contains the logic responsible for attaching the error details using the ASP.NET Core authentication properties. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachHostChallengeError : IOpenIddictValidationHandler @@ -326,7 +326,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching an appropriate HTTP status code. + /// Contains the logic responsible for attaching an appropriate HTTP status code. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachHttpResponseCode : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -368,7 +368,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching the appropriate HTTP response cache headers. + /// Contains the logic responsible for attaching the appropriate HTTP response cache headers. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachCacheControlHeader : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -402,7 +402,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of attaching errors details to the WWW-Authenticate header. + /// Contains the logic responsible for attaching errors details to the WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class AttachWwwAuthenticateHeader : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -504,7 +504,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of processing challenge responses that contain a WWW-Authenticate header. + /// Contains the logic responsible for processing challenge responses that contain a WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessChallengeErrorResponse : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -542,7 +542,7 @@ public static partial class OpenIddictValidationAspNetCoreHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be returned as JSON. + /// Contains the logic responsible for processing OpenID Connect responses that must be returned as JSON. /// Note: this handler is not used when the OpenID Connect request is not initially handled by ASP.NET Core. /// public class ProcessJsonResponse : IOpenIddictValidationHandler where TContext : BaseRequestContext diff --git a/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionHandlers.Protection.cs b/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionHandlers.Protection.cs index 14347b48..dd7e82ee 100644 --- a/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionHandlers.Protection.cs +++ b/src/OpenIddict.Validation.DataProtection/OpenIddictValidationDataProtectionHandlers.Protection.cs @@ -27,7 +27,7 @@ public static partial class OpenIddictValidationDataProtectionHandlers ValidateDataProtectionToken.Descriptor); /// - /// Contains the logic responsible of validating tokens generated using Data Protection. + /// Contains the logic responsible for validating tokens generated using Data Protection. /// public class ValidateDataProtectionToken : IOpenIddictValidationHandler { diff --git a/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHandlers.cs b/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHandlers.cs index bfe38fec..6dfd50f7 100644 --- a/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHandlers.cs +++ b/src/OpenIddict.Validation.Owin/OpenIddictValidationOwinHandlers.cs @@ -55,7 +55,7 @@ public static partial class OpenIddictValidationOwinHandlers ProcessJsonResponse.Descriptor); /// - /// Contains the logic responsible of infering the default issuer from the HTTP request host and validating it. + /// Contains the logic responsible for infering the default issuer from the HTTP request host and validating it. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class InferIssuerFromHost : IOpenIddictValidationHandler @@ -114,7 +114,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard HTTP Authorization header. + /// Contains the logic responsible for extracting the access token from the standard HTTP Authorization header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractAccessTokenFromAuthorizationHeader : IOpenIddictValidationHandler @@ -160,7 +160,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard access_token form parameter. + /// Contains the logic responsible for extracting the access token from the standard access_token form parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractAccessTokenFromBodyForm : IOpenIddictValidationHandler @@ -211,7 +211,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of extracting the access token from the standard access_token query parameter. + /// Contains the logic responsible for extracting the access token from the standard access_token query parameter. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ExtractAccessTokenFromQueryString : IOpenIddictValidationHandler @@ -257,7 +257,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of attaching the error details using the OWIN authentication properties. + /// Contains the logic responsible for attaching the error details using the OWIN authentication properties. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachHostChallengeError : IOpenIddictValidationHandler @@ -311,7 +311,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of attaching an appropriate HTTP status code. + /// Contains the logic responsible for attaching an appropriate HTTP status code. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachHttpResponseCode : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -353,7 +353,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of attaching the appropriate HTTP response cache headers. + /// Contains the logic responsible for attaching the appropriate HTTP response cache headers. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachCacheControlHeader : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -387,7 +387,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of attaching errors details to the WWW-Authenticate header. + /// Contains the logic responsible for attaching errors details to the WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class AttachWwwAuthenticateHeader : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -494,7 +494,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of processing challenge responses that contain a WWW-Authenticate header. + /// Contains the logic responsible for processing challenge responses that contain a WWW-Authenticate header. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessChallengeErrorResponse : IOpenIddictValidationHandler where TContext : BaseRequestContext @@ -532,7 +532,7 @@ public static partial class OpenIddictValidationOwinHandlers } /// - /// Contains the logic responsible of processing OpenID Connect responses that must be returned as JSON. + /// Contains the logic responsible for processing OpenID Connect responses that must be returned as JSON. /// Note: this handler is not used when the OpenID Connect request is not initially handled by OWIN. /// public class ProcessJsonResponse : IOpenIddictValidationHandler where TContext : BaseRequestContext diff --git a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.Introspection.cs b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.Introspection.cs index 55afb30b..231d2b6a 100644 --- a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.Introspection.cs +++ b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.Introspection.cs @@ -32,7 +32,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers DisposeHttpResponse.Descriptor); /// - /// Contains the logic responsible of attaching the client credentials to the HTTP Authorization header. + /// Contains the logic responsible for attaching the client credentials to the HTTP Authorization header. /// public class AttachBasicAuthenticationCredentials : IOpenIddictValidationHandler { diff --git a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.cs b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.cs index 7fb2764c..ed019a78 100644 --- a/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.cs +++ b/src/OpenIddict.Validation.SystemNetHttp/OpenIddictValidationSystemNetHttpHandlers.cs @@ -22,7 +22,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers .AddRange(Introspection.DefaultHandlers); /// - /// Contains the logic responsible of preparing an HTTP GET request message. + /// Contains the logic responsible for preparing an HTTP GET request message. /// public class PrepareGetHttpRequest : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -59,7 +59,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of preparing an HTTP POST request message. + /// Contains the logic responsible for preparing an HTTP POST request message. /// public class PreparePostHttpRequest : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -96,7 +96,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of attaching the query string parameters to the HTTP request. + /// Contains the logic responsible for attaching the query string parameters to the HTTP request. /// public class AttachQueryStringParameters : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -154,7 +154,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of attaching the form parameters to the HTTP request. + /// Contains the logic responsible for attaching the form parameters to the HTTP request. /// public class AttachFormParameters : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -192,7 +192,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of sending the HTTP request to the remote server. + /// Contains the logic responsible for sending the HTTP request to the remote server. /// public class SendHttpRequest : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -243,7 +243,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of disposing of the HTTP request message. + /// Contains the logic responsible for disposing of the HTTP request message. /// public class DisposeHttpRequest : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -276,7 +276,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of extracting the response from the JSON-encoded HTTP body. + /// Contains the logic responsible for extracting the response from the JSON-encoded HTTP body. /// public class ExtractJsonHttpResponse : IOpenIddictValidationHandler where TContext : BaseExternalContext { @@ -309,7 +309,7 @@ public static partial class OpenIddictValidationSystemNetHttpHandlers } /// - /// Contains the logic responsible of disposing of the HTTP response message. + /// Contains the logic responsible for disposing of the HTTP response message. /// public class DisposeHttpResponse : IOpenIddictValidationHandler where TContext : BaseExternalContext { diff --git a/src/OpenIddict.Validation/OpenIddictValidationEvents.cs b/src/OpenIddict.Validation/OpenIddictValidationEvents.cs index 67d7a52b..047917f7 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationEvents.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationEvents.cs @@ -48,7 +48,7 @@ public static partial class OpenIddictValidationEvents } /// - /// Gets the logger responsible of logging processed operations. + /// Gets the logger responsible for logging processed operations. /// public ILogger Logger => Transaction.Logger; diff --git a/src/OpenIddict.Validation/OpenIddictValidationHandlerDescriptor.cs b/src/OpenIddict.Validation/OpenIddictValidationHandlerDescriptor.cs index b8838703..3a952f29 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHandlerDescriptor.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHandlerDescriptor.cs @@ -28,7 +28,7 @@ public class OpenIddictValidationHandlerDescriptor public Type ContextType { get; private set; } = default!; /// - /// Gets the list of filters responsible of excluding the handler + /// Gets the list of filters responsible for excluding the handler /// from the activated handlers if it doesn't meet the criteria. /// public ImmutableArray FilterTypes { get; private set; } = ImmutableArray.Create(); diff --git a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Discovery.cs b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Discovery.cs index 89b31525..df8f2940 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Discovery.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Discovery.cs @@ -30,7 +30,7 @@ public static partial class OpenIddictValidationHandlers ExtractSigningKeys.Descriptor); /// - /// Contains the logic responsible of extracting the issuer from the discovery document. + /// Contains the logic responsible for extracting the issuer from the discovery document. /// public class ValidateIssuer : IOpenIddictValidationHandler { @@ -47,7 +47,6 @@ public static partial class OpenIddictValidationHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // The issuer returned in the discovery document must exactly match the URL used to access it. // See https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderConfigurationValidation. var issuer = (string?) context.Response[Metadata.Issuer]; @@ -78,7 +77,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the JWKS endpoint address from the discovery document. + /// Contains the logic responsible for extracting the JWKS endpoint address from the discovery document. /// public class ExtractCryptographyEndpoint : IOpenIddictValidationHandler { @@ -125,7 +124,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the introspection endpoint address from the discovery document. + /// Contains the logic responsible for extracting the introspection endpoint address from the discovery document. /// public class ExtractIntrospectionEndpoint : IOpenIddictValidationHandler { @@ -163,7 +162,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the authentication methods + /// Contains the logic responsible for extracting the authentication methods /// supported by the introspection endpoint from the discovery document. /// public class ExtractIntrospectionEndpointClientAuthenticationMethods : IOpenIddictValidationHandler @@ -181,7 +180,6 @@ public static partial class OpenIddictValidationHandlers /// public ValueTask HandleAsync(HandleConfigurationResponseContext context!!) { - // Resolve the client authentication methods supported by the introspection endpoint, if available. var methods = context.Response[Metadata.IntrospectionEndpointAuthMethodsSupported]?.GetUnnamedParameters(); if (methods is { Count: > 0 }) @@ -202,7 +200,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the signing keys from the JWKS document. + /// Contains the logic responsible for extracting the signing keys from the JWKS document. /// public class ExtractSigningKeys : IOpenIddictValidationHandler { diff --git a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Introspection.cs b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Introspection.cs index 2b08fd42..69b59510 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Introspection.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Introspection.cs @@ -34,7 +34,7 @@ public static partial class OpenIddictValidationHandlers PopulateClaims.Descriptor); /// - /// Contains the logic responsible of attaching the client credentials to the introspection request. + /// Contains the logic responsible for attaching the client credentials to the introspection request. /// public class AttachCredentials : IOpenIddictValidationHandler { @@ -59,7 +59,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of attaching the token to the introspection request. + /// Contains the logic responsible for attaching the token to the introspection request. /// public class AttachToken : IOpenIddictValidationHandler { @@ -84,7 +84,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the active: false marker from the response. + /// Contains the logic responsible for extracting the active: false marker from the response. /// public class HandleInactiveResponse : IOpenIddictValidationHandler { @@ -133,7 +133,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of validating the well-known claims contained in the introspection response. + /// Contains the logic responsible for validating the well-known claims contained in the introspection response. /// public class ValidateWellKnownClaims : IOpenIddictValidationHandler { @@ -204,7 +204,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the issuer from the introspection response. + /// Contains the logic responsible for extracting the issuer from the introspection response. /// public class ValidateIssuer : IOpenIddictValidationHandler { @@ -221,7 +221,6 @@ public static partial class OpenIddictValidationHandlers /// public ValueTask HandleAsync(HandleIntrospectionResponseContext context!!) { - // The issuer claim is optional. If it's not null or empty, validate it to // ensure it matches the issuer registered in the server configuration. var issuer = (string?) context.Response[Claims.Issuer]; @@ -253,7 +252,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting and validating the token usage from the introspection response. + /// Contains the logic responsible for extracting and validating the token usage from the introspection response. /// public class ValidateTokenUsage : IOpenIddictValidationHandler { @@ -270,7 +269,6 @@ public static partial class OpenIddictValidationHandlers /// public ValueTask HandleAsync(HandleIntrospectionResponseContext context!!) { - // OpenIddict-based authorization servers always return the actual token type using // the special "token_usage" claim, that helps resource servers determine whether the // introspected token is of the expected type and prevent token substitution attacks. @@ -308,7 +306,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting the claims from the introspection response. + /// Contains the logic responsible for extracting the claims from the introspection response. /// public class PopulateClaims : IOpenIddictValidationHandler { diff --git a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Protection.cs b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Protection.cs index 9d00d580..e12f4748 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHandlers.Protection.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHandlers.Protection.cs @@ -35,7 +35,7 @@ public static partial class OpenIddictValidationHandlers ValidateAuthorizationEntry.Descriptor); /// - /// Contains the logic responsible of resolving the validation parameters used to validate tokens. + /// Contains the logic responsible for resolving the validation parameters used to validate tokens. /// public class ResolveTokenValidationParameters : IOpenIddictValidationHandler { @@ -115,7 +115,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of validating reference token identifiers. + /// Contains the logic responsible for validating reference token identifiers. /// Note: this handler is not used when the degraded mode is enabled. /// public class ValidateReferenceTokenIdentifier : IOpenIddictValidationHandler @@ -142,7 +142,6 @@ public static partial class OpenIddictValidationHandlers /// public async ValueTask HandleAsync(ValidateTokenContext context!!) { - // Reference tokens are base64url-encoded payloads of exactly 256 bits (generated using a // crypto-secure RNG). If the token length differs, the token cannot be a reference token. if (context.Token.Length != 43) @@ -188,7 +187,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of validating tokens generated using IdentityModel. + /// Contains the logic responsible for validating tokens generated using IdentityModel. /// public class ValidateIdentityModelToken : IOpenIddictValidationHandler { @@ -272,7 +271,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of validating the tokens using OAuth 2.0 introspection. + /// Contains the logic responsible for validating the tokens using OAuth 2.0 introspection. /// public class IntrospectToken : IOpenIddictValidationHandler { @@ -376,7 +375,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of normalizing the scope claims stored in the tokens. + /// Contains the logic responsible for normalizing the scope claims stored in the tokens. /// public class NormalizeScopeClaims : IOpenIddictValidationHandler { @@ -416,7 +415,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of mapping internal claims used by OpenIddict. + /// Contains the logic responsible for mapping internal claims used by OpenIddict. /// public class MapInternalClaims : IOpenIddictValidationHandler { @@ -440,7 +439,7 @@ public static partial class OpenIddictValidationHandlers // To reduce the size of tokens, some of the private claims used by OpenIddict // are mapped to their standard equivalent before being removed from the token. - // This handler is responsible of adding back the private claims to the principal + // This handler is responsible for adding back the private claims to the principal // when receiving the token (e.g "oi_prst" is resolved from the "scope" claim). // In OpenIddict 3.0, the creation date of a token is stored in "oi_crt_dt". @@ -514,7 +513,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of restoring the properties associated with a reference token entry. + /// Contains the logic responsible for restoring the properties associated with a reference token entry. /// Note: this handler is not used when the degraded mode is enabled. /// public class RestoreReferenceTokenProperties : IOpenIddictValidationHandler @@ -562,7 +561,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of rejecting authentication demands for which no valid principal was resolved. + /// Contains the logic responsible for rejecting authentication demands for which no valid principal was resolved. /// public class ValidatePrincipal : IOpenIddictValidationHandler { @@ -609,7 +608,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of rejecting authentication demands containing expired access tokens. + /// Contains the logic responsible for rejecting authentication demands containing expired access tokens. /// public class ValidateExpirationDate : IOpenIddictValidationHandler { @@ -646,7 +645,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of rejecting authentication demands containing + /// Contains the logic responsible for rejecting authentication demands containing /// access tokens that were issued to be used by another audience/resource server. /// public class ValidateAudience : IOpenIddictValidationHandler @@ -705,7 +704,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of authentication demands a token whose + /// Contains the logic responsible for authentication demands a token whose /// associated token entry is no longer valid (e.g was revoked). /// Note: this handler is not used when the degraded mode is enabled. /// @@ -764,7 +763,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of authentication demands a token whose + /// Contains the logic responsible for authentication demands a token whose /// associated authorization entry is no longer valid (e.g was revoked). /// Note: this handler is not used when the degraded mode is enabled. /// diff --git a/src/OpenIddict.Validation/OpenIddictValidationHandlers.cs b/src/OpenIddict.Validation/OpenIddictValidationHandlers.cs index 2aa9404b..53bdb4f2 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationHandlers.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationHandlers.cs @@ -30,7 +30,7 @@ public static partial class OpenIddictValidationHandlers .AddRange(Protection.DefaultHandlers); /// - /// Contains the logic responsible of selecting the token types that should be validated. + /// Contains the logic responsible for selecting the token types that should be validated. /// public class EvaluateValidatedTokens : IOpenIddictValidationHandler { @@ -49,7 +49,7 @@ public static partial class OpenIddictValidationHandlers { (context.ExtractAccessToken, context.RequireAccessToken, context.ValidateAccessToken) = context.EndpointType switch { - // The validation handler is responsible of validating access tokens for endpoints + // The validation handler is responsible for validating access tokens for endpoints // it doesn't manage (typically, API endpoints using token authentication). // // As such, sending an access token is not mandatory: API endpoints that require @@ -70,7 +70,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of rejecting authentication demands that lack required tokens. + /// Contains the logic responsible for rejecting authentication demands that lack required tokens. /// public class ValidateRequiredTokens : IOpenIddictValidationHandler { @@ -102,7 +102,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of ensuring a token was correctly resolved from the context. + /// Contains the logic responsible for ensuring a token was correctly resolved from the context. /// public class ValidateAccessToken : IOpenIddictValidationHandler { @@ -164,7 +164,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of ensuring that the challenge response contains an appropriate error. + /// Contains the logic responsible for ensuring that the challenge response contains an appropriate error. /// public class AttachDefaultChallengeError : IOpenIddictValidationHandler { @@ -218,7 +218,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of attaching the appropriate parameters to the error response. + /// Contains the logic responsible for attaching the appropriate parameters to the error response. /// public class AttachErrorParameters : IOpenIddictValidationHandler { @@ -252,7 +252,7 @@ public static partial class OpenIddictValidationHandlers } /// - /// Contains the logic responsible of extracting potential errors from the response. + /// Contains the logic responsible for extracting potential errors from the response. /// public class HandleErrorResponse : IOpenIddictValidationHandler where TContext : BaseValidatingContext { diff --git a/src/OpenIddict.Validation/OpenIddictValidationOptions.cs b/src/OpenIddict.Validation/OpenIddictValidationOptions.cs index f17a5f3b..53bc6619 100644 --- a/src/OpenIddict.Validation/OpenIddictValidationOptions.cs +++ b/src/OpenIddict.Validation/OpenIddictValidationOptions.cs @@ -40,7 +40,7 @@ public class OpenIddictValidationOptions }; /// - /// Gets the list of the handlers responsible of processing the OpenIddict validation operations. + /// Gets the list of the handlers responsible for processing the OpenIddict validation operations. /// Note: the list is automatically sorted based on the order assigned to each handler descriptor. /// As such, it MUST NOT be mutated after options initialization to preserve the exact order. /// diff --git a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTestServer.cs b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTestServer.cs index 1d069866..a904ece3 100644 --- a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTestServer.cs +++ b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTestServer.cs @@ -41,7 +41,7 @@ public class OpenIddictServerAspNetCoreIntegrationTestServer : OpenIddictServerI public TestServer Server { get; } [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", - Justification = "The caller is responsible of disposing the test client.")] + Justification = "The caller is responsible for disposing the test client.")] public override ValueTask CreateClientAsync() => new(new OpenIddictServerIntegrationTestClient(Server.CreateClient())); diff --git a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Authentication.cs b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Authentication.cs index f8675fc9..de4307c9 100644 --- a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Authentication.cs +++ b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Authentication.cs @@ -12,7 +12,7 @@ namespace OpenIddict.Server.AspNetCore.IntegrationTests; public partial class OpenIddictServerAspNetCoreIntegrationTests : OpenIddictServerIntegrationTests { - [Fact(Skip = "The handler responsible of rejecting such requests has not been ported yet.")] + [Fact(Skip = "The handler responsible for rejecting such requests has not been ported yet.")] public async Task ExtractAuthorizationRequest_RequestIdParameterIsRejectedWhenRequestCachingIsDisabled() { // Arrange diff --git a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Session.cs b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Session.cs index 875caa01..a04d3411 100644 --- a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Session.cs +++ b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.Session.cs @@ -12,7 +12,7 @@ namespace OpenIddict.Server.AspNetCore.IntegrationTests; public partial class OpenIddictServerAspNetCoreIntegrationTests : OpenIddictServerIntegrationTests { - [Fact(Skip = "The handler responsible of rejecting such requests has not been ported yet.")] + [Fact(Skip = "The handler responsible for rejecting such requests has not been ported yet.")] public async Task ExtractLogoutRequest_RequestIdParameterIsRejectedWhenRequestCachingIsDisabled() { // Arrange diff --git a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.cs b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.cs index 346fec6b..b0246c61 100644 --- a/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.cs +++ b/test/OpenIddict.Server.AspNetCore.IntegrationTests/OpenIddictServerAspNetCoreIntegrationTests.cs @@ -798,7 +798,7 @@ public partial class OpenIddictServerAspNetCoreIntegrationTests : OpenIddictServ } [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", - Justification = "The caller is responsible of disposing the test server.")] + Justification = "The caller is responsible for disposing the test server.")] protected override #if SUPPORTS_GENERIC_HOST async diff --git a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTestServer.cs b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTestServer.cs index 44b85313..879a06b5 100644 --- a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTestServer.cs +++ b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTestServer.cs @@ -24,7 +24,7 @@ public class OpenIddictServerOwinIntegrationTestServer : OpenIddictServerIntegra public TestServer Server { get; } [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", - Justification = "The caller is responsible of disposing the test client.")] + Justification = "The caller is responsible for disposing the test client.")] public override ValueTask CreateClientAsync() => new(new OpenIddictServerIntegrationTestClient(Server.HttpClient)); diff --git a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Authentication.cs b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Authentication.cs index c22b9528..756df1b2 100644 --- a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Authentication.cs +++ b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Authentication.cs @@ -12,7 +12,7 @@ namespace OpenIddict.Server.Owin.IntegrationTests; public partial class OpenIddictServerOwinIntegrationTests : OpenIddictServerIntegrationTests { - [Fact(Skip = "The handler responsible of rejecting such requests has not been ported yet.")] + [Fact(Skip = "The handler responsible for rejecting such requests has not been ported yet.")] public async Task ExtractAuthorizationRequest_RequestIdParameterIsRejectedWhenRequestCachingIsDisabled() { // Arrange diff --git a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Session.cs b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Session.cs index 1dbb272b..74db6832 100644 --- a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Session.cs +++ b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.Session.cs @@ -12,7 +12,7 @@ namespace OpenIddict.Server.Owin.IntegrationTests; public partial class OpenIddictServerOwinIntegrationTests : OpenIddictServerIntegrationTests { - [Fact(Skip = "The handler responsible of rejecting such requests has not been ported yet.")] + [Fact(Skip = "The handler responsible for rejecting such requests has not been ported yet.")] public async Task ExtractLogoutRequest_RequestIdParameterIsRejectedWhenRequestCachingIsDisabled() { // Arrange diff --git a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.cs b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.cs index abf980d9..d3a646ec 100644 --- a/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.cs +++ b/test/OpenIddict.Server.Owin.IntegrationTests/OpenIddictServerOwinIntegrationTests.cs @@ -681,7 +681,7 @@ public partial class OpenIddictServerOwinIntegrationTests : OpenIddictServerInte } [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", - Justification = "The caller is responsible of disposing the test server.")] + Justification = "The caller is responsible for disposing the test server.")] protected override ValueTask CreateServerAsync(Action? configuration = null) { var services = new ServiceCollection();