From 4df77f181c8e68a2df37e8768b1483e8372f21d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Chalet?= Date: Sun, 17 Sep 2017 06:19:17 +0200 Subject: [PATCH] Update the discovery endpoint to return the request_parameter_supported/request_uri_parameter_supported parameters --- src/OpenIddict/OpenIddictProvider.Discovery.cs | 6 ++++-- test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/OpenIddict/OpenIddictProvider.Discovery.cs b/src/OpenIddict/OpenIddictProvider.Discovery.cs index 467c3503..83897077 100644 --- a/src/OpenIddict/OpenIddictProvider.Discovery.cs +++ b/src/OpenIddict/OpenIddictProvider.Discovery.cs @@ -44,9 +44,11 @@ namespace OpenIddict // excluded from the response by the OpenID Connect server middleware. context.Metadata[OpenIdConnectConstants.Metadata.ClaimsSupported] = new JArray(options.Claims); - // Note: the optional "claims" parameter is not supported by OpenIddict, - // so a "false" flag is returned to encourage clients not to use it. + // Note: the optional claims/request/request_uri parameters are not supported + // by OpenIddict, so "false" is returned to encourage clients not to use them. context.Metadata[OpenIdConnectConstants.Metadata.ClaimsParameterSupported] = false; + context.Metadata[OpenIdConnectConstants.Metadata.RequestParameterSupported] = false; + context.Metadata[OpenIdConnectConstants.Metadata.RequestUriParameterSupported] = false; var schemes = context.HttpContext.RequestServices.GetRequiredService(); diff --git a/test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs b/test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs index 87d4e311..962bf052 100644 --- a/test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs +++ b/test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs @@ -172,7 +172,7 @@ namespace OpenIddict.Tests } [Fact] - public async Task HandleConfigurationRequest_ClaimsParameterSupportedIsReturned() + public async Task HandleConfigurationRequest_DefaultParametersAreReturned() { // Arrange var server = CreateAuthorizationServer(); @@ -184,6 +184,8 @@ namespace OpenIddict.Tests // Assert Assert.False((bool) response[OpenIdConnectConstants.Metadata.ClaimsParameterSupported]); + Assert.False((bool) response[OpenIdConnectConstants.Metadata.RequestParameterSupported]); + Assert.False((bool) response[OpenIdConnectConstants.Metadata.RequestUriParameterSupported]); } [Fact]