From bf6922eeaf32a3e12a5f011a0a9038f3a93a64c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Chalet?= Date: Sun, 18 Oct 2020 04:14:52 +0200 Subject: [PATCH] Optimization: handle JsonValueKind.Null values earlier in OpenIddictParameter.WriteTo() --- .../Primitives/OpenIddictParameter.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs b/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs index ecdb7e4b..d6a05640 100644 --- a/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs +++ b/src/OpenIddict.Abstractions/Primitives/OpenIddictParameter.cs @@ -517,6 +517,7 @@ namespace OpenIddict.Abstractions // Note: undefined JsonElement values are assimilated to null values. case null: case JsonElement { ValueKind: JsonValueKind.Undefined }: + case JsonElement { ValueKind: JsonValueKind.Null }: writer.WriteNullValue(); break; @@ -897,8 +898,8 @@ namespace OpenIddict.Abstractions string value => string.IsNullOrEmpty(value), string?[] value => value.Length == 0, - JsonElement { ValueKind: JsonValueKind.Undefined } value => true, - JsonElement { ValueKind: JsonValueKind.Null } value => true, + JsonElement { ValueKind: JsonValueKind.Undefined } => true, + JsonElement { ValueKind: JsonValueKind.Null } => true, JsonElement { ValueKind: JsonValueKind.String } value => string.IsNullOrEmpty(value.GetString()), JsonElement { ValueKind: JsonValueKind.Array } value => value.GetArrayLength() == 0, JsonElement { ValueKind: JsonValueKind.Object } value => IsEmptyNode(value),